2011-06-28 Wyatt Carss <wcarss@chromium.org>
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 28 Jun 2011 09:54:48 +0000 (09:54 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 28 Jun 2011 09:54:48 +0000 (09:54 +0000)
        Reviewed by Hajime Morita.

        convert editing/deleting/4845371.html to runDumpAsTextEditingTest
        https://bugs.webkit.org/show_bug.cgi?id=63214

        Renamed editing/deleting/4845371.html to editing/deleting/delete-cell-contents.html
        and converted editing/deleting/delete-cell-contents.html to runDumpAsTextEditingTest; left
        it without a doctype, etc, because they changed functionality of the image test. Also
        added the rdar number.

        * editing/deleting/delete-cell-contents-expected.txt: Added.
        * editing/deleting/delete-cell-contents.html: Added.
        * editing/deleting/4845371.html: Removed.
        * platform/chromium-linux/editing/deleting/4845371-expected.png: Removed.
        * platform/chromium-mac-leopard/editing/deleting/4845371-expected.png: Removed.
        * platform/chromium-win/editing/deleting/4845371-expected.png: Removed.
        * platform/chromium-win/editing/deleting/4845371-expected.txt: Removed.
        * platform/gtk/editing/deleting/4845371-expected.png: Removed.
        * platform/gtk/editing/deleting/4845371-expected.txt: Removed.
        * platform/mac-leopard/editing/deleting/4845371-expected.png: Removed.
        * platform/mac/editing/deleting/4845371-expected.png: Removed.
        * platform/mac/editing/deleting/4845371-expected.txt: Removed.
        * platform/qt/editing/deleting/4845371-expected.png: Removed.
        * platform/qt/editing/deleting/4845371-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 files changed:
LayoutTests/ChangeLog
LayoutTests/editing/deleting/delete-cell-contents-expected.txt [moved from LayoutTests/platform/chromium-win/editing/deleting/4845371-expected.txt with 54% similarity]
LayoutTests/editing/deleting/delete-cell-contents.html [moved from LayoutTests/editing/deleting/4845371.html with 83% similarity]
LayoutTests/platform/chromium-linux/editing/deleting/4845371-expected.png [deleted file]
LayoutTests/platform/chromium-mac-leopard/editing/deleting/4845371-expected.png [deleted file]
LayoutTests/platform/chromium-win/editing/deleting/4845371-expected.png [deleted file]
LayoutTests/platform/gtk/editing/deleting/4845371-expected.png [deleted file]
LayoutTests/platform/gtk/editing/deleting/4845371-expected.txt [deleted file]
LayoutTests/platform/mac-leopard/editing/deleting/4845371-expected.png [deleted file]
LayoutTests/platform/mac/editing/deleting/4845371-expected.png [deleted file]
LayoutTests/platform/mac/editing/deleting/4845371-expected.txt [deleted file]
LayoutTests/platform/qt/editing/deleting/4845371-expected.png [deleted file]
LayoutTests/platform/qt/editing/deleting/4845371-expected.txt [deleted file]

index 7d509ba..6c58695 100644 (file)
@@ -1,3 +1,30 @@
+2011-06-28  Wyatt Carss  <wcarss@chromium.org>
+
+        Reviewed by Hajime Morita.
+
+        convert editing/deleting/4845371.html to runDumpAsTextEditingTest
+        https://bugs.webkit.org/show_bug.cgi?id=63214
+
+        Renamed editing/deleting/4845371.html to editing/deleting/delete-cell-contents.html 
+        and converted editing/deleting/delete-cell-contents.html to runDumpAsTextEditingTest; left
+        it without a doctype, etc, because they changed functionality of the image test. Also 
+        added the rdar number.
+
+        * editing/deleting/delete-cell-contents-expected.txt: Added.
+        * editing/deleting/delete-cell-contents.html: Added.
+        * editing/deleting/4845371.html: Removed.
+        * platform/chromium-linux/editing/deleting/4845371-expected.png: Removed.
+        * platform/chromium-mac-leopard/editing/deleting/4845371-expected.png: Removed.
+        * platform/chromium-win/editing/deleting/4845371-expected.png: Removed.
+        * platform/chromium-win/editing/deleting/4845371-expected.txt: Removed.
+        * platform/gtk/editing/deleting/4845371-expected.png: Removed.
+        * platform/gtk/editing/deleting/4845371-expected.txt: Removed.
+        * platform/mac-leopard/editing/deleting/4845371-expected.png: Removed.
+        * platform/mac/editing/deleting/4845371-expected.png: Removed.
+        * platform/mac/editing/deleting/4845371-expected.txt: Removed.
+        * platform/qt/editing/deleting/4845371-expected.png: Removed.
+        * platform/qt/editing/deleting/4845371-expected.txt: Removed.
+
 2011-06-28  Kentaro Hara  <haraken@google.com>
 
         Reviewed by Kent Tamura.
@@ -9,21 +9,8 @@ EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotificatio
 EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 0 of TD > TR > TBODY > TABLE > DIV > BODY > HTML > #document to 0 of TD > TR > TBODY > TABLE > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
-layer at (0,0) size 800x600
-  RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
-  RenderBlock {HTML} at (0,0) size 800x600
-    RenderBody {BODY} at (8,8) size 784x584
-      RenderBlock {P} at (0,0) size 784x20
-        RenderText {#text} at (0,0) size 364x19
-          text run at (0,0) width 364: "This tests for a crasher when deleting contents of a table cell."
-      RenderBlock {DIV} at (0,36) size 784x26
-        RenderTable {TABLE} at (0,0) size 31x26
-          RenderTableSection {TBODY} at (0,0) size 31x26
-            RenderTableRow {TR} at (0,2) size 31x22
-              RenderTableCell {TD} at (2,2) size 2x22 [r=0 c=0 rs=1 cs=1]
-                RenderBR {BR} at (1,1) size 0x19
-              RenderTableCell {TD} at (6,2) size 23x22 [r=0 c=1 rs=1 cs=1]
-                RenderText {#text} at (1,1) size 21x19
-                  text run at (1,1) width 21: "baz"
-caret: position 0 of child 0 {BR} of child 0 {TD} of child 0 {TR} of child 0 {TBODY} of child 0 {TABLE} of child 2 {DIV} of body
+This tests for a crasher when deleting contents of a table cell. <radr://problem/4845371>
+
+
+baz
+
@@ -1,9 +1,9 @@
-<p>This tests for a crasher when deleting contents of a table cell.</p>
+<p>This tests for a crasher when deleting contents of a table cell. <a href="radr://problem/4845371">&lt;radr://problem/4845371&gt;</a></p>
 <div id="div" contenteditable="true"><table><tr><td>foo <a href="http://www.google.com/">bar</a></td><td>baz</td></tr></table></div>
 
 <script src="../editing.js"></script>
 <script>
-runEditingTest();
+runDumpAsTextEditingTest(true);
 
 function editingTest() {
     var div = document.getElementById("div");
diff --git a/LayoutTests/platform/chromium-linux/editing/deleting/4845371-expected.png b/LayoutTests/platform/chromium-linux/editing/deleting/4845371-expected.png
deleted file mode 100644 (file)
index cafc27d..0000000
Binary files a/LayoutTests/platform/chromium-linux/editing/deleting/4845371-expected.png and /dev/null differ
diff --git a/LayoutTests/platform/chromium-mac-leopard/editing/deleting/4845371-expected.png b/LayoutTests/platform/chromium-mac-leopard/editing/deleting/4845371-expected.png
deleted file mode 100644 (file)
index c0379b2..0000000
Binary files a/LayoutTests/platform/chromium-mac-leopard/editing/deleting/4845371-expected.png and /dev/null differ
diff --git a/LayoutTests/platform/chromium-win/editing/deleting/4845371-expected.png b/LayoutTests/platform/chromium-win/editing/deleting/4845371-expected.png
deleted file mode 100644 (file)
index 0b84175..0000000
Binary files a/LayoutTests/platform/chromium-win/editing/deleting/4845371-expected.png and /dev/null differ
diff --git a/LayoutTests/platform/gtk/editing/deleting/4845371-expected.png b/LayoutTests/platform/gtk/editing/deleting/4845371-expected.png
deleted file mode 100644 (file)
index e8b211f..0000000
Binary files a/LayoutTests/platform/gtk/editing/deleting/4845371-expected.png and /dev/null differ
diff --git a/LayoutTests/platform/gtk/editing/deleting/4845371-expected.txt b/LayoutTests/platform/gtk/editing/deleting/4845371-expected.txt
deleted file mode 100644 (file)
index bdfc9cf..0000000
+++ /dev/null
@@ -1,29 +0,0 @@
-EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of DIV > BODY > HTML > #document to 1 of DIV > BODY > HTML > #document
-EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: shouldDeleteDOMRange:range from 0 of #text > TD > TR > TBODY > TABLE > DIV > BODY > HTML > #document to 3 of #text > A > TD > TR > TBODY > TABLE > DIV > BODY > HTML > #document
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 0 of TD > TR > TBODY > TABLE > DIV > BODY > HTML > #document to 0 of TD > TR > TBODY > TABLE > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
-layer at (0,0) size 800x600
-  RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
-  RenderBlock {HTML} at (0,0) size 800x600
-    RenderBody {BODY} at (8,8) size 784x584
-      RenderBlock {P} at (0,0) size 784x19
-        RenderText {#text} at (0,0) size 382x19
-          text run at (0,0) width 382: "This tests for a crasher when deleting contents of a table cell."
-      RenderBlock {DIV} at (0,35) size 784x25
-        RenderTable {TABLE} at (0,0) size 32x25
-          RenderTableSection {TBODY} at (0,0) size 32x25
-            RenderTableRow {TR} at (0,2) size 32x21
-              RenderTableCell {TD} at (2,2) size 2x21 [r=0 c=0 rs=1 cs=1]
-                RenderBR {BR} at (1,1) size 0x19
-              RenderTableCell {TD} at (6,2) size 24x21 [r=0 c=1 rs=1 cs=1]
-                RenderText {#text} at (1,1) size 22x19
-                  text run at (1,1) width 22: "baz"
-caret: position 0 of child 0 {BR} of child 0 {TD} of child 0 {TR} of child 0 {TBODY} of child 0 {TABLE} of child 2 {DIV} of body
diff --git a/LayoutTests/platform/mac-leopard/editing/deleting/4845371-expected.png b/LayoutTests/platform/mac-leopard/editing/deleting/4845371-expected.png
deleted file mode 100644 (file)
index 7fce5d0..0000000
Binary files a/LayoutTests/platform/mac-leopard/editing/deleting/4845371-expected.png and /dev/null differ
diff --git a/LayoutTests/platform/mac/editing/deleting/4845371-expected.png b/LayoutTests/platform/mac/editing/deleting/4845371-expected.png
deleted file mode 100644 (file)
index ea12db3..0000000
Binary files a/LayoutTests/platform/mac/editing/deleting/4845371-expected.png and /dev/null differ
diff --git a/LayoutTests/platform/mac/editing/deleting/4845371-expected.txt b/LayoutTests/platform/mac/editing/deleting/4845371-expected.txt
deleted file mode 100644 (file)
index 6049a32..0000000
+++ /dev/null
@@ -1,29 +0,0 @@
-EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of DIV > BODY > HTML > #document to 1 of DIV > BODY > HTML > #document
-EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: shouldDeleteDOMRange:range from 0 of #text > TD > TR > TBODY > TABLE > DIV > BODY > HTML > #document to 3 of #text > A > TD > TR > TBODY > TABLE > DIV > BODY > HTML > #document
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 0 of TD > TR > TBODY > TABLE > DIV > BODY > HTML > #document to 0 of TD > TR > TBODY > TABLE > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
-layer at (0,0) size 800x600
-  RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
-  RenderBlock {HTML} at (0,0) size 800x600
-    RenderBody {BODY} at (8,8) size 784x584
-      RenderBlock {P} at (0,0) size 784x18
-        RenderText {#text} at (0,0) size 382x18
-          text run at (0,0) width 382: "This tests for a crasher when deleting contents of a table cell."
-      RenderBlock {DIV} at (0,34) size 784x24
-        RenderTable {TABLE} at (0,0) size 32x24
-          RenderTableSection {TBODY} at (0,0) size 32x24
-            RenderTableRow {TR} at (0,2) size 32x20
-              RenderTableCell {TD} at (2,2) size 2x20 [r=0 c=0 rs=1 cs=1]
-                RenderBR {BR} at (1,1) size 0x18
-              RenderTableCell {TD} at (6,2) size 24x20 [r=0 c=1 rs=1 cs=1]
-                RenderText {#text} at (1,1) size 22x18
-                  text run at (1,1) width 22: "baz"
-caret: position 0 of child 0 {BR} of child 0 {TD} of child 0 {TR} of child 0 {TBODY} of child 0 {TABLE} of child 2 {DIV} of body
diff --git a/LayoutTests/platform/qt/editing/deleting/4845371-expected.png b/LayoutTests/platform/qt/editing/deleting/4845371-expected.png
deleted file mode 100644 (file)
index ab8a65f..0000000
Binary files a/LayoutTests/platform/qt/editing/deleting/4845371-expected.png and /dev/null differ
diff --git a/LayoutTests/platform/qt/editing/deleting/4845371-expected.txt b/LayoutTests/platform/qt/editing/deleting/4845371-expected.txt
deleted file mode 100644 (file)
index 460c086..0000000
+++ /dev/null
@@ -1,29 +0,0 @@
-EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of DIV > BODY > HTML > #document to 1 of DIV > BODY > HTML > #document
-EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: shouldDeleteDOMRange:range from 0 of #text > TD > TR > TBODY > TABLE > DIV > BODY > HTML > #document to 3 of #text > A > TD > TR > TBODY > TABLE > DIV > BODY > HTML > #document
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 0 of TD > TR > TBODY > TABLE > DIV > BODY > HTML > #document to 0 of TD > TR > TBODY > TABLE > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
-layer at (0,0) size 800x600
-  RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
-  RenderBlock {HTML} at (0,0) size 800x600
-    RenderBody {BODY} at (8,8) size 784x584
-      RenderBlock {P} at (0,0) size 784x22
-        RenderText {#text} at (0,0) size 408x22
-          text run at (0,0) width 408: "This tests for a crasher when deleting contents of a table cell."
-      RenderBlock {DIV} at (0,38) size 784x28
-        RenderTable {TABLE} at (0,0) size 34x28
-          RenderTableSection {TBODY} at (0,0) size 34x28
-            RenderTableRow {TR} at (0,2) size 34x24
-              RenderTableCell {TD} at (2,2) size 2x24 [r=0 c=0 rs=1 cs=1]
-                RenderBR {BR} at (1,1) size 0x22
-              RenderTableCell {TD} at (6,2) size 26x24 [r=0 c=1 rs=1 cs=1]
-                RenderText {#text} at (1,1) size 24x22
-                  text run at (1,1) width 24: "baz"
-caret: position 0 of child 0 {BR} of child 0 {TD} of child 0 {TR} of child 0 {TBODY} of child 0 {TABLE} of child 2 {DIV} of body