REGRESSION (r255961): Default state for data URL handling is incorrect
authorbfulgham@apple.com <bfulgham@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 14 Feb 2020 00:12:06 +0000 (00:12 +0000)
committerbfulgham@apple.com <bfulgham@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 14 Feb 2020 00:12:06 +0000 (00:12 +0000)
https://bugs.webkit.org/show_bug.cgi?id=207719
<rdar://problem/59334011>

Reviewed by Chris Dumez.

The default selected in r255961 breaks too many WebKit framework users. Switch from opt-out to opt-in
while we work through compatibility issues.

Source/WebCore:

Tested by existing test cases.

* page/Settings.yaml:

Source/WebKit:

* UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration init]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/page/Settings.yaml
Source/WebKit/ChangeLog
Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm

index bd215c2..e177915 100644 (file)
@@ -1,3 +1,18 @@
+2020-02-13  Brent Fulgham  <bfulgham@apple.com>
+
+        REGRESSION (r255961): Default state for data URL handling is incorrect
+        https://bugs.webkit.org/show_bug.cgi?id=207719
+        <rdar://problem/59334011>
+
+        Reviewed by Chris Dumez.
+
+        The default selected in r255961 breaks too many WebKit framework users. Switch from opt-out to opt-in
+        while we work through compatibility issues.
+
+        Tested by existing test cases.
+
+        * page/Settings.yaml:
+
 2020-02-13  Keith Rollin  <krollin@apple.com>
 
         Add missing call to completionHandler
index 4ce92e2..8b9951c 100644 (file)
@@ -108,7 +108,7 @@ allowSettingAnyXHRHeaderFromFileURLs:
 allowCrossOriginSubresourcesToAskForCredentials:
   initial: false
 allowTopNavigationToDataURLs:
-  initial: false
+  initial: true
 needsStorageAccessFromFileURLsQuirk:
   initial: true
 needsFrameNameFallbackToIdQuirk:
index 15347ab..2be6c23 100644 (file)
@@ -1,3 +1,17 @@
+2020-02-13  Brent Fulgham  <bfulgham@apple.com>
+
+        REGRESSION (r255961): Default state for data URL handling is incorrect
+        https://bugs.webkit.org/show_bug.cgi?id=207719
+        <rdar://problem/59334011>
+
+        Reviewed by Chris Dumez.
+
+        The default selected in r255961 breaks too many WebKit framework users. Switch from opt-out to opt-in
+        while we work through compatibility issues.
+
+        * UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
+        (-[WKWebViewConfiguration init]):
+
 2020-02-13  Commit Queue  <commit-queue@webkit.org>
 
         Unreviewed, rolling out r254557.
index e171361..be38b9d 100644 (file)
@@ -236,7 +236,7 @@ static bool defaultShouldDecidePolicyBeforeLoadingQuickLookPreview()
     _convertsPositionStyleOnCopy = NO;
     _allowsMetaRefresh = YES;
     _allowUniversalAccessFromFileURLs = NO;
-    _allowTopNavigationToDataURLs = NO;
+    _allowTopNavigationToDataURLs = YES;
     _needsStorageAccessFromFileURLsQuirk = YES;
 
 #if PLATFORM(IOS_FAMILY)