2010-11-25 Sheriff Bot <webkit.review.bot@gmail.com>
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 25 Nov 2010 17:17:03 +0000 (17:17 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 25 Nov 2010 17:17:03 +0000 (17:17 +0000)
        Unreviewed, rolling out r72734.
        http://trac.webkit.org/changeset/72734
        https://bugs.webkit.org/show_bug.cgi?id=50086

        Backing out 72732 which made Qt sad and crashy (Requested by
        kling on #webkit).

        * platform/network/qt/ResourceHandleQt.cpp:
        (WebCore::ResourceHandle::loadResourceSynchronously):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog
WebCore/platform/network/qt/ResourceHandleQt.cpp

index 2c71cef..c2f9a37 100644 (file)
@@ -1,3 +1,15 @@
+2010-11-25  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r72734.
+        http://trac.webkit.org/changeset/72734
+        https://bugs.webkit.org/show_bug.cgi?id=50086
+
+        Backing out 72732 which made Qt sad and crashy (Requested by
+        kling on #webkit).
+
+        * platform/network/qt/ResourceHandleQt.cpp:
+        (WebCore::ResourceHandle::loadResourceSynchronously):
+
 2010-11-25  Andreas Kling  <kling@webkit.org>
 
         Unreviewed crash fix for Qt 4.6.x.
index 41ed1b1..46d544d 100644 (file)
@@ -211,7 +211,7 @@ void ResourceHandle::loadResourceSynchronously(NetworkingContext* context, const
 
     QNetworkReply* reply = d->m_job->reply();
     // When using synchronous calls, we are finished when reaching this point.
-    if (reply && reply->isFinished()) {
+    if (reply->isFinished()) {
         syncLoader.setReplyFinished(true);
         d->m_job->forwardData();
         d->m_job->finish();