fast/text/multiple-codeunit-vertical-upright.html is failing
authormmaxfield@apple.com <mmaxfield@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 14 May 2020 06:58:46 +0000 (06:58 +0000)
committermmaxfield@apple.com <mmaxfield@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 14 May 2020 06:58:46 +0000 (06:58 +0000)
https://bugs.webkit.org/show_bug.cgi?id=211860
<rdar://problem/31893714>

Reviewed by Megan Gardner.

Font metrics were hard-coded into the test. This patch adds a new font,
Ahem-multi-code-unit.ttf, which has predictable metrics so we don't have
to bake in the metrics into the test. The test is no longer sensitive
to fallback fonts and their metrics.

* fast/text/multiple-codeunit-vertical-upright-2-expected.html: Added.
* fast/text/multiple-codeunit-vertical-upright-2.html: Added.
* fast/text/multiple-codeunit-vertical-upright-expected.html:
* fast/text/multiple-codeunit-vertical-upright.html:
* fast/text/resources/Ahem-multi-code-unit.ttf: Added.
* platform/ios/TestExpectations:
* platform/mac-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@261678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/fast/text/multiple-codeunit-vertical-upright-2-expected.html [new file with mode: 0644]
LayoutTests/fast/text/multiple-codeunit-vertical-upright-2.html [new file with mode: 0644]
LayoutTests/fast/text/multiple-codeunit-vertical-upright-expected.html
LayoutTests/fast/text/multiple-codeunit-vertical-upright.html
LayoutTests/fast/text/resources/Ahem-multi-code-unit.ttf [new file with mode: 0644]
LayoutTests/platform/ios/TestExpectations
LayoutTests/platform/mac-wk1/TestExpectations

index 50dd4fd..3e34aca 100644 (file)
@@ -1,3 +1,24 @@
+2020-05-13  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        fast/text/multiple-codeunit-vertical-upright.html is failing
+        https://bugs.webkit.org/show_bug.cgi?id=211860
+        <rdar://problem/31893714>
+
+        Reviewed by Megan Gardner.
+
+        Font metrics were hard-coded into the test. This patch adds a new font,
+        Ahem-multi-code-unit.ttf, which has predictable metrics so we don't have
+        to bake in the metrics into the test. The test is no longer sensitive
+        to fallback fonts and their metrics.
+
+        * fast/text/multiple-codeunit-vertical-upright-2-expected.html: Added.
+        * fast/text/multiple-codeunit-vertical-upright-2.html: Added.
+        * fast/text/multiple-codeunit-vertical-upright-expected.html:
+        * fast/text/multiple-codeunit-vertical-upright.html:
+        * fast/text/resources/Ahem-multi-code-unit.ttf: Added.
+        * platform/ios/TestExpectations:
+        * platform/mac-wk1/TestExpectations:
+
 2020-05-13  Lauro Moura  <lmoura@igalia.com>
 
         [GTK][WPE] Move shared fast test expectations files to glib
diff --git a/LayoutTests/fast/text/multiple-codeunit-vertical-upright-2-expected.html b/LayoutTests/fast/text/multiple-codeunit-vertical-upright-2-expected.html
new file mode 100644 (file)
index 0000000..cd12378
--- /dev/null
@@ -0,0 +1,15 @@
+<!DOCTYPE html>
+<html>
+<head>
+<style>
+@font-face {
+    font-family: "WebFont";
+    src: url("resources/Ahem-multi-code-unit.ttf") format("truetype");
+}
+</style>
+</head>
+<body style="-webkit-font-smoothing: none;">
+<div style="position: absolute; top: 120px;">This test makes sure that upright vertical text is rendered the same as horizontal text. The test passes if you see a vertical line above.</div>
+<div style="font: 100px 'WebFont'; position: relative; display: inline-block;">&#x2000c;</div>
+</body>
+</html>
diff --git a/LayoutTests/fast/text/multiple-codeunit-vertical-upright-2.html b/LayoutTests/fast/text/multiple-codeunit-vertical-upright-2.html
new file mode 100644 (file)
index 0000000..4d5bd17
--- /dev/null
@@ -0,0 +1,15 @@
+<!DOCTYPE html>
+<html>
+<head>
+<style>
+@font-face {
+    font-family: "WebFont";
+    src: url("resources/Ahem-multi-code-unit.ttf") format("truetype");
+}
+</style>
+</head>
+<body style="-webkit-font-smoothing: none;">
+<div style="position: absolute; top: 120px;">This test makes sure that upright vertical text is rendered the same as horizontal text. The test passes if you see a vertical line above.</div>
+<div style="font: 100px 'WebFont'; -webkit-writing-mode: vertical-rl; -webkit-text-orientation: upright;">&#x2000c;</div>
+</body>
+</html>
index ce33c15..0b645b6 100644 (file)
@@ -1,9 +1,15 @@
 <!DOCTYPE html>
 <html>
 <head>
+<style>
+@font-face {
+    font-family: "WebFont";
+    src: url("resources/Ahem-multi-code-unit.ttf") format("truetype");
+}
+</style>
 </head>
 <body style="-webkit-font-smoothing: none;">
-<div style="position: absolute; top: 100px;">This test makes sure that upright vertical text is rendered the same as horizontal text.</div>
-<div style="font: 96px Times; position: relative; left: 29px; top: -23px; display: inline-block;">&#x2000b;</div>
+<div style="position: absolute; top: 120px;">This test makes sure that upright vertical text is rendered the same as horizontal text. The test passes if you see a horizontal line above.</div>
+<div style="font: 100px 'WebFont'; position: relative; display: inline-block;">&#x2000b;</div>
 </body>
 </html>
index 1ac1365..b067b98 100644 (file)
@@ -1,9 +1,15 @@
 <!DOCTYPE html>
 <html>
 <head>
+<style>
+@font-face {
+    font-family: "WebFont";
+    src: url("resources/Ahem-multi-code-unit.ttf") format("truetype");
+}
+</style>
 </head>
 <body style="-webkit-font-smoothing: none;">
-<div style="position: absolute; top: 100px;">This test makes sure that upright vertical text is rendered the same as horizontal text.</div>
-<div style="font: 96px Times; -webkit-writing-mode: vertical-rl; -webkit-text-orientation: upright;">&#x2000b;</div>
+<div style="position: absolute; top: 120px;">This test makes sure that upright vertical text is rendered the same as horizontal text. The test passes if you see a horizontal line above.</div>
+<div style="font: 100px 'WebFont'; -webkit-writing-mode: vertical-rl; -webkit-text-orientation: upright;">&#x2000b;</div>
 </body>
 </html>
diff --git a/LayoutTests/fast/text/resources/Ahem-multi-code-unit.ttf b/LayoutTests/fast/text/resources/Ahem-multi-code-unit.ttf
new file mode 100644 (file)
index 0000000..b544d40
Binary files /dev/null and b/LayoutTests/fast/text/resources/Ahem-multi-code-unit.ttf differ
index 2f1ea16..cc9a4b8 100644 (file)
@@ -2163,7 +2163,6 @@ fast/filter-image/background-filter-image.html [ ImageOnlyFailure ]
 fast/text/combining-mark-paint.html [ ImageOnlyFailure ]
 fast/text/han-generic-font-families.html [ ImageOnlyFailure ]
 fast/text/mark-matches-broken-line-rendering.html [ ImageOnlyFailure ]
-fast/text/multiple-codeunit-vertical-upright.html [ ImageOnlyFailure ]
 fast/text/synthetic-bold-transformed.html [ ImageOnlyFailure ]
 fast/text/word-break-keep-all.html [ ImageOnlyFailure ]
 
index 8d788eb..f27b9be 100644 (file)
@@ -653,9 +653,6 @@ fast/canvas/webgl/tex-image-and-sub-image-2d-with-potentially-subsampled-image.h
 # <rdar://problem/29031509> REGRESSION? (FontParser-195): svg/W3C-SVG-1.1/fonts-elem-* and svg/W3C-SVG-1.1/text-intro-* tests failing
 svg/W3C-SVG-1.1/fonts-elem-04-b.svg [ Failure ]
 
-# <rdar://problem/31893714> REGRESSION: LayoutTest fast/text/multiple-codeunit-vertical-upright.html is failing on WK1
-fast/text/multiple-codeunit-vertical-upright.html [ Pass ImageOnlyFailure ]
-
 # <rdar://problem/31895192> DumpRenderTree crashed in com.apple.ImageIO.framework: IIODictionary::getBoolForKey + 0
 http/tests/misc/slow-loading-animated-image.html [ Skip ]