Web Inspector: REGRESSION: Resources: WI.TreeOutline assertions when refreshing the...
authormattbaker@apple.com <mattbaker@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 5 Feb 2019 01:08:40 +0000 (01:08 +0000)
committermattbaker@apple.com <mattbaker@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 5 Feb 2019 01:08:40 +0000 (01:08 +0000)
https://bugs.webkit.org/show_bug.cgi?id=194242
<rdar://problem/47802027>

Reviewed by Joseph Pecoraro.

* UserInterface/Views/FolderizedTreeElement.js:
(WI.FolderizedTreeElement.prototype.removeChildren):
FolderTreeElements are removed by the base class call to removeChildren.
Calling `removeChildren` for detached TreeElements is unnecessary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/UserInterface/Views/FolderizedTreeElement.js

index 90a3bf9..3106c5b 100644 (file)
@@ -1,5 +1,18 @@
 2019-02-04  Matt Baker  <mattbaker@apple.com>
 
+        Web Inspector: REGRESSION: Resources: WI.TreeOutline assertions when refreshing the page
+        https://bugs.webkit.org/show_bug.cgi?id=194242
+        <rdar://problem/47802027>
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Views/FolderizedTreeElement.js:
+        (WI.FolderizedTreeElement.prototype.removeChildren):
+        FolderTreeElements are removed by the base class call to removeChildren.
+        Calling `removeChildren` for detached TreeElements is unnecessary.
+
+2019-02-04  Matt Baker  <mattbaker@apple.com>
+
         Web Inspector: REGRESSION: clicking a selected call frame doesn't re-scroll
         https://bugs.webkit.org/show_bug.cgi?id=194169
         <rdar://problem/47743864>
index 1edad0d..c1e546b 100644 (file)
@@ -69,17 +69,12 @@ WI.FolderizedTreeElement = class FolderizedTreeElement extends WI.GeneralTreeEle
         this._folderizeSettingsMap.set(type, settings);
     }
 
-    // Overrides from TreeElement (Private).
-
     removeChildren()
     {
         super.removeChildren();
 
         this._clearNewChildQueue();
 
-        for (var folder of this._folderTypeMap.values())
-            folder.removeChildren();
-
         this._folderExpandedSettingMap.clear();
         this._folderTypeMap.clear();