Addressing post-review comments after r219173.
authormmaxfield@apple.com <mmaxfield@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 10 Aug 2017 16:59:28 +0000 (16:59 +0000)
committermmaxfield@apple.com <mmaxfield@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 10 Aug 2017 16:59:28 +0000 (16:59 +0000)
https://bugs.webkit.org/show_bug.cgi?id=174149

Unreviewed.

* css/CSSFontStyleValue.h:
* editing/EditingStyle.cpp:
(WebCore::identifierForStyleProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/css/CSSFontStyleValue.h
Source/WebCore/editing/EditingStyle.cpp

index 863f033..0009894 100644 (file)
@@ -1,3 +1,14 @@
+2017-08-10  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        Addressing post-review comments after r219173.
+        https://bugs.webkit.org/show_bug.cgi?id=174149
+
+        Unreviewed.
+
+        * css/CSSFontStyleValue.h:
+        * editing/EditingStyle.cpp:
+        (WebCore::identifierForStyleProperty):
+
 2017-08-10  Antti Koivisto  <antti@apple.com>
 
         Try to fix windows build.
index c4a9356..a978968 100644 (file)
@@ -46,7 +46,7 @@ public:
 
     bool equals(const CSSFontStyleValue&) const;
 
-    bool isItalic() const
+    bool isItalicOrOblique() const
     {
         if (!obliqueValue) {
             auto valueID = fontStyleValue->valueID();
index e34aa78..c223d63 100644 (file)
@@ -142,7 +142,7 @@ template<typename T>
 int identifierForStyleProperty(T& style, CSSPropertyID propertyID)
 {
     RefPtr<CSSValue> value = extractPropertyValue(style, propertyID);
-    if (propertyID == CSSPropertyFontStyle && is<CSSFontStyleValue>(value.get()) && downcast<CSSFontStyleValue>(value.get())->isItalic())
+    if (propertyID == CSSPropertyFontStyle && is<CSSFontStyleValue>(value.get()) && downcast<CSSFontStyleValue>(value.get())->isItalicOrOblique())
         return CSSValueItalic;
     if (!is<CSSPrimitiveValue>(value.get()))
         return 0;