[Chromium] Fix calendar-picker-key-operations.html
authortkent@chromium.org <tkent@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 23 Jan 2013 04:21:04 +0000 (04:21 +0000)
committertkent@chromium.org <tkent@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 23 Jan 2013 04:21:04 +0000 (04:21 +0000)
https://bugs.webkit.org/show_bug.cgi?id=101408

Reviewed by Kentaro Hara.

* platform/chromium/TestExpectations:
* platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html:
We need to apply the waitUntilClosing idiom because picker closing
operation is asynchronous.
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations-expected.txt:
Fix a failure.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations-expected.txt
LayoutTests/platform/chromium/TestExpectations
LayoutTests/platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html

index 652eac4..8b40aea 100644 (file)
@@ -1,3 +1,17 @@
+2013-01-22  Kent Tamura  <tkent@chromium.org>
+
+        [Chromium] Fix calendar-picker-key-operations.html
+        https://bugs.webkit.org/show_bug.cgi?id=101408
+
+        Reviewed by Kentaro Hara.
+
+        * platform/chromium/TestExpectations:
+        * platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html:
+        We need to apply the waitUntilClosing idiom because picker closing
+        operation is asynchronous.
+        * platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations-expected.txt:
+        Fix a failure.
+
 2013-01-22  Yoshifumi Inoue  <yosin@chromium.org>
 
         Unreviewed. Remove a wrong entry from platfrom/chromium/TestExpectations
index 779f9c2..5ebfe6b 100644 (file)
@@ -51,7 +51,7 @@ PASS focusedElement() is ".today-button[value=<<CalendarToday>>]"
 PASS focusedElement() is ".clear-button[value=<<CalendarClear>>]"
 PASS focusedElement() is ".year-month-button[value=<<]"
 PASS focusedElement() is ".clear-button[value=<<CalendarClear>>]"
-FAIL document.getElementById("mock-page-popup") should be null. Was [object HTMLIFrameElement].
+PASS document.getElementById("mock-page-popup") is null
 PASS document.getElementById("date").value is "1999-12-26"
 PASS F4 opened picker.
 PASS successfullyParsed is true
index 89527b8..beb3537 100644 (file)
@@ -4100,7 +4100,6 @@ webkit.org/b/100955 http/tests/security/contentSecurityPolicy/object-src-none-bl
 
 webkit.org/b/101377 [ Linux MountainLion ] platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html [ Failure ImageOnlyFailure Pass Crash ]
 
-webkit.org/b/101408 [ Mac ] platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html [ Failure ]
 webkit.org/b/101408 platform/chromium/fast/forms/calendar-picker/calendar-picker-mouse-operations.html [ Failure Pass ]
 
 webkit.org/b/104993 [ XP ] fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html [ Failure ]
index 75a5d83..21e1c01 100644 (file)
@@ -111,6 +111,10 @@ function test2() {
     shouldBe('focusedElement()', '".clear-button[value=<<CalendarClear>>]"');
 
     eventSender.keyDown('\x1B');
+    waitUntilClosing(test2AfterClosing);
+}
+
+function test2AfterClosing() {
     shouldBeNull('document.getElementById("mock-page-popup")');
     shouldBe('document.getElementById("date").value', '"1999-12-26"');