Fix some Mac linker warnings
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 12 Feb 2015 21:18:41 +0000 (21:18 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 12 Feb 2015 21:18:41 +0000 (21:18 +0000)
https://bugs.webkit.org/show_bug.cgi?id=141522

Patch by Daniel Bates <dabates@apple.com> on 2015-02-12
Reviewed by Alex Christensen.

Following <https://trac.webkit.org/changeset/179945>, the linker warns about the following hidden WebCore symbols:

ld: warning: cannot export hidden symbol __ZN7WebCore20LogNotYetImplementedE from /.../OpenSource/WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-normal/x86_64/Logging.o
ld: warning: cannot export hidden symbol _wkCreateURLPasteboardFlavorTypeName from /.../OpenSource/WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-normal/x86_64/WebCoreSystemInterface.o
ld: warning: cannot export hidden symbol _wkCreateURLNPasteboardFlavorTypeName from /.../OpenSource/WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-normal/x86_64/WebCoreSystemInterface.o

* WebCore.exp.in: Remove symbols for functions wkCreateURLPasteboardFlavorTypeName and wkCreateURLNPasteboardFlavorTypeName.
* platform/Logging.h: Export WTFLogChannel for LogNotYetImplemented, which is referenced from
notImplementedLoggingChannel() in file NotImplemented.cpp. We make use of the associated
header, NotImplemented.h, in both WebKit and WebKit2.
* platform/mac/WebCoreSystemInterface.mm: Remove declarations for functions
wkCreateURLPasteboardFlavorTypeName and wkCreateURLNPasteboardFlavorTypeName that
were inadvertently not removed in r25494.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@180007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/WebCore.exp.in
Source/WebCore/platform/Logging.h
Source/WebCore/platform/mac/WebCoreSystemInterface.mm

index b2073a3..b610899 100644 (file)
@@ -1,3 +1,24 @@
+2015-02-12  Daniel Bates  <dabates@apple.com>
+
+        Fix some Mac linker warnings
+        https://bugs.webkit.org/show_bug.cgi?id=141522
+
+        Reviewed by Alex Christensen.
+
+        Following <https://trac.webkit.org/changeset/179945>, the linker warns about the following hidden WebCore symbols:
+        
+        ld: warning: cannot export hidden symbol __ZN7WebCore20LogNotYetImplementedE from /.../OpenSource/WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-normal/x86_64/Logging.o
+        ld: warning: cannot export hidden symbol _wkCreateURLPasteboardFlavorTypeName from /.../OpenSource/WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-normal/x86_64/WebCoreSystemInterface.o
+        ld: warning: cannot export hidden symbol _wkCreateURLNPasteboardFlavorTypeName from /.../OpenSource/WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-normal/x86_64/WebCoreSystemInterface.o
+
+        * WebCore.exp.in: Remove symbols for functions wkCreateURLPasteboardFlavorTypeName and wkCreateURLNPasteboardFlavorTypeName.
+        * platform/Logging.h: Export WTFLogChannel for LogNotYetImplemented, which is referenced from
+        notImplementedLoggingChannel() in file NotImplemented.cpp. We make use of the associated
+        header, NotImplemented.h, in both WebKit and WebKit2.
+        * platform/mac/WebCoreSystemInterface.mm: Remove declarations for functions
+        wkCreateURLPasteboardFlavorTypeName and wkCreateURLNPasteboardFlavorTypeName that
+        were inadvertently not removed in r25494.
+
 2015-02-12  Joseph Pecoraro  <pecoraro@apple.com>
 
         Web Inspector: Crash inspecting styles of element with mutated stylesheet
index e30d5f2..37dfb33 100644 (file)
@@ -2513,8 +2513,6 @@ _wkCreateAXUIElementRef
 _wkCreateMediaUIBackgroundView
 _wkCreateMediaUIControl
 _wkCreateMemoryStatusPressureCriticalDispatchOnMainQueue
-_wkCreateURLNPasteboardFlavorTypeName
-_wkCreateURLPasteboardFlavorTypeName
 _wkCreateVMPressureDispatchOnMainQueue
 _wkCursor
 _wkDrawBezeledTextArea
index e235422..fb2454d 100644 (file)
@@ -82,6 +82,8 @@ WEBCORE_LOG_CHANNELS(DECLARE_LOG_CHANNEL)
 
 #undef DECLARE_LOG_CHANNEL
 
+    WEBCORE_EXPORT extern WTFLogChannel LogNotYetImplemented;
+
     String logLevelString();
     bool isLogChannelEnabled(const String& name);
     WEBCORE_EXPORT void initializeLoggingChannelsIfNecessary();
index 39f93b7..bdb990d 100644 (file)
@@ -39,8 +39,6 @@ CGPatternRef (*wkCGPatternCreateWithImageAndTransform)(CGImageRef, CGAffineTrans
 NSString* (*wkCopyNSURLResponseStatusLine)(NSURLResponse*);
 CFArrayRef (*wkCopyNSURLResponseCertificateChain)(NSURLResponse*);
 CFStringEncoding (*wkGetWebDefaultCFStringEncoding)(void);
-NSString* (*wkCreateURLPasteboardFlavorTypeName)(void);
-NSString* (*wkCreateURLNPasteboardFlavorTypeName)(void);
 void (*wkDrawCapsLockIndicator)(CGContextRef, CGRect);
 void (*wkDrawBezeledTextArea)(NSRect, BOOL enabled);
 void (*wkDrawFocusRing)(CGContextRef, CGColorRef, int);