Reenable Update ContentFiltering.LazilyLoadPlatformFrameworks test for NetworkExtension
authoryouenn@apple.com <youenn@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 14 Aug 2019 17:10:08 +0000 (17:10 +0000)
committeryouenn@apple.com <youenn@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 14 Aug 2019 17:10:08 +0000 (17:10 +0000)
https://bugs.webkit.org/show_bug.cgi?id=200706

Reviewed by Alex Christensen.

Libwebrtc is now soft-linked so we can reenable this test.

* TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm:
(-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm

index 17cda1a..7cf7558 100644 (file)
@@ -1,3 +1,15 @@
+2019-08-14  Youenn Fablet  <youenn@apple.com>
+
+        Reenable Update ContentFiltering.LazilyLoadPlatformFrameworks test for NetworkExtension
+        https://bugs.webkit.org/show_bug.cgi?id=200706
+
+        Reviewed by Alex Christensen.
+
+        Libwebrtc is now soft-linked so we can reenable this test.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm:
+        (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
+
 2019-08-13  Sam Weinig  <weinig@apple.com>
 
         Rename StringBuilder::append(UChar32) to StringBuilder::appendCharacter(UChar32) to avoid accidental change in behavior when replacing append with flexibleAppend
index 3e32461..e985c70 100644 (file)
@@ -361,12 +361,7 @@ TEST(ContentFiltering, LoadAlternateAfterFinishedAddingDataWK2)
         EXPECT_EQ(static_cast<bool>(parentalControlsShouldBeLoaded), static_cast<bool>(parentalControlsLoaded));
 #endif
 #if HAVE(NETWORK_EXTENSION)
-        // FIXME: Libwebrtc is linking on some configurations to VideoProcessing framework which brings up NetworkExtension framework.
-        // Disable this test until we find a more robust test or libwebrtc weak link VideoProcessing framework.
-        // https://bugs.webkit.org/show_bug.cgi?id=180713
-#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MAX_ALLOWED < 101300
         EXPECT_EQ(static_cast<bool>(networkExtensionShouldBeLoaded), static_cast<bool>(networkExtensionLoaded));
-#endif
 #endif // HAVE(NETWORK_EXTENSION)
         isDone = true;
     }];