[GTK] Wrong variable used in RenderThemeGtk

https://bugs.webkit.org/show_bug.cgi?id=186756

Patch by Tomas Popela <tpopela@redhat.com> on 2018-06-18
Reviewed by Carlos Garcia Campos.

Use SliderThumbHorizontalPart instead of SliderHorizontalPart.

* rendering/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::adjustSliderThumbSize const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@232928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
index f84388b..f992f6e 100644 (file)
--- a/Source/WebCore/ChangeLog
+++ b/Source/WebCore/ChangeLog
@@ -1,3 +1,15 @@
+2018-06-18  Tomas Popela  <tpopela@redhat.com>
+
+        [GTK] Wrong variable used in RenderThemeGtk
+        https://bugs.webkit.org/show_bug.cgi?id=186756
+
+        Reviewed by Carlos Garcia Campos.
+
+        Use SliderThumbHorizontalPart instead of SliderHorizontalPart.
+
+        * rendering/RenderThemeGtk.cpp:
+        (WebCore::RenderThemeGtk::adjustSliderThumbSize const):
+

 2018-06-18  Philippe Normand  <pnormand@igalia.com>
 
         [GStreamer] Crash when adding in-band text track with playbin3 enabled
 2018-06-18  Philippe Normand  <pnormand@igalia.com>
 
         [GStreamer] Crash when adding in-band text track with playbin3 enabled

diff --git a/Source/WebCore/rendering/RenderThemeGtk.cpp b/Source/WebCore/rendering/RenderThemeGtk.cpp
index d04a684..8e8fe10 100644 (file)
--- a/Source/WebCore/rendering/RenderThemeGtk.cpp
+++ b/Source/WebCore/rendering/RenderThemeGtk.cpp
@@ -1314,7 +1314,7 @@ void RenderThemeGtk::adjustSliderThumbSize(RenderStyle& style, const Element*) c
     if (part != SliderThumbHorizontalPart && part != SliderThumbVerticalPart)
         return;
 
     if (part != SliderThumbHorizontalPart && part != SliderThumbVerticalPart)
         return;
 

-    auto& sliderWidget = static_cast<RenderThemeSlider&>(RenderThemeWidget::getOrCreate(part == SliderHorizontalPart ? RenderThemeWidget::Type::HorizontalSlider : RenderThemeWidget::Type::VerticalSlider));
+    auto& sliderWidget = static_cast<RenderThemeSlider&>(RenderThemeWidget::getOrCreate(part == SliderThumbHorizontalPart ? RenderThemeWidget::Type::HorizontalSlider : RenderThemeWidget::Type::VerticalSlider));

     sliderWidget.scale().setState(GTK_STATE_FLAG_NORMAL);
     sliderWidget.trough().setState(GTK_STATE_FLAG_NORMAL);
 
     sliderWidget.scale().setState(GTK_STATE_FLAG_NORMAL);
     sliderWidget.trough().setState(GTK_STATE_FLAG_NORMAL);