<https://webkit.org/b/119950> Remove unused EditorClient::frameWillDetachPage() callback.
authorakling@apple.com <akling@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 17 Aug 2013 16:58:14 +0000 (16:58 +0000)
committerakling@apple.com <akling@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 17 Aug 2013 16:58:14 +0000 (16:58 +0000)
Reviewed by Antti Koivisto.

This callback was only used by the Chromium port.

* editing/Editor.h:
* editing/Editor.cpp:

    Remove override of FrameDestructionObserver::willDetachPage().

* page/EditorClient.h:

    Remove frameWillDetachPage(). This is repeated in every EditorClient subclass.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@154235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 files changed:
Source/WebCore/ChangeLog
Source/WebCore/editing/Editor.cpp
Source/WebCore/editing/Editor.h
Source/WebCore/loader/EmptyClients.h
Source/WebCore/page/EditorClient.h
Source/WebKit/blackberry/WebCoreSupport/EditorClientBlackBerry.h
Source/WebKit/efl/WebCoreSupport/EditorClientEfl.h
Source/WebKit/gtk/WebCoreSupport/EditorClientGtk.h
Source/WebKit/mac/WebCoreSupport/WebEditorClient.h
Source/WebKit/qt/WebCoreSupport/EditorClientQt.h
Source/WebKit/win/WebCoreSupport/WebEditorClient.h
Source/WebKit/wince/WebCoreSupport/EditorClientWinCE.h
Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.h

index 8fbfced..d97cbc7 100644 (file)
@@ -1,3 +1,20 @@
+2013-08-17  Andreas Kling  <akling@apple.com>
+
+        <https://webkit.org/b/119950> Remove unused EditorClient::frameWillDetachPage() callback.
+
+        Reviewed by Antti Koivisto.
+
+        This callback was only used by the Chromium port.
+
+        * editing/Editor.h:
+        * editing/Editor.cpp:
+
+            Remove override of FrameDestructionObserver::willDetachPage().
+
+        * page/EditorClient.h:
+
+            Remove frameWillDetachPage(). This is repeated in every EditorClient subclass.
+
 2013-08-16  Antti Koivisto  <antti@apple.com>
 
         <https://webkit.org/b/119886> PseudoElement is abusing parent node pointer
index f3bf644..2657fbe 100644 (file)
@@ -3108,12 +3108,6 @@ bool Editor::unifiedTextCheckerEnabled() const
     return WebCore::unifiedTextCheckerEnabled(m_frame);
 }
 
-void Editor::willDetachPage()
-{
-    if (EditorClient* editorClient = client())
-        editorClient->frameWillDetachPage(frame());
-}
-
 Vector<String> Editor::dictationAlternativesForMarker(const DocumentMarker* marker)
 {
     return m_alternativeTextController->dictationAlternativesForMarker(marker);
index ecd5463..2600795 100644 (file)
@@ -415,8 +415,6 @@ public:
     Vector<String> dictationAlternativesForMarker(const DocumentMarker*);
     void applyDictationAlternativelternative(const String& alternativeString);
 private:
-    virtual void willDetachPage() OVERRIDE;
-
 #if ENABLE(DELETION_UI)
     OwnPtr<DeleteButtonController> m_deleteButtonController;
 #endif
index 17427d3..80af90b 100644 (file)
@@ -397,7 +397,6 @@ public:
     EmptyEditorClient() { }
     virtual ~EmptyEditorClient() { }
     virtual void pageDestroyed() { }
-    virtual void frameWillDetachPage(Frame*) { }
 
     virtual bool shouldDeleteRange(Range*) { return false; }
     virtual bool smartInsertDeleteEnabled() { return false; }
index c8bb3e4..d19818b 100644 (file)
@@ -65,7 +65,6 @@ class EditorClient {
 public:
     virtual ~EditorClient() {  }
     virtual void pageDestroyed() = 0;
-    virtual void frameWillDetachPage(Frame*) = 0;
 
     virtual bool shouldDeleteRange(Range*) = 0;
     virtual bool smartInsertDeleteEnabled() = 0; 
index 9819153..09c79f1 100644 (file)
@@ -37,7 +37,6 @@ class EditorClientBlackBerry : public EditorClient, public TextCheckerClient {
 public:
     EditorClientBlackBerry(BlackBerry::WebKit::WebPagePrivate*);
     virtual void pageDestroyed();
-    virtual void frameWillDetachPage(Frame*) { }
     virtual bool shouldDeleteRange(Range*);
     virtual bool smartInsertDeleteEnabled();
     virtual bool isSelectTrailingWhitespaceEnabled();
index d0d5d30..7bd3ab0 100644 (file)
@@ -80,7 +80,6 @@ public:
 
     // from EditorClient
     virtual void pageDestroyed();
-    virtual void frameWillDetachPage(Frame*) { }
 
     virtual bool shouldDeleteRange(Range*);
     virtual bool smartInsertDeleteEnabled();
index c99f71e..68f12e5 100644 (file)
@@ -71,7 +71,6 @@ class EditorClient : public WebCore::EditorClient {
 
         // from EditorClient
         virtual void pageDestroyed();
-        virtual void frameWillDetachPage(WebCore::Frame*) { }
 
         virtual bool shouldDeleteRange(WebCore::Range*);
         virtual bool smartInsertDeleteEnabled();
index 9864f13..e03383d 100644 (file)
@@ -41,7 +41,6 @@ public:
     WebEditorClient(WebView *);
     virtual ~WebEditorClient();
     virtual void pageDestroyed() OVERRIDE;
-    virtual void frameWillDetachPage(WebCore::Frame*) OVERRIDE { }
 
     virtual bool isGrammarCheckingEnabled() OVERRIDE;
     virtual void toggleGrammarChecking() OVERRIDE;
index 782cde3..e38a647 100644 (file)
@@ -45,7 +45,6 @@ public:
     EditorClientQt(QWebPageAdapter*);
     
     virtual void pageDestroyed();
-    virtual void frameWillDetachPage(Frame*) { }
     
     virtual bool shouldDeleteRange(Range*);
     virtual bool smartInsertDeleteEnabled(); 
index 27f2677..8bc1fde 100644 (file)
@@ -41,7 +41,6 @@ public:
     ~WebEditorClient();
 
     virtual void pageDestroyed();
-    virtual void frameWillDetachPage(WebCore::Frame*) { }
 
     virtual bool isContinuousSpellCheckingEnabled();
     virtual void toggleGrammarChecking();
index 974aef2..9cacaf5 100644 (file)
@@ -38,7 +38,6 @@ public:
     ~EditorClientWinCE();
 
     virtual void pageDestroyed();
-    virtual void frameWillDetachPage(WebCore::Frame*) { }
 
     virtual bool shouldDeleteRange(WebCore::Range*);
     virtual bool smartInsertDeleteEnabled();
index 99bd8bd..494280c 100644 (file)
@@ -42,7 +42,6 @@ public:
 
 private:
     virtual void pageDestroyed() OVERRIDE;
-    virtual void frameWillDetachPage(WebCore::Frame*) OVERRIDE { }
 
     virtual bool shouldDeleteRange(WebCore::Range*) OVERRIDE;
     virtual bool smartInsertDeleteEnabled() OVERRIDE;