Fix the binding generator after r190785
authorossy@webkit.org <ossy@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 9 Oct 2015 17:04:41 +0000 (17:04 +0000)
committerossy@webkit.org <ossy@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 9 Oct 2015 17:04:41 +0000 (17:04 +0000)
https://bugs.webkit.org/show_bug.cgi?id=149956

Reviewed by Darin Adler.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorHelperMethods):
* bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::getConstructData):
* bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::JSTestEventConstructorConstructor::getConstructData):
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::getConstructData):
* bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:
(WebCore::JSTestJSBuiltinConstructorConstructor::getConstructData):
* bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorNamedConstructor::getConstructData):
* bindings/scripts/test/JS/JSTestNode.cpp:
(WebCore::JSTestNodeConstructor::getConstructData):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjConstructor::getConstructData):
* bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::JSTestOverloadedConstructorsConstructor::getConstructData):
* bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::JSTestTypedefsConstructor::getConstructData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
Source/WebCore/bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp
Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp
Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp
Source/WebCore/bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp
Source/WebCore/bindings/scripts/test/JS/JSTestNamedConstructor.cpp
Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp
Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp
Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp
Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp

index 9856707..2dd0394 100644 (file)
@@ -1,3 +1,31 @@
+2015-10-09  Csaba Osztrogon√°c  <ossy@webkit.org>
+
+        Fix the binding generator after r190785
+        https://bugs.webkit.org/show_bug.cgi?id=149956
+
+        Reviewed by Darin Adler.
+
+        * bindings/scripts/CodeGeneratorJS.pm:
+        (GenerateConstructorHelperMethods):
+        * bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
+        (WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::getConstructData):
+        * bindings/scripts/test/JS/JSTestEventConstructor.cpp:
+        (WebCore::JSTestEventConstructorConstructor::getConstructData):
+        * bindings/scripts/test/JS/JSTestInterface.cpp:
+        (WebCore::JSTestInterfaceConstructor::getConstructData):
+        * bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:
+        (WebCore::JSTestJSBuiltinConstructorConstructor::getConstructData):
+        * bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
+        (WebCore::JSTestNamedConstructorNamedConstructor::getConstructData):
+        * bindings/scripts/test/JS/JSTestNode.cpp:
+        (WebCore::JSTestNodeConstructor::getConstructData):
+        * bindings/scripts/test/JS/JSTestObj.cpp:
+        (WebCore::JSTestObjConstructor::getConstructData):
+        * bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
+        (WebCore::JSTestOverloadedConstructorsConstructor::getConstructData):
+        * bindings/scripts/test/JS/JSTestTypedefs.cpp:
+        (WebCore::JSTestTypedefsConstructor::getConstructData):
+
 2015-10-08  Wenson Hsieh  <wenson_hsieh@apple.com>
 
         Backgrounds bleed out of natively rendered text fields
index 5f0b151..4dd87dc 100644 (file)
@@ -5009,16 +5009,18 @@ sub GenerateConstructorHelperMethods
     if (IsConstructable($interface)) {
         if (!$interface->extendedAttributes->{"NamedConstructor"} || $generatingNamedConstructor) {
             my $conditionalString = $codeGenerator->GenerateConstructorConditionalString($interface);
-            push(@$outputArray, "ConstructType ${constructorClassName}::getConstructData(JSCell*, ConstructData& constructData)\n");
+            push(@$outputArray, "ConstructType ${constructorClassName}::getConstructData(JSCell* cell, ConstructData& constructData)\n");
             push(@$outputArray, "{\n");
             if ($conditionalString) {
                 push(@$outputArray, "#if $conditionalString\n");
+                push(@$outputArray, "    UNUSED_PARAM(cell);\n");
                 push(@$outputArray, "    constructData.native.function = construct;\n");
                 push(@$outputArray, "    return ConstructTypeHost;\n");
                 push(@$outputArray, "#else\n");
                 push(@$outputArray, "    return Base::getConstructData(cell, constructData);\n");
                 push(@$outputArray, "#endif\n");
             } else {
+                push(@$outputArray, "    UNUSED_PARAM(cell);\n");
                 push(@$outputArray, "    constructData.native.function = construct;\n");
                 push(@$outputArray, "    return ConstructTypeHost;\n");
             }
index c267023..58519b6 100644 (file)
@@ -102,8 +102,9 @@ void JSTestCustomConstructorWithNoInterfaceObjectConstructor::finishCreation(VM&
     putDirect(vm, vm.propertyNames->length, jsNumber(0), ReadOnly | DontEnum);
 }
 
-ConstructType JSTestCustomConstructorWithNoInterfaceObjectConstructor::getConstructData(JSCell*, ConstructData& constructData)
+ConstructType JSTestCustomConstructorWithNoInterfaceObjectConstructor::getConstructData(JSCell* cell, ConstructData& constructData)
 {
+    UNUSED_PARAM(cell);
     constructData.native.function = construct;
     return ConstructTypeHost;
 }
index ac8eeed..b52fafd 100644 (file)
@@ -144,8 +144,9 @@ void JSTestEventConstructorConstructor::finishCreation(VM& vm, JSDOMGlobalObject
     putDirect(vm, vm.propertyNames->length, jsNumber(1), ReadOnly | DontEnum);
 }
 
-ConstructType JSTestEventConstructorConstructor::getConstructData(JSCell*, ConstructData& constructData)
+ConstructType JSTestEventConstructorConstructor::getConstructData(JSCell* cell, ConstructData& constructData)
 {
+    UNUSED_PARAM(cell);
     constructData.native.function = construct;
     return ConstructTypeHost;
 }
index 1a0eb15..c1fd549 100644 (file)
@@ -302,9 +302,10 @@ void JSTestInterfaceConstructor::finishCreation(VM& vm, JSDOMGlobalObject& globa
     reifyStaticProperties(vm, JSTestInterfaceConstructorTableValues, *this);
 }
 
-ConstructType JSTestInterfaceConstructor::getConstructData(JSCell*, ConstructData& constructData)
+ConstructType JSTestInterfaceConstructor::getConstructData(JSCell* cell, ConstructData& constructData)
 {
 #if ENABLE(TEST_INTERFACE)
+    UNUSED_PARAM(cell);
     constructData.native.function = construct;
     return ConstructTypeHost;
 #else
index aaf68d7..be3e9c6 100644 (file)
@@ -105,8 +105,9 @@ void JSTestJSBuiltinConstructorConstructor::finishCreation(VM& vm, JSDOMGlobalOb
     setInitializeFunction(vm, *JSC::JSFunction::createBuiltinFunction(vm, testJSBuiltinConstructorInitializeTestJSBuiltinConstructorCodeGenerator(vm), &globalObject));
 }
 
-ConstructType JSTestJSBuiltinConstructorConstructor::getConstructData(JSCell*, ConstructData& constructData)
+ConstructType JSTestJSBuiltinConstructorConstructor::getConstructData(JSCell* cell, ConstructData& constructData)
 {
+    UNUSED_PARAM(cell);
     constructData.native.function = construct;
     return ConstructTypeHost;
 }
index 92eb131..82ab027 100644 (file)
@@ -161,8 +161,9 @@ void JSTestNamedConstructorNamedConstructor::finishCreation(VM& vm, JSDOMGlobalO
     putDirect(vm, vm.propertyNames->length, jsNumber(0), ReadOnly | DontEnum);
 }
 
-ConstructType JSTestNamedConstructorNamedConstructor::getConstructData(JSCell*, ConstructData& constructData)
+ConstructType JSTestNamedConstructorNamedConstructor::getConstructData(JSCell* cell, ConstructData& constructData)
 {
+    UNUSED_PARAM(cell);
     constructData.native.function = construct;
     return ConstructTypeHost;
 }
index ff7bc4d..f37cf08 100644 (file)
@@ -110,8 +110,9 @@ void JSTestNodeConstructor::finishCreation(VM& vm, JSDOMGlobalObject& globalObje
     putDirect(vm, vm.propertyNames->length, jsNumber(0), ReadOnly | DontEnum);
 }
 
-ConstructType JSTestNodeConstructor::getConstructData(JSCell*, ConstructData& constructData)
+ConstructType JSTestNodeConstructor::getConstructData(JSCell* cell, ConstructData& constructData)
 {
+    UNUSED_PARAM(cell);
     constructData.native.function = construct;
     return ConstructTypeHost;
 }
index be20378..3a0882c 100644 (file)
@@ -500,8 +500,9 @@ void JSTestObjConstructor::finishCreation(VM& vm, JSDOMGlobalObject& globalObjec
     reifyStaticProperties(vm, JSTestObjConstructorTableValues, *this);
 }
 
-ConstructType JSTestObjConstructor::getConstructData(JSCell*, ConstructData& constructData)
+ConstructType JSTestObjConstructor::getConstructData(JSCell* cell, ConstructData& constructData)
 {
+    UNUSED_PARAM(cell);
     constructData.native.function = construct;
     return ConstructTypeHost;
 }
index 167e475..05ca334 100644 (file)
@@ -177,8 +177,9 @@ void JSTestOverloadedConstructorsConstructor::finishCreation(VM& vm, JSDOMGlobal
     putDirect(vm, vm.propertyNames->length, jsNumber(0), ReadOnly | DontEnum);
 }
 
-ConstructType JSTestOverloadedConstructorsConstructor::getConstructData(JSCell*, ConstructData& constructData)
+ConstructType JSTestOverloadedConstructorsConstructor::getConstructData(JSCell* cell, ConstructData& constructData)
 {
+    UNUSED_PARAM(cell);
     constructData.native.function = construct;
     return ConstructTypeHost;
 }
index bcb99d9..9c8654a 100644 (file)
@@ -174,8 +174,9 @@ void JSTestTypedefsConstructor::finishCreation(VM& vm, JSDOMGlobalObject& global
     reifyStaticProperties(vm, JSTestTypedefsConstructorTableValues, *this);
 }
 
-ConstructType JSTestTypedefsConstructor::getConstructData(JSCell*, ConstructData& constructData)
+ConstructType JSTestTypedefsConstructor::getConstructData(JSCell* cell, ConstructData& constructData)
 {
+    UNUSED_PARAM(cell);
     constructData.native.function = construct;
     return ConstructTypeHost;
 }