Mark WebChromeClient::requestStorageAccess() as final

https://bugs.webkit.org/show_bug.cgi?id=179673

Reviewed by Sam Weinig.

Mark WebChromeClient::requestStorageAccess() as final so that it overrides the virtual function
in ChromeClient with the same name and hence we actually call it through a ChromeClient pointer.

* WebProcess/WebCoreSupport/WebChromeClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
index 9354d1e..3f2ab51 100644 (file)
--- a/Source/WebKit/ChangeLog
+++ b/Source/WebKit/ChangeLog
@@ -1,3 +1,15 @@
+2017-11-14  Daniel Bates  <dabates@apple.com>
+
+        Mark WebChromeClient::requestStorageAccess() as final
+        https://bugs.webkit.org/show_bug.cgi?id=179673
+
+        Reviewed by Sam Weinig.
+
+        Mark WebChromeClient::requestStorageAccess() as final so that it overrides the virtual function
+        in ChromeClient with the same name and hence we actually call it through a ChromeClient pointer.
+
+        * WebProcess/WebCoreSupport/WebChromeClient.h:
+
 2017-11-14  Youenn Fablet  <youenn@apple.com>
 
         WebSWClientConnection should do IPC to StorageProcess if its WebSWOriginTable is not yet initialized

diff --git a/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h b/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h
index 691aed7..b498830 100644 (file)
--- a/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h
+++ b/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h
@@ -342,7 +342,7 @@ private:
 
     void didInvalidateDocumentMarkerRects() final;
 
-    void requestStorageAccess(String&& subFrameHost, String&& topFrameHost, WTF::Function<void (bool)>&&);
+    void requestStorageAccess(String&& subFrameHost, String&& topFrameHost, WTF::Function<void (bool)>&&) final;
 
     String m_cachedToolTip;
     mutable RefPtr<WebFrame> m_cachedFrameSetLargestFrame;