Don't force everything to be blinded in debug builds
authoroliver@apple.com <oliver@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 20 Feb 2013 00:42:22 +0000 (00:42 +0000)
committeroliver@apple.com <oliver@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 20 Feb 2013 00:42:22 +0000 (00:42 +0000)
https://bugs.webkit.org/show_bug.cgi?id=110279

Reviewed by Mark Hahnenberg.

Switch to an explicit flag for indicating that we want
every constant to be blinded.

* assembler/MacroAssembler.h:
(JSC::MacroAssembler::shouldBlind):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/JavaScriptCore/ChangeLog
Source/JavaScriptCore/assembler/MacroAssembler.h

index 7c041d9..726238e 100644 (file)
@@ -1,3 +1,16 @@
+2013-02-19  Oliver Hunt  <oliver@apple.com>
+
+        Don't force everything to be blinded in debug builds
+        https://bugs.webkit.org/show_bug.cgi?id=110279
+
+        Reviewed by Mark Hahnenberg.
+
+        Switch to an explicit flag for indicating that we want
+        every constant to be blinded.
+
+        * assembler/MacroAssembler.h:
+        (JSC::MacroAssembler::shouldBlind):
+
 2013-02-19  Filip Pizlo  <fpizlo@apple.com>
 
         Fix indentation of Opcode.h
 2013-02-19  Filip Pizlo  <fpizlo@apple.com>
 
         Fix indentation of Opcode.h
index 1f0c3de..f74680d 100644 (file)
@@ -876,7 +876,7 @@ public:
     
     bool shouldBlind(ImmPtr imm)
     { 
     
     bool shouldBlind(ImmPtr imm)
     { 
-#if !defined(NDEBUG)
+#if ENABLE(FORCED_JIT_BLINDING)
         UNUSED_PARAM(imm);
         // Debug always blind all constants, if only so we know
         // if we've broken blinding during patch development.
         UNUSED_PARAM(imm);
         // Debug always blind all constants, if only so we know
         // if we've broken blinding during patch development.
@@ -934,8 +934,8 @@ public:
     }
 
     bool shouldBlind(Imm64 imm)
     }
 
     bool shouldBlind(Imm64 imm)
-    { 
-#if !defined(NDEBUG)
+    {
+#if ENABLE(FORCED_JIT_BLINDING)
         UNUSED_PARAM(imm);
         // Debug always blind all constants, if only so we know
         // if we've broken blinding during patch development.
         UNUSED_PARAM(imm);
         // Debug always blind all constants, if only so we know
         // if we've broken blinding during patch development.
@@ -1073,8 +1073,8 @@ public:
 
 #if ENABLE(JIT_CONSTANT_BLINDING)
     bool shouldBlind(Imm32 imm)
 
 #if ENABLE(JIT_CONSTANT_BLINDING)
     bool shouldBlind(Imm32 imm)
-    { 
-#if !defined(NDEBUG)
+    {
+#if ENABLE(FORCED_JIT_BLINDING)
         UNUSED_PARAM(imm);
         // Debug always blind all constants, if only so we know
         // if we've broken blinding during patch development.
         UNUSED_PARAM(imm);
         // Debug always blind all constants, if only so we know
         // if we've broken blinding during patch development.