RenderScrollbarPart doesn't need styleWillChange().
authorakling@apple.com <akling@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 21 Oct 2013 20:10:36 +0000 (20:10 +0000)
committerakling@apple.com <akling@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 21 Oct 2013 20:10:36 +0000 (20:10 +0000)
<https://webkit.org/b/123113>

We will call setInline(false) in styleDidChange(), there's no need
to override styleWillChange() just to do it twice.

Reviewed by Darin Adler.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@157726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/rendering/RenderScrollbarPart.cpp
Source/WebCore/rendering/RenderScrollbarPart.h

index 6fb1883..3ecd0b2 100644 (file)
@@ -1,3 +1,13 @@
+2013-10-21  Andreas Kling  <akling@apple.com>
+
+        RenderScrollbarPart doesn't need styleWillChange().
+        <https://webkit.org/b/123113>
+
+        We will call setInline(false) in styleDidChange(), there's no need
+        to override styleWillChange() just to do it twice.
+
+        Reviewed by Darin Adler.
+
 2013-10-21  Mihai Maerean  <mmaerean@adobe.com>
 
         [CSS Regions] The layers from the flow thread should be collected under the regions' layers.
index 5c5adf3..7fb01e5 100644 (file)
@@ -134,12 +134,6 @@ void RenderScrollbarPart::computePreferredLogicalWidths()
     setPreferredLogicalWidthsDirty(false);
 }
 
-void RenderScrollbarPart::styleWillChange(StyleDifference diff, const RenderStyle* newStyle)
-{
-    RenderBlock::styleWillChange(diff, newStyle);
-    setInline(false);
-}
-
 void RenderScrollbarPart::styleDidChange(StyleDifference diff, const RenderStyle* oldStyle)
 {
     RenderBlock::styleDidChange(diff, oldStyle);
index 291c3a5..d01ebf4 100644 (file)
@@ -57,7 +57,6 @@ public:
     RenderBox* rendererOwningScrollbar() const;
 
 protected:
-    virtual void styleWillChange(StyleDifference diff, const RenderStyle* newStyle);
     virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle);
     virtual void imageChanged(WrappedImagePtr, const IntRect* = 0);