Unreviewed, fix test failure after r200971
authordrousso@apple.com <drousso@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 26 Aug 2019 23:01:47 +0000 (23:01 +0000)
committerdrousso@apple.com <drousso@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 26 Aug 2019 23:01:47 +0000 (23:01 +0000)
* inspector/timeline/line-column-expected.txt:

* inspector/debugger/tail-deleted-frames-this-value.html:
Add messages to all `InspectorTest.assert` so we can know which one is firing on the bots.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/inspector/debugger/tail-deleted-frames-this-value.html
LayoutTests/inspector/timeline/line-column-expected.txt

index 561c428..25d641f 100644 (file)
@@ -1,3 +1,12 @@
+2019-08-26  Devin Rousso  <drousso@apple.com>
+
+        Unreviewed, fix test failure after r200971
+
+        * inspector/timeline/line-column-expected.txt:
+
+        * inspector/debugger/tail-deleted-frames-this-value.html:
+        Add messages to all `InspectorTest.assert` so we can know which one is firing on the bots.
+
 2019-08-26  Wenson Hsieh  <wenson_hsieh@apple.com>
 
         Unreviewed, unmark two datalist tests as timing out on iOS 13 after r249112
index 75a8763..0bf27cb 100644 (file)
@@ -42,7 +42,7 @@ function test()
         let targetData = WI.debuggerManager.dataForTarget(WI.debuggerManager.activeCallFrame.target);
         let callFrames = targetData.callFrames;
 
-        InspectorTest.assert(callFrames.length >= expectedFrames.length);
+        InspectorTest.assert(callFrames.length >= expectedFrames.length, `Should have ${expectedFrames.length} frames.`);
 
         // Resolve a thisObject preview on each of the CallFrames.
         let promises = [];
@@ -60,12 +60,12 @@ function test()
                 let callFrame = callFrames[i];
                 let expectedFrame = expectedFrames[i];
                 InspectorTest.log("Expected frame: " + JSON.stringify(expectedFrame));
-                InspectorTest.assert(callFrame.functionName === expectedFrame.functionName);
-                InspectorTest.assert(callFrame.isTailDeleted === expectedFrame.isTailDeleted);
+                InspectorTest.assert(callFrame.functionName === expectedFrame.functionName, `Should have functionName of '${expectedFrame.functionName}'.`);
+                InspectorTest.assert(callFrame.isTailDeleted === expectedFrame.isTailDeleted, `Should have isTailDeleted of '${expectedFrame.isTailDeleted}.`);
 
                 let thisObject = callFrame.thisObject;
                 let properties = thisObject.preview.propertyPreviews;
-                InspectorTest.assert(properties.length === 1);
+                InspectorTest.assert(properties.length === 1, "Should hvae one property.");
                 let prop = properties[0];
                 InspectorTest.expectThat(expectedFrame.thisValue[0] === prop.name, `'this' value should have expected property: ${expectedFrame.thisValue[0]}`);
                 InspectorTest.assert('' + expectedFrame.thisValue[1] === prop.value, `'this' value object should have expected property value: ${expectedFrame.thisValue[1]}`);
index 0388681..465e34a 100644 (file)
@@ -45,7 +45,7 @@ PASS: Capturing started.
           "functionName": "",
           "url": "",
           "scriptId": "<filtered>",
-          "lineNumber": 141,
+          "lineNumber": 144,
           "columnNumber": 97
         }
       ],
@@ -107,7 +107,7 @@ PASS: Capturing started.
               "functionName": "",
               "url": "",
               "scriptId": "<filtered>",
-              "lineNumber": 141,
+              "lineNumber": 144,
               "columnNumber": 97
             }
           ],
@@ -160,7 +160,7 @@ PASS: Capturing started.
           "functionName": "",
           "url": "",
           "scriptId": "<filtered>",
-          "lineNumber": 141,
+          "lineNumber": 144,
           "columnNumber": 97
         }
       ],
@@ -220,7 +220,7 @@ PASS: Capturing started.
           "functionName": "",
           "url": "",
           "scriptId": "<filtered>",
-          "lineNumber": 141,
+          "lineNumber": 144,
           "columnNumber": 97
         }
       ],