Reviewed by Darin Adler.
authorweinig@apple.com <weinig@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 13 Mar 2008 07:11:26 +0000 (07:11 +0000)
committerweinig@apple.com <weinig@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 13 Mar 2008 07:11:26 +0000 (07:11 +0000)
        Fix <rdar://problem/5784773>
        Crash loading QT movies @ apple.com/ipodtouch/features.html with a PAC file (WebKitThreadingException)

        Make bridged RuntimeObjects get collected on the main thread only. This is necessary
        because clients of the bridged objects are unlikely to prepared for a collection on
        non-main thread, which can happen with a PAC file.

        * bridge/runtime_object.cpp:
        (RuntimeObjectImp::RuntimeObjectImp):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog
WebCore/bridge/runtime_object.cpp

index 389e936..a8b8999 100644 (file)
@@ -1,3 +1,17 @@
+2008-03-12  Sam Weinig  <sam@webkit.org>
+
+        Reviewed by Darin Adler.
+
+        Fix <rdar://problem/5784773>
+        Crash loading QT movies @ apple.com/ipodtouch/features.html with a PAC file (WebKitThreadingException)
+
+        Make bridged RuntimeObjects get collected on the main thread only. This is necessary
+        because clients of the bridged objects are unlikely to prepared for a collection on 
+        non-main thread, which can happen with a PAC file.
+
+        * bridge/runtime_object.cpp:
+        (RuntimeObjectImp::RuntimeObjectImp):
+
 2008-03-12  Adam Roben  <aroben@apple.com>
 
         Fix Bug 17815: Inspector's DOM tree should descend into subframes
index 62f3989..248f12a 100644 (file)
@@ -35,9 +35,10 @@ using namespace Bindings;
 const ClassInfo RuntimeObjectImp::info = { "RuntimeObject", 0, 0 };
 
 RuntimeObjectImp::RuntimeObjectImp(PassRefPtr<Bindings::Instance> i)
-: instance(i)
+    : instance(i)
 {
     instance->rootObject()->addRuntimeObject(this);
+    Collector::collectOnMainThreadOnly(this);
 }
 
 RuntimeObjectImp::~RuntimeObjectImp()