Add ChromeClient::isPlayingAudioDidChange().
authoradachan@apple.com <adachan@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 6 Oct 2014 21:36:31 +0000 (21:36 +0000)
committeradachan@apple.com <adachan@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 6 Oct 2014 21:36:31 +0000 (21:36 +0000)
https://bugs.webkit.org/show_bug.cgi?id=137220

Reviewed by Jer Noble.

This is called when the Page's m_isPlayingAudio changes.

No new tests, no behavior change.

* page/ChromeClient.h:
(WebCore::ChromeClient::isPlayingAudioDidChange):
* page/Page.cpp:
(WebCore::Page::updateIsPlayingAudio):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/page/ChromeClient.h
Source/WebCore/page/Page.cpp

index 1897942..2a649bb 100644 (file)
@@ -1,3 +1,19 @@
+2014-10-06  Ada Chan  <adachan@apple.com>
+
+        Add ChromeClient::isPlayingAudioDidChange().
+        https://bugs.webkit.org/show_bug.cgi?id=137220
+
+        Reviewed by Jer Noble.
+
+        This is called when the Page's m_isPlayingAudio changes.
+
+        No new tests, no behavior change.
+
+        * page/ChromeClient.h:
+        (WebCore::ChromeClient::isPlayingAudioDidChange):
+        * page/Page.cpp:
+        (WebCore::Page::updateIsPlayingAudio):
+
 2014-10-06  Benjamin Poulain  <benjamin@webkit.org>
 
         Unreviewed, rolling out r174336.
index bf5634f..12b5898 100644 (file)
@@ -431,6 +431,8 @@ public:
 
     virtual bool shouldUseTiledBackingForFrameView(const FrameView*) const { return false; }
 
+    virtual void isPlayingAudioDidChange(bool) { }
+
 #if ENABLE(SUBTLE_CRYPTO)
     virtual bool wrapCryptoKey(const Vector<uint8_t>&, Vector<uint8_t>&) const { return false; }
     virtual bool unwrapCryptoKey(const Vector<uint8_t>&, Vector<uint8_t>&) const { return false; }
index 112e69e..bcae361 100644 (file)
@@ -1208,8 +1208,7 @@ void Page::updateIsPlayingAudio()
 
     m_isPlayingAudio = isPlayingAudio;
 
-    // FIXME: Notify the ChromeClient that the isPlayingAudio state has changed.
-    // https://bugs.webkit.org/show_bug.cgi?id=137220
+    chrome().client().isPlayingAudioDidChange(m_isPlayingAudio);
 }
 
 #if !ASSERT_DISABLED