Remove custom JSC bindings from ConvolverNode.idl
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 14 Aug 2012 12:10:37 +0000 (12:10 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 14 Aug 2012 12:10:37 +0000 (12:10 +0000)
https://bugs.webkit.org/show_bug.cgi?id=93952

Patch by Vineet Chaudhary <rgf748@motorola.com> on 2012-08-14
Reviewed by Kentaro Hara.

We should remove custom bindings as CodeGenerator uses UNUSED_PARAM macro.

No new tests. No behavioural changes.
All tests under webaudio/* should behave same.

* GNUmakefile.list.am: Removed JSConvolverNodeCustom.cpp from builds.
* Modules/webaudio/ConvolverNode.idl: Removed [JSCustomSetter].
* UseJSC.cmake: Removed JSConvolverNodeCustom.cpp from builds.
* WebCore.gypi: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto
* bindings/js/JSConvolverNodeCustom.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/GNUmakefile.list.am
Source/WebCore/Modules/webaudio/ConvolverNode.idl
Source/WebCore/UseJSC.cmake
Source/WebCore/WebCore.gypi
Source/WebCore/WebCore.xcodeproj/project.pbxproj
Source/WebCore/bindings/js/JSConvolverNodeCustom.cpp [deleted file]

index 35a90ca..3e60421 100644 (file)
@@ -1,3 +1,22 @@
+2012-08-14  Vineet Chaudhary  <rgf748@motorola.com>
+
+        Remove custom JSC bindings from ConvolverNode.idl
+        https://bugs.webkit.org/show_bug.cgi?id=93952
+
+        Reviewed by Kentaro Hara.
+
+        We should remove custom bindings as CodeGenerator uses UNUSED_PARAM macro.
+
+        No new tests. No behavioural changes.
+        All tests under webaudio/* should behave same.
+
+        * GNUmakefile.list.am: Removed JSConvolverNodeCustom.cpp from builds.
+        * Modules/webaudio/ConvolverNode.idl: Removed [JSCustomSetter].
+        * UseJSC.cmake: Removed JSConvolverNodeCustom.cpp from builds.
+        * WebCore.gypi: Ditto.
+        * WebCore.xcodeproj/project.pbxproj: Ditto
+        * bindings/js/JSConvolverNodeCustom.cpp: Removed.
+
 2012-08-14  Pavel Feldman  <pfeldman@chromium.org>
 
         Web Inspector: add external test runner for running inspector front-end tests with no TestRunner infrastructure.
index 7f52af1..f793c1e 100644 (file)
@@ -5774,7 +5774,6 @@ webcore_sources += \
        Source/WebCore/Modules/webaudio/WaveTable.h \
        Source/WebCore/bindings/js/JSAudioBufferSourceNodeCustom.cpp \
        Source/WebCore/bindings/js/JSAudioContextCustom.cpp \
-       Source/WebCore/bindings/js/JSConvolverNodeCustom.cpp \
        Source/WebCore/bindings/js/JSJavaScriptAudioNodeCustom.cpp \
        Source/WebCore/platform/audio/AudioArray.h \
        Source/WebCore/platform/audio/AudioBus.cpp \
index 0f561f0..d1c2c5b 100644 (file)
@@ -28,7 +28,7 @@ module audio {
         Conditional=WEB_AUDIO,
         JSGenerateToJSObject
     ] ConvolverNode : AudioNode {
-        attribute [JSCustomSetter] AudioBuffer buffer;
+        attribute AudioBuffer buffer;
         attribute boolean normalize;
     };
 }
index c0236b0..cf6d0bb 100644 (file)
@@ -276,7 +276,6 @@ IF (ENABLE_WEB_AUDIO)
     LIST(APPEND WebCore_SOURCES
         bindings/js/JSAudioBufferSourceNodeCustom.cpp
         bindings/js/JSAudioContextCustom.cpp
-        bindings/js/JSConvolverNodeCustom.cpp
         bindings/js/JSJavaScriptAudioNodeCustom.cpp
     )
 ENDIF ()
index 93180c7..1188773 100644 (file)
             'bindings/js/JSCanvasRenderingContextCustom.cpp',
             'bindings/js/JSClipboardCustom.cpp',
             'bindings/js/JSConsoleCustom.cpp',
-            'bindings/js/JSConvolverNodeCustom.cpp',
             'bindings/js/JSCoordinatesCustom.cpp',
             'bindings/js/JSCustomSQLStatementErrorCallback.cpp',
             'bindings/js/JSCustomVoidCallback.cpp',
index 6d08c31..de9081b 100644 (file)
                FDEA6247152102FC00479DF0 /* JSWaveTable.h in Headers */ = {isa = PBXBuildFile; fileRef = FDEA6245152102FC00479DF0 /* JSWaveTable.h */; };
                FDEAAAF312B02EE400DCF33B /* JSAudioBufferSourceNodeCustom.cpp in Sources */ = {isa = PBXBuildFile; fileRef = FDEAAAEF12B02EE400DCF33B /* JSAudioBufferSourceNodeCustom.cpp */; };
                FDEAAAF412B02EE400DCF33B /* JSAudioContextCustom.cpp in Sources */ = {isa = PBXBuildFile; fileRef = FDEAAAF012B02EE400DCF33B /* JSAudioContextCustom.cpp */; };
-               FDEAAAF612B02EE400DCF33B /* JSConvolverNodeCustom.cpp in Sources */ = {isa = PBXBuildFile; fileRef = FDEAAAF212B02EE400DCF33B /* JSConvolverNodeCustom.cpp */; };
                FDEAAAFE12B02F4900DCF33B /* JSJavaScriptAudioNodeCustom.cpp in Sources */ = {isa = PBXBuildFile; fileRef = FDEAAAFD12B02F4900DCF33B /* JSJavaScriptAudioNodeCustom.cpp */; };
                FDF09DC81399B62200688E5B /* JSBiquadFilterNode.cpp in Sources */ = {isa = PBXBuildFile; fileRef = FDF09DC61399B62200688E5B /* JSBiquadFilterNode.cpp */; };
                FDF09DC91399B62200688E5B /* JSBiquadFilterNode.h in Headers */ = {isa = PBXBuildFile; fileRef = FDF09DC71399B62200688E5B /* JSBiquadFilterNode.h */; };
                FDEA6245152102FC00479DF0 /* JSWaveTable.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSWaveTable.h; sourceTree = "<group>"; };
                FDEAAAEF12B02EE400DCF33B /* JSAudioBufferSourceNodeCustom.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSAudioBufferSourceNodeCustom.cpp; sourceTree = "<group>"; };
                FDEAAAF012B02EE400DCF33B /* JSAudioContextCustom.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSAudioContextCustom.cpp; sourceTree = "<group>"; };
-               FDEAAAF212B02EE400DCF33B /* JSConvolverNodeCustom.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSConvolverNodeCustom.cpp; sourceTree = "<group>"; };
                FDEAAAFD12B02F4900DCF33B /* JSJavaScriptAudioNodeCustom.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSJavaScriptAudioNodeCustom.cpp; sourceTree = "<group>"; };
                FDF09DC61399B62200688E5B /* JSBiquadFilterNode.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSBiquadFilterNode.cpp; sourceTree = "<group>"; };
                FDF09DC71399B62200688E5B /* JSBiquadFilterNode.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSBiquadFilterNode.h; sourceTree = "<group>"; };
                                93BA59B10F2AA5FE008E8E99 /* JSCDATASectionCustom.cpp */,
                                BCA83E510D7CE205003421A8 /* JSClipboardCustom.cpp */,
                                C0DFC86F0DB6841A003EAE7C /* JSConsoleCustom.cpp */,
-                               FDEAAAF212B02EE400DCF33B /* JSConvolverNodeCustom.cpp */,
                                FE700DD00F92D81A008E2BFE /* JSCoordinatesCustom.cpp */,
                                E1AD14901297337400ACA989 /* JSCSSFontFaceRuleCustom.cpp */,
                                E1AD147B1297307E00ACA989 /* JSCSSImportRuleCustom.cpp */,
                                BC98543D0CD3D98B00069BC1 /* JSConsole.cpp in Sources */,
                                C0DFC8700DB6841A003EAE7C /* JSConsoleCustom.cpp in Sources */,
                                FDA15EBD12B03F0B003A583A /* JSConvolverNode.cpp in Sources */,
-                               FDEAAAF612B02EE400DCF33B /* JSConvolverNodeCustom.cpp in Sources */,
                                FE6FD48D0F676E9300092873 /* JSCoordinates.cpp in Sources */,
                                FE700DD10F92D81A008E2BFE /* JSCoordinatesCustom.cpp in Sources */,
                                930705D809E0C9B700B17FE4 /* JSCounter.cpp in Sources */,
diff --git a/Source/WebCore/bindings/js/JSConvolverNodeCustom.cpp b/Source/WebCore/bindings/js/JSConvolverNodeCustom.cpp
deleted file mode 100644 (file)
index db7e244..0000000
+++ /dev/null
@@ -1,47 +0,0 @@
-/*
- * Copyright (C) 2010, Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1.  Redistributions of source code must retain the above copyright
- *    notice, this list of conditions and the following disclaimer.
- * 2.  Redistributions in binary form must reproduce the above copyright
- *    notice, this list of conditions and the following disclaimer in the
- *    documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND ANY
- * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
- * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
- * DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR ANY
- * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
- * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
- * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
- * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
- * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#include "config.h"
-
-#if ENABLE(WEB_AUDIO)
-
-#include "ConvolverNode.h"
-
-#include "AudioBuffer.h"
-#include "JSAudioBuffer.h"
-#include "JSConvolverNode.h"
-
-using namespace JSC;
-
-namespace WebCore {
-
-void JSConvolverNode::setBuffer(ExecState*, JSValue value)
-{
-    ConvolverNode* imp = static_cast<ConvolverNode*>(impl());
-    imp->setBuffer(toAudioBuffer(value));
-}
-
-} // namespace WebCore
-
-#endif // ENABLE(WEB_AUDIO)