2011-04-28 Sheriff Bot <webkit.review.bot@gmail.com>
authorloislo@chromium.org <loislo@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 29 Apr 2011 00:06:27 +0000 (00:06 +0000)
committerloislo@chromium.org <loislo@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 29 Apr 2011 00:06:27 +0000 (00:06 +0000)
        Unreviewed, rolling out r85101.
        http://trac.webkit.org/changeset/85101
        https://bugs.webkit.org/show_bug.cgi?id=59757

         it'd be better to rollout the patch and do another one with
        another property name. Current one will bring us to a problem
        at first run after upgrade because it's type was changed from
        int to string. (Requested by loislo on #webkit).

        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._debuggerWasEnabled):
        (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions.callback):
        (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/inspector/front-end/ScriptsPanel.js

index bb6ae9d..6d2d285 100644 (file)
@@ -1,3 +1,19 @@
+2011-04-28  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r85101.
+        http://trac.webkit.org/changeset/85101
+        https://bugs.webkit.org/show_bug.cgi?id=59757
+
+         it'd be better to rollout the patch and do another one with
+        another property name. Current one will bring us to a problem
+        at first run after upgrade because it's type was changed from
+        int to string. (Requested by loislo on #webkit).
+
+        * inspector/front-end/ScriptsPanel.js:
+        (WebInspector.ScriptsPanel.prototype._debuggerWasEnabled):
+        (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions.callback):
+        (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
+
 2011-04-28  Mike Reed  <reed@google.com>
 
         Reviewed by Eric Seidel.
index fcc9bed..b0da639 100644 (file)
@@ -446,7 +446,7 @@ WebInspector.ScriptsPanel.prototype = {
 
     _debuggerWasEnabled: function()
     {
-        this._setPauseOnExceptions(WebInspector.settings.pauseOnExceptionState);
+        this._setPauseOnExceptions(WebInspector.settings.pauseOnExceptionStateString);
 
         if (this._debuggerEnabled)
             return;
@@ -715,7 +715,7 @@ WebInspector.ScriptsPanel.prototype = {
                 this._pauseOnExceptionButton.title = WebInspector.UIString("Pause on uncaught exceptions.\nClick to Not pause on exceptions.");
 
             this._pauseOnExceptionButton.state = pauseOnExceptionsState;
-            WebInspector.settings.pauseOnExceptionState = pauseOnExceptionsState;
+            WebInspector.settings.pauseOnExceptionStateString = pauseOnExceptionsState;
         }
         DebuggerAgent.setPauseOnExceptions(pauseOnExceptionsState, callback.bind(this));
     },