Web Inspector: REGRESSION (r217505): Debugger content view doesn't update when left...
authormattbaker@apple.com <mattbaker@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 10 Jul 2018 16:44:45 +0000 (16:44 +0000)
committermattbaker@apple.com <mattbaker@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 10 Jul 2018 16:44:45 +0000 (16:44 +0000)
https://bugs.webkit.org/show_bug.cgi?id=187482
<rdar://problem/41989190>

Reviewed by Brian Burg.

Subclasses of NavigationSidebarPanel must process tree selection changes
even when collapsed. Sidebar panels perform critical controller tasks
for their tabs, such as updating the view when pausing in the debugger,
and when the hierarchical path component selection changes.

* UserInterface/Views/DebuggerSidebarPanel.js:
(WI.DebuggerSidebarPanel.prototype._treeSelectionDidChange):
* UserInterface/Views/ResourceSidebarPanel.js:
(WI.ResourceSidebarPanel.prototype._treeSelectionDidChange):
* UserInterface/Views/SearchSidebarPanel.js:
(WI.SearchSidebarPanel.prototype._treeSelectionDidChange):
* UserInterface/Views/SourcesSidebarPanel.js:
(WI.SourcesSidebarPanel.prototype._treeSelectionDidChange):
* UserInterface/Views/StorageSidebarPanel.js:
(WI.StorageSidebarPanel._treeSelectionDidChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@233686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js
Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js
Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js
Source/WebInspectorUI/UserInterface/Views/SourcesSidebarPanel.js
Source/WebInspectorUI/UserInterface/Views/StorageSidebarPanel.js

index 18636b3..c86bf12 100644 (file)
@@ -1,3 +1,27 @@
+2018-07-10  Matt Baker  <mattbaker@apple.com>
+
+        Web Inspector: REGRESSION (r217505): Debugger content view doesn't update when left sidebar is collapsed
+        https://bugs.webkit.org/show_bug.cgi?id=187482
+        <rdar://problem/41989190>
+
+        Reviewed by Brian Burg.
+
+        Subclasses of NavigationSidebarPanel must process tree selection changes
+        even when collapsed. Sidebar panels perform critical controller tasks
+        for their tabs, such as updating the view when pausing in the debugger,
+        and when the hierarchical path component selection changes.
+
+        * UserInterface/Views/DebuggerSidebarPanel.js:
+        (WI.DebuggerSidebarPanel.prototype._treeSelectionDidChange):
+        * UserInterface/Views/ResourceSidebarPanel.js:
+        (WI.ResourceSidebarPanel.prototype._treeSelectionDidChange):
+        * UserInterface/Views/SearchSidebarPanel.js:
+        (WI.SearchSidebarPanel.prototype._treeSelectionDidChange):
+        * UserInterface/Views/SourcesSidebarPanel.js:
+        (WI.SourcesSidebarPanel.prototype._treeSelectionDidChange):
+        * UserInterface/Views/StorageSidebarPanel.js:
+        (WI.StorageSidebarPanel._treeSelectionDidChange):
+
 2018-07-09  Brian Burg  <bburg@apple.com>
 
         REGRESSION: Web Inspector no longer pauses in internal injected scripts like WDFindNodes.js
index 5917b05..5a53625 100644 (file)
@@ -828,7 +828,7 @@ WI.DebuggerSidebarPanel = class DebuggerSidebarPanel extends WI.NavigationSideba
 
     _treeSelectionDidChange(event)
     {
-        if (!this.visible)
+        if (!this.selected)
             return;
 
         let treeElement = event.data.selectedElement;
index 26ad502..34c2604 100644 (file)
@@ -452,7 +452,7 @@ WI.ResourceSidebarPanel = class ResourceSidebarPanel extends WI.NavigationSideba
 
     _treeSelectionDidChange(event)
     {
-        if (!this.visible)
+        if (!this.selected)
             return;
 
         let treeElement = event.data.selectedElement;
index 6ba6574..130c147 100644 (file)
@@ -363,7 +363,7 @@ WI.SearchSidebarPanel = class SearchSidebarPanel extends WI.NavigationSidebarPan
 
     _treeSelectionDidChange(event)
     {
-        if (!this.visible)
+        if (!this.selected)
             return;
 
         let treeElement = event.data.selectedElement;
index 0b7f62d..dbb0f03 100644 (file)
@@ -452,7 +452,7 @@ WI.SourcesSidebarPanel = class SourcesSidebarPanel extends WI.NavigationSidebarP
 
     _treeSelectionDidChange(event)
     {
-        if (!this.visible)
+        if (!this.selected)
             return;
 
         let treeElement = event.data.selectedElement;
index f93dc3e..eb3c508 100644 (file)
@@ -166,7 +166,7 @@ WI.StorageSidebarPanel = class StorageSidebarPanel extends WI.NavigationSidebarP
 
     _treeSelectionDidChange(event)
     {
-        if (!this.visible)
+        if (!this.selected)
             return;
 
         let treeElement = event.data.selectedElement;