[GTK][WPE] Websockets close-on-x tests are failing
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 24 Jan 2020 18:29:28 +0000 (18:29 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 24 Jan 2020 18:29:28 +0000 (18:29 +0000)
https://bugs.webkit.org/show_bug.cgi?id=206392

Unreviewed gardening.

Rebaseline after libsoup commit 35f1bac5.

Patch by Lauro Moura <lmoura@igalia.com> on 2020-01-24

* platform/gtk/TestExpectations:
* platform/gtk/http/tests/websocket/tests/hybi/close-on-navigate-new-location-expected.txt: Added.
* platform/gtk/http/tests/websocket/tests/hybi/close-on-unload-and-force-gc-expected.txt: Added.
* platform/gtk/http/tests/websocket/tests/hybi/close-on-unload-expected.txt: Added.
* platform/gtk/http/tests/websocket/tests/hybi/close-on-unload-reference-in-parent-expected.txt: Added.
* platform/gtk/http/tests/websocket/tests/hybi/send-after-close-on-unload-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/gtk/TestExpectations
LayoutTests/platform/gtk/http/tests/websocket/tests/hybi/close-on-navigate-new-location-expected.txt [new file with mode: 0644]
LayoutTests/platform/gtk/http/tests/websocket/tests/hybi/close-on-unload-and-force-gc-expected.txt [new file with mode: 0644]
LayoutTests/platform/gtk/http/tests/websocket/tests/hybi/close-on-unload-expected.txt [new file with mode: 0644]
LayoutTests/platform/gtk/http/tests/websocket/tests/hybi/close-on-unload-reference-in-parent-expected.txt [new file with mode: 0644]
LayoutTests/platform/gtk/http/tests/websocket/tests/hybi/send-after-close-on-unload-expected.txt [new file with mode: 0644]

index 631aa25..d8d7aff 100644 (file)
@@ -1,3 +1,19 @@
+2020-01-24  Lauro Moura  <lmoura@igalia.com>
+
+        [GTK][WPE] Websockets close-on-x tests are failing
+        https://bugs.webkit.org/show_bug.cgi?id=206392
+
+        Unreviewed gardening.
+
+        Rebaseline after libsoup commit 35f1bac5.
+
+        * platform/gtk/TestExpectations:
+        * platform/gtk/http/tests/websocket/tests/hybi/close-on-navigate-new-location-expected.txt: Added.
+        * platform/gtk/http/tests/websocket/tests/hybi/close-on-unload-and-force-gc-expected.txt: Added.
+        * platform/gtk/http/tests/websocket/tests/hybi/close-on-unload-expected.txt: Added.
+        * platform/gtk/http/tests/websocket/tests/hybi/close-on-unload-reference-in-parent-expected.txt: Added.
+        * platform/gtk/http/tests/websocket/tests/hybi/send-after-close-on-unload-expected.txt: Added.
+
 2020-01-24  Rob Buis  <rbuis@igalia.com>
 
         [GTK][WPE] Several WPT fetch tests are failing
index 636d765..5edbace 100644 (file)
@@ -3979,12 +3979,6 @@ webkit.org/b/202242 http/tests/websocket/tests/hybi/non-document-mixed-content-b
 webkit.org/b/202242 http/tests/websocket/tests/hybi/non-document-mixed-content-blocked.https.html [ Failure ]
 webkit.org/b/202242 http/tests/websocket/tests/hybi/websocket-blocked-from-setting-cookie-as-third-party.html [ Failure ]
 
-webkit.org/b/206392 http/tests/websocket/tests/hybi/close-on-navigate-new-location.html [ Failure ]
-webkit.org/b/206392 http/tests/websocket/tests/hybi/close-on-unload-and-force-gc.html [ Failure ]
-webkit.org/b/206392 http/tests/websocket/tests/hybi/close-on-unload-reference-in-parent.html [ Failure ]
-webkit.org/b/206392 http/tests/websocket/tests/hybi/close-on-unload.html [ Failure ]
-webkit.org/b/206392 http/tests/websocket/tests/hybi/send-after-close-on-unload.html [ Failure ]
-
 webkit.org/b/202245 http/tests/workers/service/ServiceWorkerGlobalScope_register.html [ Failure ]
 webkit.org/b/202245 http/tests/workers/service/registration-updateViaCache-none-importScripts.html [ Failure ]
 webkit.org/b/202245 http/tests/workers/service/self_registration.html [ Failure ]
diff --git a/LayoutTests/platform/gtk/http/tests/websocket/tests/hybi/close-on-navigate-new-location-expected.txt b/LayoutTests/platform/gtk/http/tests/websocket/tests/hybi/close-on-navigate-new-location-expected.txt
new file mode 100644 (file)
index 0000000..16355f5
--- /dev/null
@@ -0,0 +1,12 @@
+Test if Web Socket is closed when navigating to new location.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+PASS ws on master document is ready.
+PASS insert a iframe, where open ws called 'socket1'
+PASS 'socket1' is sent to the server. navigate to new location. expect receiving 'socket1' on ws...
+FAIL closedSocket should be socket1. Was socket1: receive next message.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
diff --git a/LayoutTests/platform/gtk/http/tests/websocket/tests/hybi/close-on-unload-and-force-gc-expected.txt b/LayoutTests/platform/gtk/http/tests/websocket/tests/hybi/close-on-unload-and-force-gc-expected.txt
new file mode 100644 (file)
index 0000000..dc05871
--- /dev/null
@@ -0,0 +1,12 @@
+Test if Web Socket is closed on unload and not crashed if garbage collected
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+PASS ws on master document is ready.
+PASS insert a iframe, where open ws called 'socket1'
+PASS 'socket1' is sent to the server. unload the iframe and force garbage collection. expect receiving 'socket1' on ws and no crash...
+FAIL closedSocket should be socket1. Was socket1: receive next message.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
diff --git a/LayoutTests/platform/gtk/http/tests/websocket/tests/hybi/close-on-unload-expected.txt b/LayoutTests/platform/gtk/http/tests/websocket/tests/hybi/close-on-unload-expected.txt
new file mode 100644 (file)
index 0000000..cdec548
--- /dev/null
@@ -0,0 +1,12 @@
+Test if Web Socket is closed on unload
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+PASS ws on master document is ready.
+PASS insert a iframe, where open ws called 'socket1'
+PASS 'socket1' is sent to the server. unload the iframe. expect receiving 'socket1' on ws...
+FAIL closedSocket should be socket1. Was socket1: receive next message.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
diff --git a/LayoutTests/platform/gtk/http/tests/websocket/tests/hybi/close-on-unload-reference-in-parent-expected.txt b/LayoutTests/platform/gtk/http/tests/websocket/tests/hybi/close-on-unload-reference-in-parent-expected.txt
new file mode 100644 (file)
index 0000000..9815bd0
--- /dev/null
@@ -0,0 +1,14 @@
+Test if Web Socket opened in iframe but referred in parent document is closed on unloading the frame.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+PASS ws on master document is ready.
+PASS insert a iframe, where open ws called 'socket1'
+PASS document.childWebSocket is non-null.
+PASS 'socket1' is sent to the server. unload the iframe. expect receiving 'socket1' on ws...
+FAIL closedSocket should be socket1. Was socket1: receive next message.
+PASS document.childWebSocket.readyState is 3
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
diff --git a/LayoutTests/platform/gtk/http/tests/websocket/tests/hybi/send-after-close-on-unload-expected.txt b/LayoutTests/platform/gtk/http/tests/websocket/tests/hybi/send-after-close-on-unload-expected.txt
new file mode 100644 (file)
index 0000000..9f5dcb5
--- /dev/null
@@ -0,0 +1,15 @@
+Test if Web Socket opened in iframe, referred in parent document is, and try to send() returns false.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+PASS ws on master document is ready.
+PASS insert a iframe, where open ws called 'socket1'
+PASS document.childWebSocket is non-null.
+PASS 'socket1' is sent to the server. unload the iframe. expect receiving 'socket1' on ws...
+PASS document.childWebSocket.send('send to closed socket') is undefined.
+FAIL closedSocket should be socket1. Was socket1: receive next message.
+PASS document.childWebSocket.readyState is 3
+PASS successfullyParsed is true
+
+TEST COMPLETE
+