Recognize mailto and tel url as data detector links.

https://bugs.webkit.org/show_bug.cgi?id=155569
rdar://problem/24836185

Reviewed by Sam Weinig.

When we check if the element is a data detector link,
we should return true also for URLs with mailto: and tel: scheme.

* editing/cocoa/DataDetection.mm:
(WebCore::DataDetection::isDataDetectorLink):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@198311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
index 365fed4..e23458e 100644 (file)
--- a/Source/WebCore/ChangeLog
+++ b/Source/WebCore/ChangeLog
@@ -1,3 +1,17 @@
+2016-03-16  Enrica Casucci  <enrica@apple.com>
+
+        Recognize mailto and tel url as data detector links.
+        https://bugs.webkit.org/show_bug.cgi?id=155569
+        rdar://problem/24836185
+
+        Reviewed by Sam Weinig.
+
+        When we check if the element is a data detector link,
+        we should return true also for URLs with mailto: and tel: scheme.
+
+        * editing/cocoa/DataDetection.mm:
+        (WebCore::DataDetection::isDataDetectorLink):
+
 2016-03-16  Zalan Bujtas  <zalan@apple.com>
 
         Subpixel rendering: Directly composited image layers need pixelsnapping.

diff --git a/Source/WebCore/editing/cocoa/DataDetection.mm b/Source/WebCore/editing/cocoa/DataDetection.mm
index ade3abd..0e601be 100644 (file)
--- a/Source/WebCore/editing/cocoa/DataDetection.mm
+++ b/Source/WebCore/editing/cocoa/DataDetection.mm
@@ -57,7 +57,14 @@ namespace WebCore {
 
 bool DataDetection::isDataDetectorLink(Element* element)
 {
-    return element->getAttribute(dataDetectorsURLScheme) == "true";
+    // FIXME: We should be able to ask this from DataDetectorsCore when rdar://problem/25206062 is fixed.
+    if (!is<HTMLAnchorElement>(*element))
+        return false;
+
+    if (element->getAttribute(dataDetectorsURLScheme) == "true")
+        return true;
+    URL url = downcast<HTMLAnchorElement>(*element).href();
+    return url.protocolIs("mailto") || url.protocolIs("tel");
 }
 
 bool DataDetection::requiresExtendedContext(Element* element)
@@ -76,7 +83,7 @@ bool DataDetection::shouldCancelDefaultAction(Element* element)
     UNUSED_PARAM(element);
     return false;
 #else
-    // FIXME: We should also compute the DDResultRef and check the result category.
+    // FIXME: We should be able to retrieve this information from DataDetectorsCore when rdar://problem/25169133 is fixed.
     if (!is<HTMLAnchorElement>(*element))
         return false;
     if (element->getAttribute(dataDetectorsURLScheme) != "true")