Web Inspector: text-editor-ctrl-movements.html timeouts on mac
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 31 Jan 2013 12:01:01 +0000 (12:01 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 31 Jan 2013 12:01:01 +0000 (12:01 +0000)
https://bugs.webkit.org/show_bug.cgi?id=108440

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-31
Reviewed by Pavel Feldman.

Use "alt-arrows" key shortcuts to jump over words instead of
"ctrl-arrows" on Mac platform.

* inspector/editor/text-editor-word-jumps-expected.txt: Renamed from LayoutTests/inspector/editor/text-editor-ctrl-movements-expected.txt.
* inspector/editor/text-editor-word-jumps.html: Renamed from LayoutTests/inspector/editor/text-editor-ctrl-movements.html.
* platform/chromium/TestExpectations: Do not skip this test anymore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/inspector/editor/text-editor-word-jumps-expected.txt [moved from LayoutTests/inspector/editor/text-editor-ctrl-movements-expected.txt with 100% similarity]
LayoutTests/inspector/editor/text-editor-word-jumps.html [moved from LayoutTests/inspector/editor/text-editor-ctrl-movements.html with 89% similarity]
LayoutTests/platform/chromium/TestExpectations

index 40bd53a..06c6789 100644 (file)
@@ -1,3 +1,17 @@
+2013-01-31  Andrey Lushnikov  <lushnikov@chromium.org>
+
+        Web Inspector: text-editor-ctrl-movements.html timeouts on mac
+        https://bugs.webkit.org/show_bug.cgi?id=108440
+
+        Reviewed by Pavel Feldman.
+
+        Use "alt-arrows" key shortcuts to jump over words instead of
+        "ctrl-arrows" on Mac platform.
+
+        * inspector/editor/text-editor-word-jumps-expected.txt: Renamed from LayoutTests/inspector/editor/text-editor-ctrl-movements-expected.txt.
+        * inspector/editor/text-editor-word-jumps.html: Renamed from LayoutTests/inspector/editor/text-editor-ctrl-movements.html.
+        * platform/chromium/TestExpectations: Do not skip this test anymore.
+
 2013-01-30  Yury Semikhatsky  <yurys@chromium.org>
 
         Web Inspector: test that references from DOM nodes to event listeners are presented in heap snapshots
@@ -20,6 +20,7 @@ function testFunction(foo, bar)
     textEditor.element.focus();
 
     InspectorTest.addResult(textEditor.text());
+    const wordJumpModifier = WebInspector.isMac() ? "altKey" : "ctrlKey";
 
     function dumpEditorSelection()
     {
@@ -53,7 +54,7 @@ function testFunction(foo, bar)
             var oldSelection;
             do {
                 oldSelection = selection;
-                eventSender.keyDown("rightArrow", ["ctrlKey"]);
+                eventSender.keyDown("rightArrow", [wordJumpModifier]);
                 selection = dumpEditorSelection();
             } while (selection.compareTo(oldSelection) !== 0);
             next();
@@ -66,7 +67,7 @@ function testFunction(foo, bar)
             var oldSelection;
             do {
                 oldSelection = selection;
-                eventSender.keyDown("leftArrow", ["ctrlKey"]);
+                eventSender.keyDown("leftArrow", [wordJumpModifier]);
                 selection = dumpEditorSelection();
             } while (selection.compareTo(oldSelection) !== 0);
             next();
@@ -79,7 +80,7 @@ function testFunction(foo, bar)
             var oldSelection;
             do {
                 oldSelection = selection;
-                eventSender.keyDown("rightArrow", ["ctrlKey", "shiftKey"]);
+                eventSender.keyDown("rightArrow", [wordJumpModifier, "shiftKey"]);
                 selection = dumpEditorSelection();
             } while (selection.collapseToEnd().compareTo(oldSelection.collapseToEnd()) !== 0);
             next();
@@ -92,7 +93,7 @@ function testFunction(foo, bar)
             var oldSelection;
             do {
                 oldSelection = selection;
-                eventSender.keyDown("leftArrow", ["ctrlKey", "shiftKey"]);
+                eventSender.keyDown("leftArrow", [wordJumpModifier, "shiftKey"]);
                 selection = dumpEditorSelection();
             } while (selection.collapseToEnd().compareTo(oldSelection.collapseToEnd()) !== 0);
             next();
@@ -104,7 +105,7 @@ function testFunction(foo, bar)
             InspectorTest.addResult("===============");
             InspectorTest.addResult(textEditor.text());
             do {
-                eventSender.keyDown("\b", ["ctrlKey"]);
+                eventSender.keyDown("\b", [wordJumpModifier]);
                 InspectorTest.addResult("===============");
                 InspectorTest.addResult(textEditor.text() + "<<");
             } while (textEditor.text() !== "");
index 6db14b4..e96fce5 100644 (file)
@@ -1069,9 +1069,6 @@ webkit.org/b/75186 [ Linux ] http/tests/inspector-enabled/dedicated-workers-list
 
 webkit.org/b/75647 http/tests/inspector/network/download.html [ Pass Timeout Failure ]
 
-# Timing out after http://trac.webkit.org/changeset/141245
-webkit.org/b/107944 inspector/editor/text-editor-ctrl-movements.html [ Pass Timeout ]
-
 # -----------------------------------------------------------------
 # Editing tests
 # -----------------------------------------------------------------