[EFL] Focus problem in inspector/extensions/extensions-panel.html

https://bugs.webkit.org/show_bug.cgi?id=97077

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-02-28
Reviewed by Laszlo Gombos.

Source/WebKit/efl:

* WebCoreSupport/InspectorClientEfl.cpp:
(WebCore::InspectorFrontendClientEfl::bringToFront): Set focus on inspectorView.

LayoutTests:

Remove inspector/extensions/extensions-panel.html from TestExpectations.

* platform/efl-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index e66d5fd..4d73f5a 100644 (file)
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,14 @@
+2013-02-28  Seokju Kwon  <seokju.kwon@gmail.com>
+
+        [EFL] Focus problem in inspector/extensions/extensions-panel.html
+        https://bugs.webkit.org/show_bug.cgi?id=97077
+
+        Reviewed by Laszlo Gombos.
+
+        Remove inspector/extensions/extensions-panel.html from TestExpectations.
+
+        * platform/efl-wk1/TestExpectations:
+
 2013-02-28  Levi Weintraub  <leviw@chromium.org>
 
         Stale FrameSelection in removed iframe causes crash

diff --git a/LayoutTests/platform/efl-wk1/TestExpectations b/LayoutTests/platform/efl-wk1/TestExpectations
index 94d6179..5c51add 100644 (file)
--- a/LayoutTests/platform/efl-wk1/TestExpectations
+++ b/LayoutTests/platform/efl-wk1/TestExpectations
@@ -262,9 +262,6 @@ webkit.org/b/102517 css3/device-adapt/opera [ Skip ]
 webkit.org/b/87972 fast/loader/policy-delegate-action-hit-test-zoomed.html [ Failure ]
 webkit.org/b/87972 fast/encoding/mailto-always-utf-8.html [ Failure ]
 
-# Frame does not get focus as expected
-webkit.org/b/97077 inspector/extensions/extensions-panel.html [ Failure ]
-
 # Fails after r133322
 webkit.org/b/98523 fast/images/repaint-subrect-grid.html [ Failure ]
 

diff --git a/Source/WebKit/efl/ChangeLog b/Source/WebKit/efl/ChangeLog
index 754cddd..5e32027 100644 (file)
--- a/Source/WebKit/efl/ChangeLog
+++ b/Source/WebKit/efl/ChangeLog
@@ -1,3 +1,13 @@
+2013-02-28  Seokju Kwon  <seokju.kwon@gmail.com>
+
+        [EFL] Focus problem in inspector/extensions/extensions-panel.html
+        https://bugs.webkit.org/show_bug.cgi?id=97077
+
+        Reviewed by Laszlo Gombos.
+
+        * WebCoreSupport/InspectorClientEfl.cpp:
+        (WebCore::InspectorFrontendClientEfl::bringToFront): Set focus on inspectorView.
+
 2013-02-23  Jason Anderssen  <janderssen@gmail.com>
 
         Move setAutofilled from TestRunner to WebCore

diff --git a/Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp b/Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp
index ea742df..1d6e083 100644 (file)
--- a/Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp
+++ b/Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp
@@ -175,7 +175,7 @@ String InspectorFrontendClientEfl::hiddenPanels()
 
 void InspectorFrontendClientEfl::bringToFront()
 {
-    notImplemented();
+    evas_object_focus_set(m_inspectorView, true);
 }
 
 void InspectorFrontendClientEfl::closeWindow()