REGGRESSION (r142112): It made compositing tests fail on EFL, Qt.
authorallan.jensen@digia.com <allan.jensen@digia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 6 Mar 2013 09:59:22 +0000 (09:59 +0000)
committerallan.jensen@digia.com <allan.jensen@digia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 6 Mar 2013 09:59:22 +0000 (09:59 +0000)
https://bugs.webkit.org/show_bug.cgi?id=109291

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Report we support fixed layers.

* page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.h:
(WebCore::ScrollingCoordinatorCoordinatedGraphics::supportsFixedPositionLayers):
(ScrollingCoordinatorCoordinatedGraphics):

LayoutTests:

Unskip now passing test, and move baselines specific to having no scrolling-coordinator to WK1.

* platform/qt-5.0-wk1/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png: Renamed from LayoutTests/platform/qt/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png.
* platform/qt-5.0-wk1/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt: Renamed from LayoutTests/platform/qt/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt.
* platform/qt-5.0-wk1/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.png: Renamed from LayoutTests/platform/qt/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.png.
* platform/qt-5.0-wk1/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt: Renamed from LayoutTests/platform/qt/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt.
* platform/qt-5.0-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/qt-5.0-wk1/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png [moved from LayoutTests/platform/qt/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png with 100% similarity]
LayoutTests/platform/qt-5.0-wk1/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt [moved from LayoutTests/platform/qt/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt with 100% similarity]
LayoutTests/platform/qt-5.0-wk1/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.png [moved from LayoutTests/platform/qt/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.png with 100% similarity]
LayoutTests/platform/qt-5.0-wk1/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt [moved from LayoutTests/platform/qt/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt with 100% similarity]
LayoutTests/platform/qt-5.0-wk2/TestExpectations
Source/WebCore/ChangeLog
Source/WebCore/page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.h

index c2bc2b3..058d4b6 100644 (file)
@@ -1,3 +1,18 @@
+2013-03-06  Allan Sandfeld Jensen  <allan.jensen@digia.com>
+
+        REGGRESSION (r142112): It made compositing tests fail on EFL, Qt.
+        https://bugs.webkit.org/show_bug.cgi?id=109291
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Unskip now passing test, and move baselines specific to having no scrolling-coordinator to WK1.
+
+        * platform/qt-5.0-wk1/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png: Renamed from LayoutTests/platform/qt/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png.
+        * platform/qt-5.0-wk1/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt: Renamed from LayoutTests/platform/qt/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt.
+        * platform/qt-5.0-wk1/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.png: Renamed from LayoutTests/platform/qt/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.png.
+        * platform/qt-5.0-wk1/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt: Renamed from LayoutTests/platform/qt/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt.
+        * platform/qt-5.0-wk2/TestExpectations:
+
 2013-03-06  Hayato Ito  <hayato@chromium.org>
 
         Unreviewed gardening.
index 6147d1f..580e07a 100644 (file)
@@ -374,11 +374,6 @@ webkit.org/b/101165 compositing/repaint/invalidations-on-composited-layers.html
 # [Qt][Wk2] REGGRESSION (r142112): It made compositing tests fail.
 webkit.org/b/109291 compositing/iframes/iframe-composited-scrolling.html
 webkit.org/b/109291 compositing/layer-creation/fixed-position-in-view-dynamic.html
-webkit.org/b/109291 compositing/layer-creation/fixed-position-out-of-view-dynamic.html
-webkit.org/b/109291 compositing/layer-creation/fixed-position-out-of-view-scroll-reason.html
-webkit.org/b/109291 compositing/layer-creation/no-compositing-for-fixed-position-under-transform.html
-webkit.org/b/109291 scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html
-webkit.org/b/109291 scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html
 
 # [Qt] [WK2] Some fullscreen layout tests are timing out on the bot
 # https://bugs.webkit.org/show_bug.cgi?id=92543
index ec37ef4..c518f65 100644 (file)
@@ -1,3 +1,16 @@
+2013-03-06  Allan Sandfeld Jensen  <allan.jensen@digia.com>
+
+        REGGRESSION (r142112): It made compositing tests fail on EFL, Qt.
+        https://bugs.webkit.org/show_bug.cgi?id=109291
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Report we support fixed layers.
+
+        * page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.h:
+        (WebCore::ScrollingCoordinatorCoordinatedGraphics::supportsFixedPositionLayers):
+        (ScrollingCoordinatorCoordinatedGraphics):
+
 2013-03-06  Sheriff Bot  <webkit.review.bot@gmail.com>
 
         Unreviewed, rolling out r144859.
index 87c2c72..4e04bbe 100644 (file)
@@ -36,6 +36,8 @@ class ScrollingCoordinatorCoordinatedGraphics : public ScrollingCoordinator {
 public:
     explicit ScrollingCoordinatorCoordinatedGraphics(Page*);
 
+    virtual bool supportsFixedPositionLayers() const { return true; }
+
     virtual void setLayerIsFixedToContainerLayer(GraphicsLayer*, bool);
 };