Use ASSERT instead of ASSERT_WITH_SECURITY_IMPLICATION
authorgyuyoung.kim@samsung.com <gyuyoung.kim@samsung.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 11 Sep 2014 04:42:38 +0000 (04:42 +0000)
committergyuyoung.kim@samsung.com <gyuyoung.kim@samsung.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 11 Sep 2014 04:42:38 +0000 (04:42 +0000)
https://bugs.webkit.org/show_bug.cgi?id=136732

Reviewed by Andy Estes.

Since r173458 changed to use static_cast<> with toFoo, ASSERT_WITH_SECURITY_IMPLICATION doesn't
need to be used anymore. ASSERT is enough for it.

* workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerProxy::addToWorkerDocuments):
* workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::startWorkerGlobalScope):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::document):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/workers/DefaultSharedWorkerRepository.cpp
Source/WebCore/workers/WorkerMessagingProxy.cpp
Source/WebCore/xml/XMLHttpRequest.cpp

index a3ef081..dfaae16 100644 (file)
@@ -1,3 +1,20 @@
+2014-09-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
+
+        Use ASSERT instead of ASSERT_WITH_SECURITY_IMPLICATION
+        https://bugs.webkit.org/show_bug.cgi?id=136732
+
+        Reviewed by Andy Estes.
+
+        Since r173458 changed to use static_cast<> with toFoo, ASSERT_WITH_SECURITY_IMPLICATION doesn't
+        need to be used anymore. ASSERT is enough for it.
+
+        * workers/DefaultSharedWorkerRepository.cpp:
+        (WebCore::SharedWorkerProxy::addToWorkerDocuments):
+        * workers/WorkerMessagingProxy.cpp:
+        (WebCore::WorkerMessagingProxy::startWorkerGlobalScope):
+        * xml/XMLHttpRequest.cpp:
+        (WebCore::XMLHttpRequest::document):
+
 2014-09-10  Adenilson Cavalcanti  <cavalcantii@gmail.com>
 
         [SVG] Cleanup iterator code in SMILTimeContainer using range-based loop
index ee9c674..930c614 100644 (file)
@@ -225,7 +225,7 @@ void SharedWorkerProxy::workerGlobalScopeDestroyed()
 void SharedWorkerProxy::addToWorkerDocuments(ScriptExecutionContext* context)
 {
     // Nested workers are not yet supported, so passed-in context should always be a Document.
-    ASSERT_WITH_SECURITY_IMPLICATION(context);
+    ASSERT(context);
     ASSERT(!isClosing());
     MutexLocker lock(m_workerDocumentsLock);
     m_workerDocuments.add(toDocument(context));
index 2cd009f..c3c18c0 100644 (file)
@@ -82,7 +82,7 @@ WorkerMessagingProxy::~WorkerMessagingProxy()
 void WorkerMessagingProxy::startWorkerGlobalScope(const URL& scriptURL, const String& userAgent, const String& sourceCode, WorkerThreadStartMode startMode)
 {
     // FIXME: This need to be revisited when we support nested worker one day
-    ASSERT_WITH_SECURITY_IMPLICATION(m_scriptExecutionContext);
+    ASSERT(m_scriptExecutionContext);
     Document* document = toDocument(m_scriptExecutionContext);
     GroupSettings* settings = 0;
     if (document->page())
index 9b31f2e..74a1302 100644 (file)
@@ -154,7 +154,7 @@ XMLHttpRequest::~XMLHttpRequest()
 
 Document* XMLHttpRequest::document() const
 {
-    ASSERT_WITH_SECURITY_IMPLICATION(scriptExecutionContext());
+    ASSERT(scriptExecutionContext());
     return toDocument(scriptExecutionContext());
 }