Fix #end vs. #endif typo.

https://bugs.webkit.org/show_bug.cgi?id=191668
<rdar://problem/46081704>

Reviewed by Alexey Proskuryakov.

Source/WebCore/SourcesCocoa.txt had a #end that should have been a
#endif. Fix this, an add a check to generate-unified-source-bundles.rb
to detect similar typos.

Source/WebCore:

No new tests -- no changed functionality.

* SourcesCocoa.txt:

Source/WTF:

* Scripts/generate-unified-source-bundles.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Source/WTF/ChangeLog b/Source/WTF/ChangeLog
index a47f023..d11d9de 100644 (file)
--- a/Source/WTF/ChangeLog
+++ b/Source/WTF/ChangeLog
@@ -1,3 +1,17 @@
+2018-11-14  Keith Rollin  <krollin@apple.com>
+
+        Fix #end vs. #endif typo.
+        https://bugs.webkit.org/show_bug.cgi?id=191668
+        <rdar://problem/46081704>
+
+        Reviewed by Alexey Proskuryakov.
+
+        Source/WebCore/SourcesCocoa.txt had a #end that should have been a
+        #endif. Fix this, an add a check to generate-unified-source-bundles.rb
+        to detect similar typos.
+
+        * Scripts/generate-unified-source-bundles.rb:
+
 2018-11-12  Mark Lam  <mark.lam@apple.com>
 
         Add OOM detection to StringPrototype's substituteBackreferences().

diff --git a/Source/WTF/Scripts/generate-unified-source-bundles.rb b/Source/WTF/Scripts/generate-unified-source-bundles.rb
index 1fb3656..185bcc3 100644 (file)
--- a/Source/WTF/Scripts/generate-unified-source-bundles.rb
+++ b/Source/WTF/Scripts/generate-unified-source-bundles.rb
@@ -273,6 +273,7 @@ sourceListFiles.each_with_index {
             raise "malformed #if" unless line =~ /\A#if\s+(\S+)/
             inDisabledLines = !$featureFlags[$1]
         else
+            raise "malformed preprocessor directive: #{line}" if line =~ /^#/
             raise "duplicate line: #{line} in #{path}" if seen[line]
             seen[line] = true
             result << SourceFile.new(line, sourceFileIndex)

diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
index b174746..04c2db9 100644 (file)
--- a/Source/WebCore/ChangeLog
+++ b/Source/WebCore/ChangeLog
@@ -1,5 +1,21 @@
 2018-11-14  Keith Rollin  <krollin@apple.com>
 
+        Fix #end vs. #endif typo.
+        https://bugs.webkit.org/show_bug.cgi?id=191668
+        <rdar://problem/46081704>
+
+        Reviewed by Alexey Proskuryakov.
+
+        Source/WebCore/SourcesCocoa.txt had a #end that should have been a
+        #endif. Fix this, an add a check to generate-unified-source-bundles.rb
+        to detect similar typos.
+
+        No new tests -- no changed functionality.
+
+        * SourcesCocoa.txt:
+
+2018-11-14  Keith Rollin  <krollin@apple.com>
+
         Remove VideoFullscreenLayerManager.mm from WebCore/SourcesCocoa.txt
         https://bugs.webkit.org/show_bug.cgi?id=191667
         <rdar://problem/46081286>

diff --git a/Source/WebCore/SourcesCocoa.txt b/Source/WebCore/SourcesCocoa.txt
index 82bc59f..68c5566 100644 (file)
--- a/Source/WebCore/SourcesCocoa.txt
+++ b/Source/WebCore/SourcesCocoa.txt
@@ -632,7 +632,7 @@ platform/mediastream/libwebrtc/LibWebRTCProviderCocoa.cpp
     JSTouchEvent.cpp
     JSTouchList.cpp
 
-#end
+#endif
 
 #if ENABLE_IOS_GESTURE_EVENTS