Slave lost shouldn't be recognized as build failed.
authorossy@webkit.org <ossy@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 2 Jun 2010 20:41:45 +0000 (20:41 +0000)
committerossy@webkit.org <ossy@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 2 Jun 2010 20:41:45 +0000 (20:41 +0000)
https://bugs.webkit.org/show_bug.cgi?id=39282

Reviewed by Eric Seidel.

* Scripts/webkitpy/common/net/buildbot.py: Treat slave lost as green.
* Scripts/webkitpy/common/net/buildbot_unittest.py: Add unit test for slave lost.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebKitTools/ChangeLog
WebKitTools/Scripts/webkitpy/common/net/buildbot.py
WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py

index e7e8570..62c39dc 100644 (file)
@@ -1,3 +1,13 @@
+2010-06-02  Csaba Osztrogon√°c  <ossy@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        Slave lost shouldn't be recognized as build failed.
+        https://bugs.webkit.org/show_bug.cgi?id=39282
+
+        * Scripts/webkitpy/common/net/buildbot.py: Treat slave lost as green.
+        * Scripts/webkitpy/common/net/buildbot_unittest.py: Add unit test for slave lost.
+
 2010-06-01  Yael Aharon  <yael.aharon@nokia.com>
 
         Reviewed by Kenneth Rohde Christiansen.
index 6c6ed43..c849ef1 100644 (file)
@@ -333,7 +333,12 @@ class BuildBot(object):
             builder['built_revision'] = int(revision_string) \
                                         if not re.match('\D', revision_string) \
                                         else None
-            builder['is_green'] = not re.search('fail', cell.renderContents())
+
+            # FIXME: We treat slave lost as green even though it is not to
+            # work around the Qts bot being on a broken internet connection.
+            # The real fix is https://bugs.webkit.org/show_bug.cgi?id=37099
+            builder['is_green'] = not re.search('fail', cell.renderContents()) or \
+                                  not not re.search('lost', cell.renderContents())
 
             status_link_regexp = r"builders/(?P<builder_name>.*)/builds/(?P<build_number>\d+)"
             link_match = re.match(status_link_regexp, status_link['href'])
index 5e04745..5384321 100644 (file)
@@ -169,6 +169,10 @@ class BuildBotTest(unittest.TestCase):
     <td class="box"><a href="builders/Qt%20Linux%20Release">Qt Linux Release</a></td>
       <td align="center" class="LastBuild box failure"><a href="builders/Qt%20Linux%20Release/builds/654">47383</a><br />failed<br />compile-webkit</td>
       <td align="center" class="Activity idle">idle<br />3 pending</td>
+    <tr>
+    <td class="box"><a href="builders/Qt%20Windows%2032-bit%20Debug">Qt Windows 32-bit Debug</a></td>
+      <td align="center" class="LastBuild box failure"><a href="builders/Qt%20Windows%2032-bit%20Debug/builds/2090">60563</a><br />failed<br />failed<br />slave<br />lost</td>
+      <td align="center" class="Activity building">building<br />ETA in<br />~ 5 mins<br />at 08:25</td>
     </table>
 '''
     _expected_example_one_box_parsings = [
@@ -196,6 +200,14 @@ class BuildBotTest(unittest.TestCase):
             'activity': 'idle',
             'pending_builds': 3,
         },
+        {
+            'is_green': True,
+            'build_number' : 2090,
+            'name': u'Qt Windows 32-bit Debug',
+            'built_revision': 60563,
+            'activity': 'building',
+            'pending_builds': 0,
+        },
     ]
 
     def test_status_parsing(self):