Web Inspector: Uncaught exception creating TimelineRecord alternate subtitles
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 10 Nov 2015 00:30:29 +0000 (00:30 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 10 Nov 2015 00:30:29 +0000 (00:30 +0000)
https://bugs.webkit.org/show_bug.cgi?id=151046

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-11-09
Reviewed by Brian Burg.

* UserInterface/Views/TimelineRecordTreeElement.js:
(WebInspector.TimelineRecordTreeElement):
We just need to create an element, it does not need to be
a child of subtitle, as it gets appended to the right
place later on.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@192188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/UserInterface/Views/TimelineRecordTreeElement.js

index 4662b14..f5cd817 100644 (file)
@@ -1,3 +1,16 @@
+2015-11-09  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Uncaught exception creating TimelineRecord alternate subtitles
+        https://bugs.webkit.org/show_bug.cgi?id=151046
+
+        Reviewed by Brian Burg.
+
+        * UserInterface/Views/TimelineRecordTreeElement.js:
+        (WebInspector.TimelineRecordTreeElement):
+        We just need to create an element, it does not need to be
+        a child of subtitle, as it gets appended to the right
+        place later on.
+
 2015-11-09  Nikita Vasilyev  <nvasilyev@apple.com>
 
         Web Inspector: [Regression] [Mavericks] Top border of selected tab matches the background when Web Inspector is undocked
index 15b84b5..a1880aa 100644 (file)
@@ -94,7 +94,7 @@ WebInspector.TimelineRecordTreeElement = class TimelineRecordTreeElement extends
             case WebInspector.ScriptTimelineRecord.EventType.TimerInstalled:
                 if (includeDetailsInMainTitle) {
                     let timeoutString =  Number.secondsToString(timelineRecord.details.timeout / 1000);
-                    alternateSubtitle = subtitle.appendChild(document.createElement("span"));
+                    alternateSubtitle = document.createElement("span");
                     alternateSubtitle.classList.add("alternate-subtitle");
                     if (timelineRecord.details.repeating)
                         alternateSubtitle.textContent = WebInspector.UIString("%s interval").format(timeoutString);