Unreviewed. Fix typo of |ComputedStyleExtractor::valueForPropertyInStyle|
authorjh718.park@samsung.com <jh718.park@samsung.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 31 May 2019 12:29:19 +0000 (12:29 +0000)
committerjh718.park@samsung.com <jh718.park@samsung.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 31 May 2019 12:29:19 +0000 (12:29 +0000)
to follow camel case function naming style.

No behavioral changes.

Patch by Joonghun Park <jh718.park@samsung.com> on 2019-05-31

* animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::getKeyframes):
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
(WebCore::ComputedStyleExtractor::valueForPropertyinStyle): Deleted.
* css/CSSComputedStyleDeclaration.h:
* rendering/style/RenderStyle.cpp:
(WebCore::changedCustomPaintWatchedProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/animation/KeyframeEffect.cpp
Source/WebCore/css/CSSComputedStyleDeclaration.cpp
Source/WebCore/css/CSSComputedStyleDeclaration.h
Source/WebCore/rendering/style/RenderStyle.cpp

index f13cac0..203d12e 100644 (file)
@@ -1,3 +1,20 @@
+2019-05-31  Joonghun Park  <jh718.park@samsung.com>
+
+        Unreviewed. Fix typo of |ComputedStyleExtractor::valueForPropertyInStyle|
+        to follow camel case function naming style.
+
+        No behavioral changes.
+
+        * animation/KeyframeEffect.cpp:
+        (WebCore::KeyframeEffect::getKeyframes):
+        * css/CSSComputedStyleDeclaration.cpp:
+        (WebCore::ComputedStyleExtractor::propertyValue):
+        (WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
+        (WebCore::ComputedStyleExtractor::valueForPropertyinStyle): Deleted.
+        * css/CSSComputedStyleDeclaration.h:
+        * rendering/style/RenderStyle.cpp:
+        (WebCore::changedCustomPaintWatchedProperty):
+
 2019-05-31  Ali Juma  <ajuma@chromium.org>
 
         REGRESSION (r245396): Page load time performance regression
index 43571ae..3f1356f 100644 (file)
@@ -601,7 +601,7 @@ Vector<Strong<JSObject>> KeyframeEffect::getKeyframes(ExecState& state)
                 auto propertyName = CSSPropertyIDToIDLAttributeName(cssPropertyId);
                 // 2. Let IDL value be the result of serializing the property value of declaration by passing declaration to the algorithm to serialize a CSS value.
                 String idlValue = "";
-                if (auto cssValue = computedStyleExtractor.valueForPropertyinStyle(style, cssPropertyId))
+                if (auto cssValue = computedStyleExtractor.valueForPropertyInStyle(style, cssPropertyId))
                     idlValue = cssValue->cssText();
                 // 3. Let value be the result of converting IDL value to an ECMAScript String value.
                 auto value = toJS<IDLDOMString>(state, idlValue);
index 93caf60..d9ccb4b 100644 (file)
@@ -2775,10 +2775,10 @@ RefPtr<CSSValue> ComputedStyleExtractor::propertyValue(CSSPropertyID propertyID,
     if (!style)
         return nullptr;
 
-    return valueForPropertyinStyle(*style, propertyID, renderer);
+    return valueForPropertyInStyle(*style, propertyID, renderer);
 }
 
-RefPtr<CSSValue> ComputedStyleExtractor::valueForPropertyinStyle(const RenderStyle& style, CSSPropertyID propertyID, RenderElement* renderer)
+RefPtr<CSSValue> ComputedStyleExtractor::valueForPropertyInStyle(const RenderStyle& style, CSSPropertyID propertyID, RenderElement* renderer)
 {
     auto& cssValuePool = CSSValuePool::singleton();
     propertyID = CSSProperty::resolveDirectionAwareProperty(propertyID, style.direction(), style.writingMode());
index 6aae987..a784564 100644 (file)
@@ -57,7 +57,7 @@ public:
     ComputedStyleExtractor(Element*, bool allowVisitedStyle = false, PseudoId = PseudoId::None);
 
     RefPtr<CSSValue> propertyValue(CSSPropertyID, EUpdateLayout = UpdateLayout);
-    RefPtr<CSSValue> valueForPropertyinStyle(const RenderStyle&, CSSPropertyID, RenderElement* = nullptr);
+    RefPtr<CSSValue> valueForPropertyInStyle(const RenderStyle&, CSSPropertyID, RenderElement* = nullptr);
     String customPropertyText(const String& propertyName);
     RefPtr<CSSValue> customPropertyValue(const String& propertyName);
 
index 2e2d658..f2646ef 100644 (file)
@@ -1015,8 +1015,8 @@ inline static bool changedCustomPaintWatchedProperty(const RenderStyle& a, const
                     CSSPropertyID propertyID = cssPropertyID(name);
                     if (!propertyID)
                         continue;
-                    valueA = extractor.valueForPropertyinStyle(a, propertyID);
-                    valueB = extractor.valueForPropertyinStyle(b, propertyID);
+                    valueA = extractor.valueForPropertyInStyle(a, propertyID);
+                    valueB = extractor.valueForPropertyInStyle(b, propertyID);
                 }
 
                 if ((valueA && !valueB) || (!valueA && valueB))