Remove action menu web preference
authorbdakin@apple.com <bdakin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 22 Oct 2014 19:13:30 +0000 (19:13 +0000)
committerbdakin@apple.com <bdakin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 22 Oct 2014 19:13:30 +0000 (19:13 +0000)
https://bugs.webkit.org/show_bug.cgi?id=137975

Reviewed by Tim Horton.

* Shared/WebPreferencesDefinitions.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetActionMenuSupportEnabled): Deleted.
(WKPreferencesGetActionMenuSupportEnabled): Deleted.
* UIProcess/API/C/WKPreferencesRefPrivate.h:
* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:context:configuration:webView:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@175061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit2/ChangeLog
Source/WebKit2/Shared/WebPreferencesDefinitions.h
Source/WebKit2/UIProcess/API/C/WKPreferences.cpp
Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h
Source/WebKit2/UIProcess/API/mac/WKView.mm

index 266c7bd..058378c 100644 (file)
@@ -1,3 +1,18 @@
+2014-10-22  Beth Dakin  <bdakin@apple.com>
+
+        Remove action menu web preference
+        https://bugs.webkit.org/show_bug.cgi?id=137975
+
+        Reviewed by Tim Horton.
+
+        * Shared/WebPreferencesDefinitions.h:
+        * UIProcess/API/C/WKPreferences.cpp:
+        (WKPreferencesSetActionMenuSupportEnabled): Deleted.
+        (WKPreferencesGetActionMenuSupportEnabled): Deleted.
+        * UIProcess/API/C/WKPreferencesRefPrivate.h:
+        * UIProcess/API/mac/WKView.mm:
+        (-[WKView initWithFrame:context:configuration:webView:]):
+
 2014-10-22  Chris Dumez  <cdumez@apple.com>
 
         [Mac][WK2] Fix applicationIsSafari() detection
index cc3b7a3..98fcbdb 100644 (file)
     macro(ShouldConvertPositionStyleOnCopy, shouldConvertPositionStyleOnCopy, Bool, bool, false) \
     macro(Standalone, standalone, Bool, bool, false) \
     macro(TelephoneNumberParsingEnabled, telephoneNumberParsingEnabled, Bool, bool, false) \
-    macro(ActionMenuSupportEnabled, actionMenuSupportEnabled, Bool, bool, false) \
     macro(AlwaysUseBaselineOfPrimaryFont, alwaysUseBaselineOfPrimaryFont, Bool, bool, false) \
     macro(AllowMultiElementImplicitSubmission, allowMultiElementImplicitSubmission, Bool, bool, false) \
     macro(AlwaysUseAcceleratedOverflowScroll, alwaysUseAcceleratedOverflowScroll, Bool, bool, false) \
index b032da5..3e55230 100644 (file)
@@ -1236,16 +1236,6 @@ bool WKPreferencesGetTelephoneNumberParsingEnabled(WKPreferencesRef preferencesR
     return toImpl(preferencesRef)->telephoneNumberParsingEnabled();
 }
 
-void WKPreferencesSetActionMenuSupportEnabled(WKPreferencesRef preferencesRef, bool enabled)
-{
-    toImpl(preferencesRef)->setActionMenuSupportEnabled(enabled);
-}
-
-bool WKPreferencesGetActionMenuSupportEnabled(WKPreferencesRef preferencesRef)
-{
-    return toImpl(preferencesRef)->actionMenuSupportEnabled();
-}
-
 void WKPreferencesSetEnableInheritURIQueryComponent(WKPreferencesRef preferencesRef, bool enabled)
 {
     toImpl(preferencesRef)->setEnableInheritURIQueryComponent(enabled);
index 3b8d0ee..3af6eec 100644 (file)
@@ -315,10 +315,6 @@ WK_EXPORT void WKPreferencesSetTelephoneNumberParsingEnabled(WKPreferencesRef pr
 WK_EXPORT bool WKPreferencesGetTelephoneNumberParsingEnabled(WKPreferencesRef preferencesRef);
 
 // Default to false.
-WK_EXPORT void WKPreferencesSetActionMenuSupportEnabled(WKPreferencesRef, bool);
-WK_EXPORT bool WKPreferencesGetActionMenuSupportEnabled(WKPreferencesRef);
-
-// Default to false.
 WK_EXPORT void WKPreferencesSetEnableInheritURIQueryComponent(WKPreferencesRef preferencesRef, bool enabled);
 WK_EXPORT bool WKPreferencesGetEnableInheritURIQueryComponent(WKPreferencesRef preferencesRef);
 
index d4f303f..f367d86 100644 (file)
@@ -3537,7 +3537,7 @@ static NSString *pathWithUniqueFilenameForPath(NSString *path)
 
     [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(_applicationWillTerminate:) name:NSApplicationWillTerminateNotification object:NSApp];
 
-    if (_data->_page->preferences().actionMenuSupportEnabled() && [self respondsToSelector:@selector(setActionMenu:)]) {
+    if ([self respondsToSelector:@selector(setActionMenu:)]) {
         RetainPtr<NSMenu> actionMenu = adoptNS([[NSMenu alloc] init]);
         [self setActionMenu:actionMenu.get()];
     }