Web Inspector: Uncaught Exception: TypeError: this._computedStyleSection.focus is...
authornvasilyev@apple.com <nvasilyev@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 3 Apr 2019 18:05:03 +0000 (18:05 +0000)
committernvasilyev@apple.com <nvasilyev@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 3 Apr 2019 18:05:03 +0000 (18:05 +0000)
https://bugs.webkit.org/show_bug.cgi?id=192108
<rdar://problem/46685392>

Reviewed by Devin Rousso.

This patch fixes the uncaught exception. Tabbing to and from "Properties" section continues
working the same way as before the patch.

* UserInterface/Views/ComputedStyleDetailsPanel.js:
(WI.ComputedStyleDetailsPanel.prototype.focusFirstSection): Deleted.
(WI.ComputedStyleDetailsPanel.prototype.focusLastSection): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.js

index 9fb60f5..966183e 100644 (file)
@@ -1,3 +1,18 @@
+2019-04-03  Nikita Vasilyev  <nvasilyev@apple.com>
+
+        Web Inspector: Uncaught Exception: TypeError: this._computedStyleSection.focus is not a function. (In 'this._computedStyleSection.focus()', 'this._computedStyleSection.focus' is undefined)
+        https://bugs.webkit.org/show_bug.cgi?id=192108
+        <rdar://problem/46685392>
+
+        Reviewed by Devin Rousso.
+
+        This patch fixes the uncaught exception. Tabbing to and from "Properties" section continues
+        working the same way as before the patch.
+
+        * UserInterface/Views/ComputedStyleDetailsPanel.js:
+        (WI.ComputedStyleDetailsPanel.prototype.focusFirstSection): Deleted.
+        (WI.ComputedStyleDetailsPanel.prototype.focusLastSection): Deleted.
+
 2019-04-02  Devin Rousso  <drousso@apple.com>
 
         Web Inspector: Elements: DOM breakpoint icon should stroke when hovering selection area
index 1f31165..21c3d2a 100644 (file)
@@ -78,16 +78,6 @@ WI.ComputedStyleDetailsPanel = class ComputedStyleDetailsPanel extends WI.StyleD
             this._delegate.computedStyleDetailsPanelShowProperty(property);
     }
 
-    focusFirstSection()
-    {
-        this._computedStyleSection.focus();
-    }
-
-    focusLastSection()
-    {
-        this._variablesTextEditor.focus();
-    }
-
     // Protected
 
     initialLayout()