Web Inspector: "Copy as HTML" appears twice when showing a context menu for a logged...
authordrousso@apple.com <drousso@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 1 Apr 2019 22:35:50 +0000 (22:35 +0000)
committerdrousso@apple.com <drousso@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 1 Apr 2019 22:35:50 +0000 (22:35 +0000)
https://bugs.webkit.org/show_bug.cgi?id=196271
<rdar://problem/49290676>

Reviewed by Joseph Pecoraro.

* UserInterface/Views/ObjectTreeBaseTreeElement.js:
(WI.ObjectTreeBaseTreeElement.prototype._appendMenusItemsForObject):

* Localizations/en.lproj/localizedStrings.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
Source/WebInspectorUI/UserInterface/Views/ObjectTreeBaseTreeElement.js

index 56c6ef8..33f046e 100644 (file)
@@ -1,5 +1,18 @@
 2019-04-01  Devin Rousso  <drousso@apple.com>
 
+        Web Inspector: "Copy as HTML" appears twice when showing a context menu for a logged node
+        https://bugs.webkit.org/show_bug.cgi?id=196271
+        <rdar://problem/49290676>
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Views/ObjectTreeBaseTreeElement.js:
+        (WI.ObjectTreeBaseTreeElement.prototype._appendMenusItemsForObject):
+
+        * Localizations/en.lproj/localizedStrings.js:
+
+2019-04-01  Devin Rousso  <drousso@apple.com>
+
         Web Inspector: Debugger: breakpoints don't populate in inspector2 on first load
         https://bugs.webkit.org/show_bug.cgi?id=196063
         <rdar://problem/49097787>
index 8815ac4..edfdce7 100644 (file)
@@ -283,7 +283,6 @@ localizedStrings["Copy Path to Property"] = "Copy Path to Property";
 localizedStrings["Copy Row"] = "Copy Row";
 localizedStrings["Copy Selected"] = "Copy Selected";
 localizedStrings["Copy Table"] = "Copy Table";
-localizedStrings["Copy as HTML"] = "Copy as HTML";
 localizedStrings["Copy as cURL"] = "Copy as cURL";
 localizedStrings["Could not fetch properties. Object may no longer exist."] = "Could not fetch properties. Object may no longer exist.";
 localizedStrings["Count"] = "Count";
index 7f91f4c..c36d44f 100644 (file)
@@ -242,27 +242,5 @@ WI.ObjectTreeBaseTreeElement = class ObjectTreeBaseTreeElement extends WI.Genera
             }
             return;
         }
-
-        if (resolvedValue.subtype === "node") {
-            contextMenu.appendItem(WI.UIString("Copy as HTML"), function() {
-                resolvedValue.pushNodeToFrontend(function(nodeId) {
-                    WI.domManager.nodeForId(nodeId).copyNode();
-                });
-            });
-
-            contextMenu.appendItem(WI.UIString("Scroll Into View"), function() {
-                function scrollIntoView() { this.scrollIntoViewIfNeeded(true); }
-                resolvedValue.callFunction(scrollIntoView, undefined, false, function() {});
-            });
-
-            contextMenu.appendSeparator();
-
-            contextMenu.appendItem(WI.UIString("Reveal in DOM Tree"), function() {
-                resolvedValue.pushNodeToFrontend(function(nodeId) {
-                    WI.domManager.inspectElement(nodeId);
-                });
-            });
-            return;
-        }
     }
 };