Reviewed by Mark (age 21).
authorweinig <weinig@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 22 Feb 2007 15:34:00 +0000 (15:34 +0000)
committerweinig <weinig@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 22 Feb 2007 15:34:00 +0000 (15:34 +0000)
        - fix http://bugs.webkit.org/show_bug.cgi?id=12805
          REGRESSION: suggestion popup has a disabled scroll bar

        * WebView/WebHTMLView.mm:
        (-[WebTextCompleteController _buildUI]): Uncommented the call to the NSWindow
        SPI that forces the scroll bar to look active. Also replaced a call to
        the deprecated NSTableView method setAutoresizesAllColumnsToFit: with
        the new method setColumnAutoresizingStyle: to eliminate console spew.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebKit/ChangeLog
WebKit/WebView/WebHTMLView.mm

index 2f199af..c172e75 100644 (file)
@@ -1,3 +1,16 @@
+2007-02-22  Mitz Pettel  <mitz@webkit.org>
+
+        Reviewed by Mark (age 21).
+
+        - fix http://bugs.webkit.org/show_bug.cgi?id=12805
+          REGRESSION: suggestion popup has a disabled scroll bar
+
+        * WebView/WebHTMLView.mm:
+        (-[WebTextCompleteController _buildUI]): Uncommented the call to the NSWindow
+        SPI that forces the scroll bar to look active. Also replaced a call to
+        the deprecated NSTableView method setAutoresizesAllColumnsToFit: with
+        the new method setColumnAutoresizingStyle: to eliminate console spew.
+
 2007-02-20  Beth Dakin  <bdakin@apple.com>
 
         Reviewed by Maciej.
index 93e4ccb..0bed84c 100644 (file)
@@ -134,6 +134,7 @@ void _NSResetKillRingOperationFlag(void);
 
 @interface NSWindow (AppKitSecretsIKnowAbout)
 - (id)_newFirstResponderAfterResigning;
+- (void)_setForceActiveControls:(BOOL)flag;
 @end
 
 @interface NSAttributedString (AppKitSecretsIKnowAbout)
@@ -5621,7 +5622,7 @@ static CGPoint coreGraphicsScreenPointForAppKitScreenPoint(NSPoint point)
     [_tableView setDrawsGrid:NO];
     [_tableView setCornerView:nil];
     [_tableView setHeaderView:nil];
-    [_tableView setAutoresizesAllColumnsToFit:YES];
+    [_tableView setColumnAutoresizingStyle:NSTableViewUniformColumnAutoresizingStyle];
     [_tableView setDelegate:self];
     [_tableView setDataSource:self];
     [_tableView setTarget:self];
@@ -5640,7 +5641,7 @@ static CGPoint coreGraphicsScreenPointForAppKitScreenPoint(NSPoint point)
     [scrollView release];
     [_popupWindow setHasShadow:YES];
     [_popupWindow setOneShot:YES];
-    //[_popupWindow _setForceActiveControls:YES];   // AK secret - no known problem from leaving this out
+    [_popupWindow _setForceActiveControls:YES];
     [_popupWindow setReleasedWhenClosed:NO];
 }