Reviewed by Sam Weinig.
authorggaren@apple.com <ggaren@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 11 Sep 2014 19:12:48 +0000 (19:12 +0000)
committerggaren@apple.com <ggaren@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 11 Sep 2014 19:12:48 +0000 (19:12 +0000)
Renamed log => retire for clarity.

* bmalloc/Allocator.cpp:
(bmalloc::Allocator::scavenge):
(bmalloc::Allocator::retire):
(bmalloc::Allocator::allocateMedium):
(bmalloc::Allocator::allocateSlowCase):
(bmalloc::Allocator::log): Deleted.
* bmalloc/Allocator.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/bmalloc/ChangeLog
Source/bmalloc/bmalloc/Allocator.cpp
Source/bmalloc/bmalloc/Allocator.h

index 226b086..956e91f 100644 (file)
@@ -1,5 +1,19 @@
 2014-09-11  Geoffrey Garen  <ggaren@apple.com>
 
+        Reviewed by Sam Weinig.
+
+        Renamed log => retire for clarity.
+
+        * bmalloc/Allocator.cpp:
+        (bmalloc::Allocator::scavenge):
+        (bmalloc::Allocator::retire):
+        (bmalloc::Allocator::allocateMedium):
+        (bmalloc::Allocator::allocateSlowCase):
+        (bmalloc::Allocator::log): Deleted.
+        * bmalloc/Allocator.h:
+
+2014-09-11  Geoffrey Garen  <ggaren@apple.com>
+
         bmalloc: eager scavenge leaves behind a bogus allocator
         https://bugs.webkit.org/show_bug.cgi?id=136743
 
index 6d44fa1..85b7f7e 100644 (file)
@@ -57,17 +57,17 @@ Allocator::~Allocator()
 void Allocator::scavenge()
 {
     for (auto& allocator : m_smallAllocators) {
-        log(allocator);
+        retire(allocator);
         allocator.clear();
     }
     processSmallAllocatorLog();
 
-    log(m_mediumAllocator);
+    retire(m_mediumAllocator);
     m_mediumAllocator.clear();
     processMediumAllocatorLog();
 }
 
-void Allocator::log(SmallAllocator& allocator)
+void Allocator::retire(SmallAllocator& allocator)
 {
     if (m_smallAllocatorLog.size() == m_smallAllocatorLog.capacity())
         processSmallAllocatorLog();
@@ -90,7 +90,7 @@ void Allocator::processSmallAllocatorLog()
     m_smallAllocatorLog.clear();
 }
 
-void Allocator::log(MediumAllocator& allocator)
+void Allocator::retire(MediumAllocator& allocator)
 {
     if (m_mediumAllocatorLog.size() == m_mediumAllocatorLog.capacity())
         processMediumAllocatorLog();
@@ -136,7 +136,7 @@ void* Allocator::allocateMedium(size_t size)
     if (allocator.allocate(size, object))
         return object;
 
-    log(allocator);
+    retire(allocator);
     allocator.refill(m_deallocator.allocateMediumLine());
     return allocator.allocate(size);
 }
@@ -150,7 +150,7 @@ IF_DEBUG(
     if (size <= smallMax) {
         size_t smallSizeClass = smallSizeClassFor(size);
         SmallAllocator& allocator = m_smallAllocators[smallSizeClass];
-        log(allocator);
+        retire(allocator);
         allocator.refill(m_deallocator.allocateSmallLine(smallSizeClass));
         return allocator.allocate();
     }
index a50e41a..5f11170 100644 (file)
@@ -56,8 +56,8 @@ private:
     void* allocateLarge(size_t);
     void* allocateXLarge(size_t);
     
-    void log(SmallAllocator&);
-    void log(MediumAllocator&);
+    void retire(SmallAllocator&);
+    void retire(MediumAllocator&);
 
     void processSmallAllocatorLog();
     void processMediumAllocatorLog();