Move HTML Interactive Form Validation behind an experimental flag
authorcdumez@apple.com <cdumez@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 19 Oct 2016 20:29:02 +0000 (20:29 +0000)
committercdumez@apple.com <cdumez@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 19 Oct 2016 20:29:02 +0000 (20:29 +0000)
https://bugs.webkit.org/show_bug.cgi?id=163673

Reviewed by Daniel Bates.

Source/WebKit/mac:

Re-disable HTML Interactive Form Validation by default on Mac WK1.

* WebView/WebViewData.mm:
(-[WebViewPrivate init]):

Source/WebKit2:

Move HTML Interactive Form Validation behind an experimental feature flag
and disable by default until by have a better UI.

* Shared/WebPreferencesDefinitions.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@207562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/mac/ChangeLog
Source/WebKit/mac/WebView/WebViewData.mm
Source/WebKit2/ChangeLog
Source/WebKit2/Shared/WebPreferencesDefinitions.h
Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp

index d78db2c..04363b0 100644 (file)
@@ -1,3 +1,15 @@
+2016-10-19  Chris Dumez  <cdumez@apple.com>
+
+        Move HTML Interactive Form Validation behind an experimental flag
+        https://bugs.webkit.org/show_bug.cgi?id=163673
+
+        Reviewed by Daniel Bates.
+
+        Re-disable HTML Interactive Form Validation by default on Mac WK1.
+
+        * WebView/WebViewData.mm:
+        (-[WebViewPrivate init]):
+
 2016-10-19  Myles C. Maxfield  <mmaxfield@apple.com>
 
         [macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9
index 6e7b973..5e7c8d7 100644 (file)
@@ -143,7 +143,7 @@ WebViewLayerFlushScheduler::WebViewLayerFlushScheduler(LayerFlushController* flu
     zoomMultiplier = 1;
     zoomsTextOnly = NO;
 
-    interactiveFormValidationEnabled = YES;
+    interactiveFormValidationEnabled = NO;
     // The default value should be synchronized with WebCore/page/Settings.cpp.
     validationMessageTimerMagnification = 50;
 
index 82657b1..0e53a6c 100644 (file)
@@ -1,3 +1,17 @@
+2016-10-19  Chris Dumez  <cdumez@apple.com>
+
+        Move HTML Interactive Form Validation behind an experimental flag
+        https://bugs.webkit.org/show_bug.cgi?id=163673
+
+        Reviewed by Daniel Bates.
+
+        Move HTML Interactive Form Validation behind an experimental feature flag
+        and disable by default until by have a better UI.
+
+        * Shared/WebPreferencesDefinitions.h:
+        * WebProcess/InjectedBundle/InjectedBundle.cpp:
+        (WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
+
 2016-10-19  Damian Kaleta  <dkaleta@apple.com>
 
         https://bugs.webkit.org/show_bug.cgi?id=163292
index 8d07d29..05394b6 100644 (file)
     macro(AsynchronousPluginInitializationEnabledForAllPlugins, asynchronousPluginInitializationEnabledForAllPlugins, Bool, bool, false, "", "") \
     macro(ArtificialPluginInitializationDelayEnabled, artificialPluginInitializationDelayEnabled, Bool, bool, false, "", "") \
     macro(TabToLinksEnabled, tabToLinksEnabled, Bool, bool, false, "", "") \
-    macro(InteractiveFormValidationEnabled, interactiveFormValidationEnabled, Bool, bool, true, "", "") \
     macro(ScrollingPerformanceLoggingEnabled, scrollingPerformanceLoggingEnabled, Bool, bool, false, "", "") \
     macro(ScrollAnimatorEnabled, scrollAnimatorEnabled, Bool, bool, DEFAULT_WEBKIT_SCROLL_ANIMATOR_ENABLED, "", "") \
     macro(ForceUpdateScrollbarsOnMainThreadForPerformanceTesting, forceUpdateScrollbarsOnMainThreadForPerformanceTesting, Bool, bool, false, "", "") \
     macro(CSSGridLayoutEnabled, cssGridLayoutEnabled, Bool, bool, false, "CSS Grid", "CSS Grid Layout Module support") \
     macro(SpringTimingFunctionEnabled, springTimingFunctionEnabled, Bool, bool, true, "CSS Spring Animations", "CSS Spring Animation prototype") \
     macro(CustomElementsEnabled, customElementsEnabled, Bool, bool, true, "Custom Elements", "HTML Custom Elements prototype") \
+    macro(InteractiveFormValidationEnabled, interactiveFormValidationEnabled, Bool, bool, false, "HTML Interactive Form Validation", "HTML interactive form validation prototype") \
     macro(GamepadsEnabled, gamepadsEnabled, Bool, bool, true, "Gamepads", "Web Gamepad API support") \
     macro(ModernMediaControlsEnabled, modernMediaControlsEnabled, Bool, bool, false, "Modern Media Controls", "Use modern media controls look") \
     macro(VariationFontsEnabled, variationFontsEnabled, Bool, bool, true, "Variation Fonts", "Enable variation fonts") \
index b10a871..8154cc5 100644 (file)
@@ -207,6 +207,9 @@ void InjectedBundle::overrideBoolPreferenceForTestRunner(WebPageGroupProxy* page
         RuntimeEnabledFeatures::sharedFeatures().setCustomElementsEnabled(enabled);
 #endif
 
+    if (preference == "WebKitInteractiveFormValidationEnabled")
+        RuntimeEnabledFeatures::sharedFeatures().setInteractiveFormValidationEnabled(enabled);
+
 #if ENABLE(WEBGL2)
     if (preference == "WebKitWebGL2Enabled")
         RuntimeEnabledFeatures::sharedFeatures().setWebGL2Enabled(enabled);