2011-04-17 Joseph Pecoraro <joepeck@webkit.org>
authorjoepeck@webkit.org <joepeck@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 17 Apr 2011 21:09:12 +0000 (21:09 +0000)
committerjoepeck@webkit.org <joepeck@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 17 Apr 2011 21:09:12 +0000 (21:09 +0000)
        Reviewed by Dan Bernstein.

        Assign to self in WebInspectorWindowController constructors
        https://bugs.webkit.org/show_bug.cgi?id=58749

        * WebCoreSupport/WebInspectorClient.mm:
        (-[WebInspectorWindowController init]):
        (-[WebInspectorWindowController initWithInspectedWebView:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/mac/ChangeLog
Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm

index ad9d1d9..032f85f 100644 (file)
@@ -1,5 +1,16 @@
 2011-04-17  Joseph Pecoraro  <joepeck@webkit.org>
 
+        Reviewed by Dan Bernstein.
+
+        Assign to self in WebInspectorWindowController constructors
+        https://bugs.webkit.org/show_bug.cgi?id=58749
+
+        * WebCoreSupport/WebInspectorClient.mm:
+        (-[WebInspectorWindowController init]):
+        (-[WebInspectorWindowController initWithInspectedWebView:]):
+
+2011-04-17  Joseph Pecoraro  <joepeck@webkit.org>
+
         Reviewed by Timothy Hatcher.
 
         Move WebNodeHighlighter into its own file
index 673a2fe..e701495 100644 (file)
@@ -216,7 +216,7 @@ void WebInspectorFrontendClient::updateWindowTitle() const
 @implementation WebInspectorWindowController
 - (id)init
 {
-    if (![super initWithWindow:nil])
+    if (!(self = [super initWithWindow:nil]))
         return nil;
 
     // Keep preferences separate from the rest of the client, making sure we are using expected preference values.
@@ -260,10 +260,10 @@ void WebInspectorFrontendClient::updateWindowTitle() const
 
 - (id)initWithInspectedWebView:(WebView *)webView
 {
-    if (![self init])
+    if (!(self = [self init]))
         return nil;
 
-    // Don't retain to avoid a circular reference
+    // Don't retain to avoid a circular reference.
     _inspectedWebView = webView;
     return self;
 }