Web Inspector: Remove single quote characters from Web Inspector JavaScript files
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 24 Feb 2014 17:05:33 +0000 (17:05 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 24 Feb 2014 17:05:33 +0000 (17:05 +0000)
https://bugs.webkit.org/show_bug.cgi?id=129253

Patch by Diego Pino Garcia <dpino@igalia.com> on 2014-02-24
Reviewed by Timothy Hatcher.

* UserInterface/Base/Main.js:
(WebInspector.openURL):
* UserInterface/Views/CookieStorageContentView.js:
(WebInspector.cookieDomainMatchesResourceDomain):
* UserInterface/Views/DOMTreeElement.js:
(WebInspector.DOMTreeElement.prototype._insertInLastAttributePosition):
(WebInspector.DOMTreeElement.prototype._startEditingTagName.editingComitted):
(WebInspector.DOMTreeElement.prototype._startEditingTagName.editingCancelled):
(WebInspector.DOMTreeElement.prototype._startEditingTagName):
* UserInterface/Views/DOMTreeOutline.js:
(WebInspector.DOMTreeOutline.prototype._ondragover):
* UserInterface/Views/DataGrid.js:
(WebInspector.DataGrid.prototype.addPlaceholderNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@164588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/UserInterface/Base/Main.js
Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js
Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js
Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js
Source/WebInspectorUI/UserInterface/Views/DataGrid.js

index c846557..8f7c8da 100644 (file)
@@ -1,3 +1,24 @@
+2014-02-24  Diego Pino Garcia  <dpino@igalia.com>
+
+        Web Inspector: Remove single quote characters from Web Inspector JavaScript files
+        https://bugs.webkit.org/show_bug.cgi?id=129253
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Base/Main.js:
+        (WebInspector.openURL):
+        * UserInterface/Views/CookieStorageContentView.js:
+        (WebInspector.cookieDomainMatchesResourceDomain):
+        * UserInterface/Views/DOMTreeElement.js:
+        (WebInspector.DOMTreeElement.prototype._insertInLastAttributePosition):
+        (WebInspector.DOMTreeElement.prototype._startEditingTagName.editingComitted):
+        (WebInspector.DOMTreeElement.prototype._startEditingTagName.editingCancelled):
+        (WebInspector.DOMTreeElement.prototype._startEditingTagName):
+        * UserInterface/Views/DOMTreeOutline.js:
+        (WebInspector.DOMTreeOutline.prototype._ondragover):
+        * UserInterface/Views/DataGrid.js:
+        (WebInspector.DataGrid.prototype.addPlaceholderNode):
+
 2014-02-23  Dan Bernstein  <mitz@apple.com>
 
         Removed -Wno-format-y2k from WARNING_CFLAGS
index ebb7065..09e32b3 100644 (file)
@@ -491,7 +491,7 @@ WebInspector.openURL = function(url, frame, alwaysOpenExternally, lineNumber)
 
         // The path of of the profile URL starts with a slash, remove it, so
         // we can get the actual title.
-        console.assert(profileTitle[0] === '/');
+        console.assert(profileTitle[0] === "/");
         profileTitle = profileTitle.substring(1);
 
         this.timelineSidebarPanel.showProfile(profileType, profileTitle);
index f378dd6..843e6c9 100644 (file)
@@ -251,7 +251,7 @@ WebInspector.cookieMatchesResourceURL = function(cookie, resourceURL)
 
 WebInspector.cookieDomainMatchesResourceDomain = function(cookieDomain, resourceDomain)
 {
-    if (cookieDomain.charAt(0) !== '.')
+    if (cookieDomain.charAt(0) !== ".")
         return resourceDomain === cookieDomain;
     return !!resourceDomain.match(new RegExp("^([^\\.]+\\.)?" + cookieDomain.substring(1).escapeForRegExp() + "$"), "i");
 }
index 07bd89e..37c063b 100644 (file)
@@ -536,10 +536,10 @@ WebInspector.DOMTreeElement.prototype = {
             tag.insertBefore(node, tag.lastChild);
         else {
             var nodeName = tag.textContent.match(/^<(.*?)>$/)[1];
-            tag.textContent = '';
-            tag.appendChild(document.createTextNode('<'+nodeName));
+            tag.textContent = "";
+            tag.appendChild(document.createTextNode("<"+nodeName));
             tag.appendChild(node);
-            tag.appendChild(document.createTextNode('>'));
+            tag.appendChild(document.createTextNode(">"));
         }
 
         this.updateSelection();
@@ -749,17 +749,17 @@ WebInspector.DOMTreeElement.prototype = {
 
         function editingComitted(element, newTagName)
         {
-            tagNameElement.removeEventListener('keyup', keyupListener, false);
+            tagNameElement.removeEventListener("keyup", keyupListener, false);
             this._tagNameEditingCommitted.apply(this, arguments);
         }
 
         function editingCancelled()
         {
-            tagNameElement.removeEventListener('keyup', keyupListener, false);
+            tagNameElement.removeEventListener("keyup", keyupListener, false);
             this._editingCancelled.apply(this, arguments);
         }
 
-        tagNameElement.addEventListener('keyup', keyupListener, false);
+        tagNameElement.addEventListener("keyup", keyupListener, false);
 
         var config = new WebInspector.EditingConfig(editingComitted.bind(this), editingCancelled.bind(this), tagName);
         this._editing = WebInspector.startEditing(tagNameElement, config);
index 17fa5f3..14751b9 100644 (file)
@@ -377,7 +377,7 @@ WebInspector.DOMTreeOutline.prototype = {
         treeElement.listItemElement.classList.add("elements-drag-over");
         this._dragOverTreeElement = treeElement;
         event.preventDefault();
-        event.dataTransfer.dropEffect = 'move';
+        event.dataTransfer.dropEffect = "move";
         return false;
     },
 
index 8278c23..b7c7997 100644 (file)
@@ -657,7 +657,7 @@ WebInspector.DataGrid.prototype = {
 
         var emptyData = {};
         for (var identifier of this.columns.keys())
-            emptyData[identifier] = '';
+            emptyData[identifier] = "";
         this.placeholderNode = new WebInspector.PlaceholderDataGridNode(emptyData);
         this.appendChild(this.placeholderNode);
     },
@@ -1108,7 +1108,7 @@ WebInspector.DataGrid.prototype = {
                 else {
                     var element = event.target.enclosingNodeOrSelfWithNodeName("td");
                     var columnIdentifier = element.__columnIdentifier;
-                    var columnTitle = this.dataGrid.columns.get(columnIdentifier).get('title');
+                    var columnTitle = this.dataGrid.columns.get(columnIdentifier).get("title");
                     contextMenu.appendItem(WebInspector.UIString("Edit “%s”").format(columnTitle), this._startEditing.bind(this, event.target));
                 }
             }