Web Inspector: UI fonts should pull from system fonts automatically to whatever degre...
authorjonowells@apple.com <jonowells@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 21 Jun 2014 14:55:48 +0000 (14:55 +0000)
committerjonowells@apple.com <jonowells@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 21 Jun 2014 14:55:48 +0000 (14:55 +0000)
https://bugs.webkit.org/show_bug.cgi?id=133966

Reviewed by Timothy Hatcher.

Updated font families to use -webkit-system-font, and set this on the body to be
inherited. Also made sure that popovers use Menlo as the default. Updated
autocompletions with system font names.

* UserInterface/Models/CSSKeywordCompletions.js: Updated completions with available system fonts.

* UserInterface/Controllers/CodeMirrorGradientEditingController.css:
* UserInterface/Views/Breakpoint.css:
* UserInterface/Views/ButtonNavigationItem.css:
* UserInterface/Views/ButtonToolbarItem.css:
* UserInterface/Views/CSSStyleDeclarationSection.css:
* UserInterface/Views/CSSStyleDeclarationTextEditor.css:
* UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
* UserInterface/Views/CodeMirrorOverrides.css:
* UserInterface/Views/DataGrid.css:
* UserInterface/Views/DebuggerDashboardView.css:
* UserInterface/Views/DetailsSection.css:
* UserInterface/Views/FindBanner.css:
* UserInterface/Views/GoToLineDialog.css:
* UserInterface/Views/HierarchicalPathComponent.css:
* UserInterface/Views/Main.css:
* UserInterface/Views/NavigationSidebarPanel.css:
* UserInterface/Views/ProbeSetDataGrid.css:
* UserInterface/Views/RulesStyleDetailsPanel.css:
* UserInterface/Views/ScopeBar.css:
* UserInterface/Views/SourceCodeTextEditor.css:
* UserInterface/Views/TimelineDataGrid.css:
* UserInterface/Views/TimelineRuler.css:
* UserInterface/Views/TimelineSidebarPanel.css:
Changes to fonts. Set default font stack to -webkit-system-font, sans-serif. Default size is
11px. Only changes to this default size or changes to the font (to Menlo, monospace usually) remain.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

25 files changed:
Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorGradientEditingController.css
Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js
Source/WebInspectorUI/UserInterface/Views/Breakpoint.css
Source/WebInspectorUI/UserInterface/Views/ButtonNavigationItem.css
Source/WebInspectorUI/UserInterface/Views/ButtonToolbarItem.css
Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.css
Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.css
Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.css
Source/WebInspectorUI/UserInterface/Views/CodeMirrorOverrides.css
Source/WebInspectorUI/UserInterface/Views/DataGrid.css
Source/WebInspectorUI/UserInterface/Views/DebuggerDashboardView.css
Source/WebInspectorUI/UserInterface/Views/DetailsSection.css
Source/WebInspectorUI/UserInterface/Views/FindBanner.css
Source/WebInspectorUI/UserInterface/Views/GoToLineDialog.css
Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.css
Source/WebInspectorUI/UserInterface/Views/Main.css
Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.css
Source/WebInspectorUI/UserInterface/Views/ProbeSetDataGrid.css
Source/WebInspectorUI/UserInterface/Views/RulesStyleDetailsPanel.css
Source/WebInspectorUI/UserInterface/Views/ScopeBar.css
Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.css
Source/WebInspectorUI/UserInterface/Views/TimelineDataGrid.css
Source/WebInspectorUI/UserInterface/Views/TimelineRuler.css
Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.css

index d9f6da3..757181b 100644 (file)
@@ -1,3 +1,42 @@
+2014-06-21  Jono Wells  <jonowells@apple.com>
+
+        Web Inspector: UI fonts should pull from system fonts automatically to whatever degree possible
+        https://bugs.webkit.org/show_bug.cgi?id=133966
+
+        Reviewed by Timothy Hatcher.
+
+        Updated font families to use -webkit-system-font, and set this on the body to be
+        inherited. Also made sure that popovers use Menlo as the default. Updated 
+        autocompletions with system font names.
+
+        * UserInterface/Models/CSSKeywordCompletions.js: Updated completions with available system fonts.
+
+        * UserInterface/Controllers/CodeMirrorGradientEditingController.css:
+        * UserInterface/Views/Breakpoint.css:
+        * UserInterface/Views/ButtonNavigationItem.css:
+        * UserInterface/Views/ButtonToolbarItem.css:
+        * UserInterface/Views/CSSStyleDeclarationSection.css:
+        * UserInterface/Views/CSSStyleDeclarationTextEditor.css:
+        * UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
+        * UserInterface/Views/CodeMirrorOverrides.css:
+        * UserInterface/Views/DataGrid.css:
+        * UserInterface/Views/DebuggerDashboardView.css:
+        * UserInterface/Views/DetailsSection.css:
+        * UserInterface/Views/FindBanner.css:
+        * UserInterface/Views/GoToLineDialog.css:
+        * UserInterface/Views/HierarchicalPathComponent.css:
+        * UserInterface/Views/Main.css:
+        * UserInterface/Views/NavigationSidebarPanel.css:
+        * UserInterface/Views/ProbeSetDataGrid.css:
+        * UserInterface/Views/RulesStyleDetailsPanel.css:
+        * UserInterface/Views/ScopeBar.css:
+        * UserInterface/Views/SourceCodeTextEditor.css:
+        * UserInterface/Views/TimelineDataGrid.css:
+        * UserInterface/Views/TimelineRuler.css:
+        * UserInterface/Views/TimelineSidebarPanel.css:
+        Changes to fonts. Set default font stack to -webkit-system-font, sans-serif. Default size is
+        11px. Only changes to this default size or changes to the font (to Menlo, monospace usually) remain.
+
 2014-06-21  Joseph Pecoraro  <pecoraro@apple.com>
 
         Web Inspector: Esc in quick console no longer toggles console drawer
index dc246cf..0882005 100644 (file)
@@ -26,8 +26,6 @@
 .gradient-editing-controller {
     width: 260px;
     height: 109px;
-
-    font-family: "Lucida Grande", Helvetica, sans-serif;
 }
 
 .gradient-editing-controller.edits-color {
index 25f10d1..23a1e03 100644 (file)
@@ -332,9 +332,9 @@ WebInspector.CSSKeywordCompletions._propertyKeywordMap = {
         "-webkit-control", "status-bar", "italic", "oblique", "small-caps", "normal", "bold", "bolder", "lighter",
         "100", "200", "300", "400", "500", "600", "700", "800", "900", "xx-small", "x-small", "small", "medium",
         "large", "x-large", "xx-large", "-webkit-xxx-large", "smaller", "larger", "serif", "sans-serif", "cursive",
-        "fantasy", "monospace", "-webkit-body", "-webkit-pictograph", "-webkit-system-font", "-apple-system-headline",
-        "-apple-system-body", "-apple-system-subheadline", "-apple-system-footnote", "-apple-system-caption1",
-        "-apple-system-caption2", "-apple-system-short-headline", "-apple-system-short-body",
+        "fantasy", "monospace", "-webkit-body", "-webkit-pictograph", "-webkit-system-font", "-apple-system-font",
+        "-apple-system-headline", "-apple-system-body", "-apple-system-subheadline", "-apple-system-footnote",
+        "-apple-system-caption1", "-apple-system-caption2", "-apple-system-short-headline", "-apple-system-short-body",
         "-apple-system-short-subheadline", "-apple-system-short-footnote", "-apple-system-short-caption1",
         "-apple-system-tall-body"
     ],
@@ -431,7 +431,11 @@ WebInspector.CSSKeywordCompletions._propertyKeywordMap = {
         "absolute", "fixed", "relative", "static", "-webkit-sticky"
     ],
     "font-family": [
-        "serif", "sans-serif", "cursive", "fantasy", "monospace", "-webkit-body", "-webkit-pictograph", "-webkit-system-font"
+        "serif", "sans-serif", "cursive", "fantasy", "monospace", "-webkit-body", "-webkit-pictograph",
+        "-webkit-system-font", "-apple-system-font", "-apple-system-headline", "-apple-system-body",
+        "-apple-system-subheadline", "-apple-system-footnote", "-apple-system-caption1", "-apple-system-caption2",
+        "-apple-system-short-headline", "-apple-system-short-body", "-apple-system-short-subheadline",
+        "-apple-system-short-footnote", "-apple-system-short-caption1", "-apple-system-tall-body"
     ],
     "text-overflow-mode": [
         "clip", "ellipsis"
index 909834a..fdce26a 100644 (file)
@@ -26,9 +26,6 @@
 .popover .edit-breakpoint-popover-content {
     width: 420px;
     padding: 5px 15px;
-    
-    font-family: "Lucida Grande", Helvetica, sans-serif;
-    font-size: 11px;
 }
 
 .popover .edit-breakpoint-popover-content.wide {
index 5ce1a2a..3999645 100644 (file)
@@ -32,8 +32,6 @@
     padding: 0 10px;
 
     text-shadow: rgba(255, 255, 255, 0.5) 0 1px 0;
-    font-family: "Lucida Grande", sans-serif;
-    font-size: 11px;
     line-height: 20px;
 
     -webkit-justify-content: center;
index 0e7a8f9..d62a189 100644 (file)
@@ -58,8 +58,6 @@
 }
 
 .toolbar .item.button > .label {
-    font-size: 11px;
-    font-family: Lucida Grande, sans-serif;
     text-align: center;
     text-shadow: rgba(255, 255, 255, 0.5) 0 1px 0;
     color: rgb(60, 60, 60);
index 434b1c2..5b36fb3 100644 (file)
@@ -136,10 +136,9 @@ div:not(.style-declaration-section) + .style-declaration-section,
 
 .style-declaration-section > .header > .origin {
     line-height: 10px;
-    font-family: "Lucida Grande", sans-serif;
 
     color: rgb(128, 128, 128);
-    
+
     word-wrap: break-word;
     white-space: nowrap;
 }
index 0fcd511..9efb65f 100644 (file)
@@ -37,7 +37,6 @@
 }
 
 .css-style-text-editor > .CodeMirror .CodeMirror-placeholder {
-    font-family: "Lucida Grande", sans-serif;
     color: rgb(128, 128, 128);
     padding: 0 5px 0 25px;
     text-indent: 0;
index df62c2e..9df882b 100644 (file)
@@ -42,9 +42,6 @@
 }
 
 .sidebar > .panel.details.css-style > .content > .pseudo-classes {
-    font-size: 11px;
-    font-family: "Lucida Grande", sans-serif;
-
     padding: 10px;
 
     display: -webkit-flex;
index d77dc9a..2bb7201 100644 (file)
@@ -78,6 +78,5 @@
 
     font-size: 9px;
     line-height: 13px;
-    font-family: "Lucida Grande", sans-serif;
     text-align: right;
 }
index 7172da6..39577c4 100644 (file)
@@ -43,7 +43,6 @@
     border-collapse: collapse;
     width: 100%;
     font-size: 10px;
-    font-family: Lucida Grande, sans-serif;
 }
 
 .data-grid .data-container {
index 932eab3..872a823 100644 (file)
@@ -28,8 +28,6 @@
     -webkit-justify-content: center;
     -webkit-align-items: center;
 
-    font-size: 11px;
-    font-family: Lucida Grande, sans-serif;
     text-align: center;
     text-shadow: rgba(255, 255, 255, 0.5) 0 1px 0;
     color: rgb(60, 60, 60);
index 00644f4..23c6005 100644 (file)
@@ -27,7 +27,6 @@
     margin-top: -1px;
     margin-bottom: -1px;
 
-    font-family: "Lucida Grande", sans-serif;
     font-size: 10px;
 }
 
 }
 
 .details-section > .content > .group > .row.empty.syntax-highlighted {
-    font-family: "Lucida Grande", sans-serif;
     font-size: 10px;
 }
 
index a9af9b9..6ad11d5 100644 (file)
@@ -26,9 +26,6 @@
 .find-banner {
     border-bottom: 1px solid rgb(153, 153, 153);
 
-    font-family: "Lucida Grande", sans-serif;
-    font-size: 11px;
-
     position: absolute;
     top: -22px;
     left: 0;
index 26352a2..67f2f0e 100644 (file)
@@ -52,7 +52,6 @@
     right: 36px;
     border: none;
     background-color: transparent;
-    font-family: "Lucida Grande", sans-serif;
     font-size: 20px;
     color: rgb(12, 12, 12);
     padding: 0 0 1px 5px;
index 42da679..79c2503 100644 (file)
@@ -73,8 +73,6 @@
     vertical-align: top;
 
     text-shadow: rgba(255, 255, 255, 0.5) 0 1px 0;
-    font-family: "Lucida Grande", sans-serif;
-    font-size: 11px;
     line-height: 20px;
     height: 20px;
 
index 0d33e32..7a53ad5 100644 (file)
@@ -31,6 +31,9 @@ body {
     display: -webkit-flex;
     -webkit-flex-direction: column;
 
+    font-family: -webkit-system-font, sans-serif;
+    font-size: 11px;
+
     position: absolute;
     top: 0;
     left: 0;
@@ -164,14 +167,13 @@ body.docked.right #navigation-sidebar.collapsed > .resizer {
 
     -webkit-justify-content: center;
     -webkit-align-items: center;
-    
+
     line-height: 20px;
     white-space: pre-wrap;
     text-align: center;
 
     font-size: 18px;
     font-weight: bold;
-    font-family: Lucida Grande, sans-serif;
 
     color: rgb(75%, 75%, 75%);
     background-color: white;
index ac3354e..7ace21a 100644 (file)
@@ -82,7 +82,6 @@
     display: inline-block;
     white-space: nowrap;
 
-    font-family: "Lucida Grande", sans-serif;
     font-size: 13px;
 
     color: white;
     outline: none;
 
     list-style: none;
-
-    font-family: "Lucida Grande", "Helvetica", sans-serif;
-    font-size: 11px;
 }
 
 .navigation-sidebar-panel-content-tree-outline .children {
index a32fb8e..448fb16 100644 (file)
@@ -89,8 +89,6 @@
 .details-section.probe-set .data-grid th {
     height: 21px;
 
-    font-size: 11px;
-    font-family: "Lucida Grande", sans-serif;
     background-image: linear-gradient(to bottom, rgb(248, 248, 248), rgb(226, 226, 226));
     background-size: 100% 100% !important;
     background-position: center !important;
index a586c02..811b053 100644 (file)
@@ -24,9 +24,6 @@
  */
 
 .sidebar > .panel.details.css-style .rules .label {
-    font-size: 11px;
-    font-family: "Lucida Grande", sans-serif;
-
     color: rgb(60%, 60%, 60%);
     text-shadow: white 0 1px 0;
 
@@ -43,7 +40,6 @@
 
 .sidebar > .panel.details.css-style .rules .new-rule {
     font-size: 12px;
-    font-family: "Lucida Grande", sans-serif;
     font-weight: bold;
 
     color: black;
index 08ad58b..a1789d6 100644 (file)
@@ -24,7 +24,6 @@
  */
 
 .scope-bar {
-    font-family: Lucida Grande, sans-serif;
     padding: 0 3px;
     overflow: hidden;
 }
@@ -35,7 +34,7 @@
     padding: 0 8px 3px;
     font-size: 11px;
     font-weight: bold;
-    line-height: 12px;
+    line-height: 11px;
     color: rgb(46, 46, 46);
     background-color: transparent;
     border: 1px solid transparent;
index 7b7ff6d..ae31f07 100644 (file)
@@ -32,7 +32,8 @@
 }
 
 .popover .debugger-popover-content {
-    font-family: monospace;
+    font-family: Menlo, monospace;
+    font-size: 11px;
     white-space: pre;
 }
 
@@ -72,6 +73,6 @@
     width: 16px;
     height: 16px;
     content: -webkit-image-set(url(../Images/ColorIcon.png) 1x, url(../Images/ColorIcon@2x.png) 2x);
-    
+
     -webkit-transform: translateY(1px);
 }
index 7cf7e5a..ff5daf2 100644 (file)
@@ -34,9 +34,6 @@
 .data-grid.timeline th {
     height: 22px;
 
-    font-size: 11px;
-    font-family: "Lucida Grande", sans-serif;
-
     background-image: none;
     background-color: white;
 
     margin: 0;
     outline: none;
     list-style: none;
-    font-family: "Lucida Grande", "Helvetica", sans-serif;
-    font-size: 11px;
 }
 
 .timeline-data-grid-tree-outline .item {
index 318b395..830843a 100644 (file)
@@ -60,7 +60,6 @@
     top: 5px;
     right: 5px;
     font-size: 9px;
-    font-family: "Lucida Grande", sans-serif;
     color: rgb(128, 128, 128);
     white-space: nowrap;
 }
index e9a1c58..e8b780f 100644 (file)
@@ -81,8 +81,6 @@
     text-align: center;
 
     line-height: 20px;
-    font-size: 11px;
-    font-family: "Lucida Grande", sans-serif;
     font-weight: bold;
 
     color: rgb(76, 76, 76);
     overflow: hidden;
     text-overflow: ellipsis;
 
-    font-size: 11px;
-    font-family: "Lucida Grande", sans-serif;
     font-weight: bold;
 
     padding: 4px 9px;