Unreviewed, roll out r243858 which made tests time out.
authorcdumez@apple.com <cdumez@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 4 Apr 2019 15:44:37 +0000 (15:44 +0000)
committercdumez@apple.com <cdumez@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 4 Apr 2019 15:44:37 +0000 (15:44 +0000)
Disable new API tests on Windows instead.

* TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp

index bce8538..52411bf 100644 (file)
@@ -1,3 +1,12 @@
+2019-04-04  Chris Dumez  <cdumez@apple.com>
+
+        Unreviewed, roll out r243858 which made tests time out.
+
+        Disable new API tests on Windows instead.
+
+        * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
+        (TestWebKitAPI::TEST):
+
 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
 
         [ATK] Cleanup WebPageAccessibilityObjectAtk
index 43d829a..764f5ab 100644 (file)
@@ -91,6 +91,8 @@ TEST(WebKit, ReloadPageAfterCrash)
     Util::run(&loadAfterCrash);
 }
 
+#if !PLATFORM(WIN)
+
 static void nullJavaScriptCallback(WKSerializedScriptValueRef, WKErrorRef, void*)
 {
 }
@@ -133,7 +135,7 @@ TEST(WebKit, FocusedFrameAfterCrash)
     while (!WKPageGetFocusedFrame(webView.page()))
         Util::spinRunLoop(10);
 
-    WKPageTerminate(webView.page());
+    kill(WKPageGetProcessIdentifier(webView.page()), 9);
 
     Util::run(&calledCrashHandler);
 }
@@ -163,11 +165,13 @@ TEST(WebKit, FrameSetLargestFrameAfterCrash)
     while (!WKPageGetFrameSetLargestFrame(webView.page()))
         Util::spinRunLoop(10);
 
-    WKPageTerminate(webView.page());
+    kill(WKPageGetProcessIdentifier(webView.page()), 9);
 
     Util::run(&calledCrashHandler);
 }
 
+#endif // !PLATFORM(WIN)
+
 } // namespace TestWebKitAPI
 
 #endif