2010-09-08 Yury Semikhatsky <yurys@chromium.org>
authoryurys@chromium.org <yurys@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 9 Sep 2010 00:03:28 +0000 (00:03 +0000)
committeryurys@chromium.org <yurys@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 9 Sep 2010 00:03:28 +0000 (00:03 +0000)
        Reviewed by Joseph Pecoraro.

        Web Inspector: test that debugger won't pause on syntax errors
        https://bugs.webkit.org/show_bug.cgi?id=45388

        * inspector/debugger-autocontinue-on-syntax-error-expected.txt: Added.
        * inspector/debugger-autocontinue-on-syntax-error.html: Added.
2010-09-08  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Joseph Pecoraro.

        Web Inspector: test that debugger won't pause on syntax errors
        https://bugs.webkit.org/show_bug.cgi?id=45388

        * src/js/Tests.js: removed testAutoContinueOnSyntaxError which is now covered by
        inspector/debugger-autocontinue-on-syntax-error.html layout test

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/inspector/debugger-autocontinue-on-syntax-error-expected.txt [new file with mode: 0644]
LayoutTests/inspector/debugger-autocontinue-on-syntax-error.html [new file with mode: 0644]
WebKit/chromium/ChangeLog
WebKit/chromium/src/js/Tests.js

index fa74363..516a6a0 100644 (file)
@@ -1,3 +1,13 @@
+2010-09-08  Yury Semikhatsky  <yurys@chromium.org>
+
+        Reviewed by Joseph Pecoraro.
+
+        Web Inspector: test that debugger won't pause on syntax errors
+        https://bugs.webkit.org/show_bug.cgi?id=45388
+
+        * inspector/debugger-autocontinue-on-syntax-error-expected.txt: Added.
+        * inspector/debugger-autocontinue-on-syntax-error.html: Added.
+
 2010-09-08  Brian Weinstein  <bweinstein@apple.com>
 
         Rubber-stamped by Steve Falkenburg.
diff --git a/LayoutTests/inspector/debugger-autocontinue-on-syntax-error-expected.txt b/LayoutTests/inspector/debugger-autocontinue-on-syntax-error-expected.txt
new file mode 100644 (file)
index 0000000..4b31b6e
--- /dev/null
@@ -0,0 +1,8 @@
+CONSOLE MESSAGE: line 1: SyntaxError: Parse error
+CONSOLE MESSAGE: line 1: SyntaxError: Parse error
+Tests that debugger won't stop on syntax errors even if "pause on uncaught exceptions" is on.
+
+Debugger was enabled.
+Page reloaded.
+DONE.
+
diff --git a/LayoutTests/inspector/debugger-autocontinue-on-syntax-error.html b/LayoutTests/inspector/debugger-autocontinue-on-syntax-error.html
new file mode 100644 (file)
index 0000000..fd56208
--- /dev/null
@@ -0,0 +1,38 @@
+<html>
+<head>
+<script src="../http/tests/inspector/inspector-test2.js"></script>
+<script src="../http/tests/inspector/debugger-test2.js"></script>
+<script src="resources/syntax-error.js"></script>
+<script>
+
+function test()
+{
+    WebInspector.showPanel("scripts");
+    InspectorTest.startDebuggerTest(startDebuggerTestCallback);
+
+    function startDebuggerTestCallback()
+    {
+        InspectorBackend.setPauseOnExceptionsState(WebInspector.ScriptsPanel.PauseOnExceptionsState.PauseOnUncaughtExceptions);
+        InspectorTest.showScriptSource("debugger-autocontinue-on-syntax-error.html", reloadInspectedPage);
+    }
+
+    function reloadInspectedPage()
+    {
+        InspectorTest.reloadPage(function() {
+            InspectorTest.addResult("DONE.");
+            InspectorTest.completeTest();
+        });
+    }
+
+}
+
+</script>
+</head>
+
+<body onload="runTest()">
+<p>
+Tests that debugger won't stop on syntax errors even if "pause on uncaught exceptions" is on.
+</p>
+
+</body>
+</html>
index 4e8f366..b5e654f 100644 (file)
@@ -1,3 +1,13 @@
+2010-09-08  Yury Semikhatsky  <yurys@chromium.org>
+
+        Reviewed by Joseph Pecoraro.
+
+        Web Inspector: test that debugger won't pause on syntax errors
+        https://bugs.webkit.org/show_bug.cgi?id=45388
+
+        * src/js/Tests.js: removed testAutoContinueOnSyntaxError which is now covered by 
+        inspector/debugger-autocontinue-on-syntax-error.html layout test
+
 2010-09-08  Peter Kasting  <pkasting@google.com>
 
         Reviewed by David Hyatt.
index f528d2d..40bb130 100644 (file)
@@ -821,16 +821,6 @@ TestSuite.prototype.testCompletionOnPause = function()
 
 
 /**
- * Tests that inspected page doesn't hang on reload if it contains a syntax
- * error and DevTools window is open.
- */
-TestSuite.prototype.testAutoContinueOnSyntaxError = function()
-{
-    // TODO(yurys): provide an implementation that works with ScriptDebugServer.
-};
-
-
-/**
  * Checks current execution line against expectations.
  * @param {WebInspector.SourceFrame} sourceFrame
  * @param {number} lineNumber Expected line number