2010-11-09 Kent Tamura <tkent@chromium.org>
authortkent@chromium.org <tkent@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 9 Nov 2010 23:29:51 +0000 (23:29 +0000)
committertkent@chromium.org <tkent@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 9 Nov 2010 23:29:51 +0000 (23:29 +0000)
        Reviewed by Dimitri Glazkov.

        [Chromium] Add form validation message support to WebLocalizedString.h
        https://bugs.webkit.org/show_bug.cgi?id=49239

        * DEPS: Roll Chromium revision to r65502 to have crrev.com/65502
        * public/WebLocalizedString.h: Add new symbols
        * src/LocalizedStrings.cpp: Call query() with the new symbols in the following functions.
        (WebCore::validationMessageValueMissingText):
        (WebCore::validationMessageTypeMismatchText):
        (WebCore::validationMessagePatternMismatchText):
        (WebCore::validationMessageTooLongText):
        (WebCore::validationMessageRangeUnderflowText):
        (WebCore::validationMessageRangeOverflowText):
        (WebCore::validationMessageStepMismatchText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebKit/chromium/ChangeLog
WebKit/chromium/DEPS
WebKit/chromium/public/WebLocalizedString.h
WebKit/chromium/src/LocalizedStrings.cpp

index b1100ec..ed78d51 100644 (file)
@@ -1,3 +1,21 @@
+2010-11-09  Kent Tamura  <tkent@chromium.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        [Chromium] Add form validation message support to WebLocalizedString.h
+        https://bugs.webkit.org/show_bug.cgi?id=49239
+
+        * DEPS: Roll Chromium revision to r65502 to have crrev.com/65502
+        * public/WebLocalizedString.h: Add new symbols
+        * src/LocalizedStrings.cpp: Call query() with the new symbols in the following functions.
+        (WebCore::validationMessageValueMissingText):
+        (WebCore::validationMessageTypeMismatchText):
+        (WebCore::validationMessagePatternMismatchText):
+        (WebCore::validationMessageTooLongText):
+        (WebCore::validationMessageRangeUnderflowText):
+        (WebCore::validationMessageRangeOverflowText):
+        (WebCore::validationMessageStepMismatchText):
+
 2010-11-09  Tony Chang  <tony@chromium.org>
 
         Unreviewed, rolling chromium DEPS.
index ecc4c61..c4f7dda 100644 (file)
@@ -32,7 +32,7 @@
 
 vars = {
   'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
-  'chromium_rev': '65462'
+  'chromium_rev': '65502'
 }
 
 deps = {
index 99a7d23..bb45b6e 100644 (file)
@@ -58,6 +58,13 @@ struct WebLocalizedString {
         AXLinkActionVerb,
         KeygenMenuHighGradeKeySize,
         KeygenMenuMediumGradeKeySize,
+        ValidationValueMissing,
+        ValidationTypeMismatch,
+        ValidationPatternMismatch,
+        ValidationTooLong,
+        ValidationRangeUnderflow,
+        ValidationRangeOverflow,
+        ValidationStepMismatch,
     };
 };
 
index fbc35ce..614aac3 100644 (file)
@@ -296,44 +296,37 @@ String localizedMediaTimeDescription(float /*time*/)
 
 String validationMessageValueMissingText()
 {
-    notImplemented();
-    return String();
+    return query(WebLocalizedString::ValidationValueMissing);
 }
 
 String validationMessageTypeMismatchText()
 {
-    notImplemented();
-    return String();
+    return query(WebLocalizedString::ValidationTypeMismatch);
 }
 
 String validationMessagePatternMismatchText()
 {
-    notImplemented();
-    return String();
+    return query(WebLocalizedString::ValidationPatternMismatch);
 }
 
 String validationMessageTooLongText()
 {
-    notImplemented();
-    return String();
+    return query(WebLocalizedString::ValidationTooLong);
 }
 
 String validationMessageRangeUnderflowText()
 {
-    notImplemented();
-    return String();
+    return query(WebLocalizedString::ValidationRangeUnderflow);
 }
 
 String validationMessageRangeOverflowText()
 {
-    notImplemented();
-    return String();
+    return query(WebLocalizedString::ValidationRangeOverflow);
 }
 
 String validationMessageStepMismatchText()
 {
-    notImplemented();
-    return String();
+    return query(WebLocalizedString::ValidationStepMismatch);
 }
 
 } // namespace WebCore