OS X port should compile with newer versions of clang
authormlilek@apple.com <mlilek@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 11 Sep 2012 23:06:00 +0000 (23:06 +0000)
committermlilek@apple.com <mlilek@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 11 Sep 2012 23:06:00 +0000 (23:06 +0000)
https://bugs.webkit.org/show_bug.cgi?id=96434

Source/JavaScriptCore:

m_identIsVarDecl is unused - remove it.

Reviewed by Anders Carlsson.

* parser/NodeConstructors.h:
(JSC::ForInNode::ForInNode):
* parser/Nodes.h:
(ForInNode):

Source/WebCore:

Reviewed by Anders Carlsson.

Guard m_hasTouchEventHandler behind ENABLE(TOUCH_EVENTS).
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::HTMLInputElement):
* html/HTMLInputElement.h:
(HTMLInputElement):

Fix uninitialized variable.
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::createLinearSRGBColorSpace):

Source/WebKit/mac:

m_isTerminated is unused in the Hosted flavor of NetscapePluginStream.

Reviewed by Anders Carlsson.

* Plugins/Hosted/HostedNetscapePluginStream.h:
(HostedNetscapePluginStream):
* Plugins/Hosted/HostedNetscapePluginStream.mm:
(WebKit::HostedNetscapePluginStream::HostedNetscapePluginStream):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/JavaScriptCore/ChangeLog
Source/JavaScriptCore/parser/NodeConstructors.h
Source/JavaScriptCore/parser/Nodes.h
Source/WebCore/ChangeLog
Source/WebCore/html/HTMLInputElement.cpp
Source/WebCore/html/HTMLInputElement.h
Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp
Source/WebKit/mac/ChangeLog
Source/WebKit/mac/Plugins/Hosted/HostedNetscapePluginStream.h
Source/WebKit/mac/Plugins/Hosted/HostedNetscapePluginStream.mm

index 2507476..729ff77 100644 (file)
@@ -1,3 +1,17 @@
+2012-09-11  Matt Lilek  <mrl@apple.com>
+
+        OS X port should compile with newer versions of clang
+        https://bugs.webkit.org/show_bug.cgi?id=96434
+
+        m_identIsVarDecl is unused - remove it.
+
+        Reviewed by Anders Carlsson.
+
+        * parser/NodeConstructors.h:
+        (JSC::ForInNode::ForInNode):
+        * parser/Nodes.h:
+        (ForInNode):
+
 2012-09-11  Filip Pizlo  <fpizlo@apple.com>
 
         LLInt should optimize and profile array length accesses
index 1678bf7..2744919 100644 (file)
@@ -812,7 +812,6 @@ namespace JSC {
         , m_lexpr(l)
         , m_expr(expr)
         , m_statement(statement)
-        , m_identIsVarDecl(false)
     {
     }
 
@@ -822,7 +821,6 @@ namespace JSC {
         , m_lexpr(new (globalData) ResolveNode(location, ident, divot - startOffset))
         , m_expr(expr)
         , m_statement(statement)
-        , m_identIsVarDecl(true)
     {
         if (in) {
             AssignResolveNode* node = new (globalData) AssignResolveNode(location, ident, in);
index 475689c..509d36d 100644 (file)
@@ -1204,7 +1204,6 @@ namespace JSC {
         ExpressionNode* m_lexpr;
         ExpressionNode* m_expr;
         StatementNode* m_statement;
-        bool m_identIsVarDecl;
     };
 
     class ContinueNode : public StatementNode, public ThrowableExpressionData {
index 1330cf0..3aa4983 100644 (file)
@@ -1,3 +1,20 @@
+2012-09-11  Matt Lilek  <mrl@apple.com>
+
+        OS X port should compile with newer versions of clang
+        https://bugs.webkit.org/show_bug.cgi?id=96434
+
+        Reviewed by Anders Carlsson.
+
+        Guard m_hasTouchEventHandler behind ENABLE(TOUCH_EVENTS).
+        * html/HTMLInputElement.cpp:
+        (WebCore::HTMLInputElement::HTMLInputElement):
+        * html/HTMLInputElement.h:
+        (HTMLInputElement):
+
+        Fix uninitialized variable.
+        * platform/graphics/cg/GraphicsContextCG.cpp:
+        (WebCore::createLinearSRGBColorSpace):
+
 2012-09-11  Arnaud Renevier  <a.renevier@sisa.samsung.com>
 
         [Gtk] allow building with css-shaders
index c82de2f..2c4c048 100644 (file)
@@ -119,7 +119,9 @@ HTMLInputElement::HTMLInputElement(const QualifiedName& tagName, Document* docum
     , m_valueAttributeWasUpdatedAfterParsing(false)
     , m_wasModifiedByUser(false)
     , m_canReceiveDroppedFiles(false)
+#if ENABLE(TOUCH_EVENTS)
     , m_hasTouchEventHandler(false)
+#endif
     , m_inputType(InputType::createText(this))
 {
     ASSERT(hasTagName(inputTag) || hasTagName(isindexTag));
index 678f59a..7fe0d6c 100644 (file)
@@ -412,7 +412,9 @@ private:
     bool m_valueAttributeWasUpdatedAfterParsing : 1;
     bool m_wasModifiedByUser : 1;
     bool m_canReceiveDroppedFiles : 1;
-    bool m_hasTouchEventHandler: 1;
+#if ENABLE(TOUCH_EVENTS)
+    bool m_hasTouchEventHandler : 1;
+#endif
     OwnPtr<InputType> m_inputType;
 #if ENABLE(DATALIST_ELEMENT)
     OwnPtr<ListAttributeTargetObserver> m_listAttributeTargetObserver;
index 2eed9cd..b59c277 100644 (file)
@@ -197,7 +197,7 @@ static CGColorSpaceRef createLinearSRGBColorSpace()
     
     CFBundleRef webCoreBundle = CFBundleGetBundleWithIdentifier(CFSTR("com.apple.WebCore"));
     RetainPtr<CFURLRef> iccProfileURL(CFBundleCopyResourceURL(webCoreBundle, CFSTR("linearSRGB"), CFSTR("icc"), 0));
-    CFDataRef iccProfileData;
+    CFDataRef iccProfileData = 0;
     
     if (iccProfileURL && CFURLCreateDataAndPropertiesFromResource(0, iccProfileURL.get(), &iccProfileData, 0, 0, 0))
         linearSRGBSpace = CGColorSpaceCreateWithICCProfile(iccProfileData);
index 91b7ffa..4dedec2 100644 (file)
@@ -1,3 +1,17 @@
+2012-09-11  Matt Lilek  <mrl@apple.com>
+
+        OS X port should compile with newer versions of clang
+        https://bugs.webkit.org/show_bug.cgi?id=96434
+
+        m_isTerminated is unused in the Hosted flavor of NetscapePluginStream.
+
+        Reviewed by Anders Carlsson.
+
+        * Plugins/Hosted/HostedNetscapePluginStream.h:
+        (HostedNetscapePluginStream):
+        * Plugins/Hosted/HostedNetscapePluginStream.mm:
+        (WebKit::HostedNetscapePluginStream::HostedNetscapePluginStream):
+
 2012-09-10  Jer Noble  <jer.noble@apple.com>
 
         Unreviewed; rolling out r128081.
index 34cea32..a338029 100644 (file)
@@ -89,7 +89,6 @@ private:
     
     RefPtr<NetscapePluginInstanceProxy> m_instance;
     uint32_t m_streamID;
-    bool m_isTerminated;
     RetainPtr<NSMutableURLRequest> m_request;
 
     RetainPtr<NSURL> m_requestURL;
index 7c84ede..e2e5f54 100644 (file)
@@ -54,7 +54,6 @@ DEFINE_DEBUG_ONLY_GLOBAL(WTF::RefCountedLeakCounter, hostedNetscapePluginStreamC
 HostedNetscapePluginStream::HostedNetscapePluginStream(NetscapePluginInstanceProxy* instance, uint32_t streamID, NSURLRequest *request)
     : m_instance(instance)
     , m_streamID(streamID)
-    , m_isTerminated(false)
     , m_request(AdoptNS, [request mutableCopy])
     , m_requestURL([request URL])
     , m_frameLoader(0)
@@ -73,7 +72,6 @@ HostedNetscapePluginStream::HostedNetscapePluginStream(NetscapePluginInstancePro
 HostedNetscapePluginStream::HostedNetscapePluginStream(NetscapePluginInstanceProxy* instance, WebCore::FrameLoader* frameLoader)
     : m_instance(instance)
     , m_streamID(1)
-    , m_isTerminated(false)
     , m_frameLoader(frameLoader)
 {
 #ifndef NDEBUG