2011-03-15 Philippe Normand <pnormand@igalia.com>
authorphiln@webkit.org <philn@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 16 Mar 2011 08:56:50 +0000 (08:56 +0000)
committerphiln@webkit.org <philn@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 16 Mar 2011 08:56:50 +0000 (08:56 +0000)
        Reviewed by Eric Carlson.

        [GStreamer] http/tests/media/video-play-stall-before-meta-data.html fails
        https://bugs.webkit.org/show_bug.cgi?id=56370

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::mediaPlayerPrivateMessageCallback): Let the
        mediaPlayerClient handle the stream error, in this case the
        HTMLMediaElement will emit a stalled event.

2011-03-15  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Eric Carlson.

        [GStreamer] http/tests/media/video-play-stall-before-meta-data.html fails
        https://bugs.webkit.org/show_bug.cgi?id=56370

        * platform/gtk/Skipped: Unskip fixed test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/gtk/Skipped
Source/WebCore/ChangeLog
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

index 7960603..a8fb2fd 100644 (file)
@@ -1,3 +1,12 @@
+2011-03-15  Philippe Normand  <pnormand@igalia.com>
+
+        Reviewed by Eric Carlson.
+
+        [GStreamer] http/tests/media/video-play-stall-before-meta-data.html fails
+        https://bugs.webkit.org/show_bug.cgi?id=56370
+
+        * platform/gtk/Skipped: Unskip fixed test.
+
 2011-03-16  Yury Semikhatsky  <yurys@chromium.org>
 
         Reviewed by Pavel Feldman.
index 4750910..0bdec7a 100644 (file)
@@ -498,9 +498,6 @@ http/tests/loading/gmail-assert-on-load.html
 http/tests/loading/redirect-with-no-location-crash.html
 http/tests/loading/text-content-type-with-binary-extension.html
 
-# https://bugs.webkit.org/show_bug.cgi?id=56370
-http/tests/media/video-play-stall-before-meta-data.html
-
 http/tests/media/video-play-stall-seek.html
 http/tests/media/video-play-stall.html
 http/tests/media/video-seekable-stall.html
index 40ec43a..5a4fb0b 100644 (file)
@@ -1,3 +1,15 @@
+2011-03-15  Philippe Normand  <pnormand@igalia.com>
+
+        Reviewed by Eric Carlson.
+
+        [GStreamer] http/tests/media/video-play-stall-before-meta-data.html fails
+        https://bugs.webkit.org/show_bug.cgi?id=56370
+
+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+        (WebCore::mediaPlayerPrivateMessageCallback): Let the
+        mediaPlayerClient handle the stream error, in this case the
+        HTMLMediaElement will emit a stalled event.
+
 2011-03-10  Philippe Normand  <pnormand@igalia.com>
 
         Reviewed by Martin Robinson.
index 755d2d6..393c13f 100644 (file)
@@ -117,6 +117,13 @@ gboolean mediaPlayerPrivateMessageCallback(GstBus* bus, GstMessage* message, gpo
             || err->code == GST_RESOURCE_ERROR_NOT_FOUND)
             error = MediaPlayer::FormatError;
         else if (err->domain == GST_STREAM_ERROR) {
+            // Let the mediaPlayerClient handle the stream error, in
+            // this case the HTMLMediaElement will emit a stalled
+            // event.
+            if (err->code == GST_STREAM_ERROR_TYPE_NOT_FOUND) {
+                LOG_VERBOSE(Media, "Decode error, let the Media element emit a stalled event.");
+                break;
+            }
             error = MediaPlayer::DecodeError;
             attemptNextLocation = true;
         } else if (err->domain == GST_RESOURCE_ERROR)