Web Inspector: Settings: group titles should vertically align with the first editor
authordrousso@apple.com <drousso@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 14 Jan 2019 20:17:24 +0000 (20:17 +0000)
committerdrousso@apple.com <drousso@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 14 Jan 2019 20:17:24 +0000 (20:17 +0000)
https://bugs.webkit.org/show_bug.cgi?id=193391

Reviewed by Dean Jackson.

* UserInterface/Views/SettingsTabContentView.css:
(.content-view.settings > .settings-view > .container):
(.content-view.settings > .settings-view > .container > .editor-group > .editor): Added.
(.content-view.settings > .settings-view > .container > .editor-group > .editor:first-child > *): Added.
(.content-view.settings > .settings-view > .container > .editor-group > .editor select):
(.content-view.settings > .settings-view > .container > .editor-group > .editor input[type="number"]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.css

index 5f28824..810dd1b 100644 (file)
@@ -1,3 +1,17 @@
+2019-01-14  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Settings: group titles should vertically align with the first editor
+        https://bugs.webkit.org/show_bug.cgi?id=193391
+
+        Reviewed by Dean Jackson.
+
+        * UserInterface/Views/SettingsTabContentView.css:
+        (.content-view.settings > .settings-view > .container):
+        (.content-view.settings > .settings-view > .container > .editor-group > .editor): Added.
+        (.content-view.settings > .settings-view > .container > .editor-group > .editor:first-child > *): Added.
+        (.content-view.settings > .settings-view > .container > .editor-group > .editor select):
+        (.content-view.settings > .settings-view > .container > .editor-group > .editor input[type="number"]):
+
 2019-01-11  Matt Baker  <mattbaker@apple.com>
 
         Web Inspector: REGRESSION: deleting an audit puts selection in a selected but invisible state
index 458a116..9df6efc 100644 (file)
@@ -55,7 +55,6 @@
 
 .content-view.settings > .settings-view > .container {
     display: flex;
-    align-items: center;
     margin-top: 1em;
     font-size: 13px;
 }
     flex-direction: column;
 }
 
+.content-view.settings > .settings-view > .container > .editor-group > .editor {
+    --settings-editor-child-margin-top: 0;
+}
+
+.content-view.settings > .settings-view > .container > .editor-group > .editor:first-child > * {
+    margin-top: var(--settings-editor-child-margin-top);
+}
+
 .content-view.settings > .settings-view > .container > .editor-group > .editor input {
     font-size: inherit;
 }
     font-size: 16px;
 
     /* Vertically align <select> with the group title text. */
-    margin-top: 0;
+    --settings-editor-child-margin-top: -2px;
 }
 
 .content-view.settings > .settings-view > .container > .editor-group > .editor input[type="number"] {
-    /* Vertically align <input> with the group title text. */
-    margin-top: -1px;
-
     max-width: 48px;
+    padding-top: 0;
+    padding-bottom: 0;
     text-align: end;
+    vertical-align: 1px;
 
+    /* Vertically align <input> with the group title text. */
+    --settings-editor-child-margin-top: -2px;
     --settings-input-number-margin-start: 2px;
     --settings-input-number-margin-end: 5px;
 }