[ews-app] Status bubble should not turn orange when any build step has warnings
authoraakash_jain@apple.com <aakash_jain@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 17 May 2019 23:41:47 +0000 (23:41 +0000)
committeraakash_jain@apple.com <aakash_jain@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 17 May 2019 23:41:47 +0000 (23:41 +0000)
https://bugs.webkit.org/show_bug.cgi?id=198000

Reviewed by Jonathan Bedard.

* BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
(StatusBubble._does_build_contains_any_failed_step):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py
Tools/ChangeLog

index aa46e56..47a4941 100644 (file)
@@ -155,7 +155,7 @@ class StatusBubble(View):
 
     def _does_build_contains_any_failed_step(self, build):
         for step in build.step_set.all():
-            if step.result and step.result != Buildbot.SUCCESS:
+            if step.result and step.result != Buildbot.SUCCESS and step.result != Buildbot.WARNINGS:
                 return True
         return False
 
index 8f32ef9..f0fcfde 100644 (file)
@@ -1,3 +1,13 @@
+2019-05-17  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-app] Status bubble should not turn orange when any build step has warnings
+        https://bugs.webkit.org/show_bug.cgi?id=198000
+
+        Reviewed by Jonathan Bedard.
+
+        * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
+        (StatusBubble._does_build_contains_any_failed_step):
+
 2019-05-17  Alex Christensen  <achristensen@webkit.org>
 
         Add SPI to set a list of hosts to which to send custom header fields cross-origin