[EFL] Enable WebP support.
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 11 Oct 2014 16:22:32 +0000 (16:22 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 11 Oct 2014 16:22:32 +0000 (16:22 +0000)
https://bugs.webkit.org/show_bug.cgi?id=136156

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2014-10-11
Reviewed by Gyuyoung Kim.

.:

Add WebP package finding rule.

* Source/cmake/OptionsEfl.cmake:

Source/WebCore:

Add WebP library and inlcude path to WebCore path for WK2 Efl.
No new tests since existing feature is just enabled for WK2 Efl.

* PlatformEfl.cmake:

Source/WTF:

Enable WTF_USE_WEBP macro for WK2 Efl.

* wtf/Platform.h:

Tools:

Include libwebp-dev package to support WebP for WK2 Efl.

* efl/install-dependencies:

LayoutTests:

Clarify skipped webp test for Webkit EFL.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

ChangeLog
LayoutTests/ChangeLog
LayoutTests/platform/efl/TestExpectations
Source/WTF/ChangeLog
Source/WTF/wtf/Platform.h
Source/WebCore/ChangeLog
Source/WebCore/PlatformEfl.cmake
Source/cmake/OptionsEfl.cmake
Tools/ChangeLog
Tools/efl/install-dependencies

index 1bf54d2..3abee5e 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,14 @@
+2014-10-11  KwangHyuk Kim  <hyuki.kim@samsung.com>
+
+        [EFL] Enable WebP support.
+        https://bugs.webkit.org/show_bug.cgi?id=136156
+
+        Reviewed by Gyuyoung Kim.
+
+        Add WebP package finding rule.
+
+        * Source/cmake/OptionsEfl.cmake:
+
 2014-10-07  Pascal Jacquemart  <p.jacquemart@samsung.com>
 
         [EFL] Enable custom URI schemes with CustomProtocols
index d40cb30..0f89ab8 100644 (file)
@@ -1,3 +1,14 @@
+2014-10-11  KwangHyuk Kim  <hyuki.kim@samsung.com>
+
+        [EFL] Enable WebP support.
+        https://bugs.webkit.org/show_bug.cgi?id=136156
+
+        Reviewed by Gyuyoung Kim.
+
+        Clarify skipped webp test for Webkit EFL.
+
+        * platform/efl/TestExpectations:
+
 2014-10-10  Simon Fraser  <simon.fraser@apple.com>
 
         Make these animation tests not timeout if hit testing fails.
index 649e011..b28f18c 100644 (file)
@@ -1101,13 +1101,13 @@ webkit.org/b/84773 ietestcenter/css3/multicolumn/column-width-applies-to-012.htm
 webkit.org/b/84777 ietestcenter/css3/multicolumn/column-width-applies-to-015.htm [ ImageOnlyFailure ]
 
 # Requires WebP support.
-Bug(EFL) fast/canvas/canvas-toDataURL-webp.html
-Bug(EFL) fast/images/webp-image-decoding.html
-Bug(EFL) fast/images/webp-color-profile-lossless.html
-Bug(EFL) fast/images/webp-color-profile-lossy-alpha.html
-Bug(EFL) fast/images/webp-color-profile-lossy.html
-Bug(EFL) http/tests/images/webp-partial-load.html
-Bug(EFL) http/tests/images/webp-progressive-load.html
+Bug(EFL) fast/canvas/canvas-toDataURL-webp.html [ Skip ]
+# Requires WebP 0.2 support.
+Bug(EFL) fast/images/webp-image-decoding.html [ Skip ]
+# Requires WebP 0.3 and color profile support.
+Bug(EFL) fast/images/webp-color-profile-lossless.html [ Skip ]
+Bug(EFL) fast/images/webp-color-profile-lossy-alpha.html [ Skip ]
+Bug(EFL) fast/images/webp-color-profile-lossy.html [ Skip ]
 
 # Requires MEDIA_SOURCE support.
 webkit.org/b/95296 http/tests/media/media-source [ Skip ]
index 22d9dff..4439462 100644 (file)
@@ -1,3 +1,14 @@
+2014-10-11  KwangHyuk Kim  <hyuki.kim@samsung.com>
+
+        [EFL] Enable WebP support.
+        https://bugs.webkit.org/show_bug.cgi?id=136156
+
+        Reviewed by Gyuyoung Kim.
+
+        Enable WTF_USE_WEBP macro for WK2 Efl.
+
+        * wtf/Platform.h:
+
 2014-10-11  Carlos Garcia Campos  <cgarcia@igalia.com>
 
         [GLIB] Split GMainLoopSource moving thread safe implementation to its own class GThreadSafeMainLoopSource
index 7030d99..7712ddb 100644 (file)
 #define WTF_USE_FREETYPE 1
 #define WTF_USE_HARFBUZZ 1
 #define WTF_USE_SOUP 1
+#endif
+
+#if PLATFORM(GTK) || PLATFORM(EFL)
 #define WTF_USE_WEBP 1
 #endif
 
index 515f741..7ecd4cf 100644 (file)
@@ -1,3 +1,15 @@
+2014-10-11  KwangHyuk Kim  <hyuki.kim@samsung.com>
+
+        [EFL] Enable WebP support.
+        https://bugs.webkit.org/show_bug.cgi?id=136156
+
+        Reviewed by Gyuyoung Kim.
+
+        Add WebP library and inlcude path to WebCore path for WK2 Efl.
+        No new tests since existing feature is just enabled for WK2 Efl.
+
+        * PlatformEfl.cmake:
+
 2014-10-11  Carlos Garcia Campos  <cgarcia@igalia.com>
 
         [GLIB] Split GMainLoopSource moving thread safe implementation to its own class GThreadSafeMainLoopSource
index f24671d..7b446dc 100644 (file)
@@ -310,6 +310,7 @@ list(APPEND WebCore_LIBRARIES
     ${LIBXSLT_LIBRARIES}
     ${PNG_LIBRARIES}
     ${SQLITE_LIBRARIES}
+    ${WEBP_LIBRARIES}
     ${X11_X11_LIB}
     ${ZLIB_LIBRARIES}
 )
@@ -331,6 +332,7 @@ list(APPEND WebCore_INCLUDE_DIRECTORIES
     ${LIBXML2_INCLUDE_DIR}
     ${LIBXSLT_INCLUDE_DIR}
     ${SQLITE_INCLUDE_DIR}
+    ${WEBP_INCLUDE_DIRS}
     ${GLIB_INCLUDE_DIRS}
     ${LIBSOUP_INCLUDE_DIRS}
     ${ZLIB_INCLUDE_DIRS}
index ecb4ae4..c0836fc 100644 (file)
@@ -22,6 +22,7 @@ find_package(ICU REQUIRED)
 find_package(Threads REQUIRED)
 find_package(JPEG REQUIRED)
 find_package(PNG REQUIRED)
+find_package(WebP REQUIRED)
 find_package(ZLIB REQUIRED)
 
 set(glib_components gio gobject gthread)
index ae2814c..a7df6c7 100644 (file)
@@ -1,3 +1,14 @@
+2014-10-11  KwangHyuk Kim  <hyuki.kim@samsung.com>
+
+        [EFL] Enable WebP support.
+        https://bugs.webkit.org/show_bug.cgi?id=136156
+
+        Reviewed by Gyuyoung Kim.
+
+        Include libwebp-dev package to support WebP for WK2 Efl.
+
+        * efl/install-dependencies:
+
 2014-10-11  Carlos Garcia Campos  <cgarcia@igalia.com>
 
         [GLIB] Split GMainLoopSource moving thread safe implementation to its own class GThreadSafeMainLoopSource
index c89d7cc..e7becc7 100755 (executable)
@@ -61,6 +61,7 @@ function installDependenciesWithApt {
         libtiff4-dev \
         libudev-dev \
         libvorbis-dev \
+        libwebp-dev \
         libxcomposite-dev \
         libxcursor-dev \
         libxinerama-dev \