Web Inspector: REGRESSION: Network Cookies Table does not load
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 12 Mar 2019 04:56:41 +0000 (04:56 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 12 Mar 2019 04:56:41 +0000 (04:56 +0000)
https://bugs.webkit.org/show_bug.cgi?id=195599

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2019-03-11
Reviewed by Devin Rousso.

* UserInterface/Views/ResourceCookiesContentView.js:
(WI.ResourceCookiesContentView.prototype.tableIndexForRepresentedObject):
(WI.ResourceCookiesContentView.prototype.tableRepresentedObjectForIndex):
Include needed delegate methods.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/UserInterface/Views/ResourceCookiesContentView.js

index 2ec58f5..3b14131 100644 (file)
@@ -1,3 +1,15 @@
+2019-03-11  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: REGRESSION: Network Cookies Table does not load
+        https://bugs.webkit.org/show_bug.cgi?id=195599
+
+        Reviewed by Devin Rousso.
+
+        * UserInterface/Views/ResourceCookiesContentView.js:
+        (WI.ResourceCookiesContentView.prototype.tableIndexForRepresentedObject):
+        (WI.ResourceCookiesContentView.prototype.tableRepresentedObjectForIndex):
+        Include needed delegate methods.
+
 2019-03-11  Devin Rousso  <drousso@apple.com>
 
         Web Inspector: use -webkit-{margin,padding}-{start,end} instead of [dir={ltr/rtl}] rules
index f0b02fe..79e77ef 100644 (file)
@@ -56,6 +56,21 @@ WI.ResourceCookiesContentView = class ResourceCookiesContentView extends WI.Cont
         table.reloadData();
     }
 
+    tableIndexForRepresentedObject(table, object)
+    {
+        let cookies = this._dataSourceForTable(table);
+        let index = cookies.indexOf(object);
+        console.assert(index >= 0);
+        return index;
+    }
+
+    tableRepresentedObjectForIndex(table, index)
+    {
+        let cookies = this._dataSourceForTable(table);
+        console.assert(index >= 0 && index < cookies.length);
+        return cookies[index];
+    }
+
     // Table delegate
 
     tableShouldSelectRow(table, cell, column, rowIndex)