put_by_val opcodes need to add the number tag as a 64-bit register
authorkeith_miller@apple.com <keith_miller@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 9 Nov 2018 09:22:24 +0000 (09:22 +0000)
committerkeith_miller@apple.com <keith_miller@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 9 Nov 2018 09:22:24 +0000 (09:22 +0000)
https://bugs.webkit.org/show_bug.cgi?id=191456

Reviewed by Saam Barati.

Previously the LLInt would add it as a pointer sized value. That is
wrong if pointer size is less 64-bits.

* llint/LowLevelInterpreter64.asm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/JavaScriptCore/ChangeLog
Source/JavaScriptCore/llint/LowLevelInterpreter64.asm

index 6d74b4f..743915e 100644 (file)
@@ -1,3 +1,15 @@
+2018-11-08  Keith Miller  <keith_miller@apple.com>
+
+        put_by_val opcodes need to add the number tag as a 64-bit register
+        https://bugs.webkit.org/show_bug.cgi?id=191456
+
+        Reviewed by Saam Barati.
+
+        Previously the LLInt would add it as a pointer sized value. That is
+        wrong if pointer size is less 64-bits.
+
+        * llint/LowLevelInterpreter64.asm:
+
 2018-11-08  Ross Kirsling  <ross.kirsling@sony.com>
 
         [JSC] isStrWhiteSpace seems redundant with Lexer<UChar>::isWhiteSpace
index 7f9e7bc..56ded71 100644 (file)
@@ -1691,7 +1691,7 @@ macro putByValOp(name, op)
                 ci2d scratch, ft0
                 jmp .ready
             .notInt:
-                addp tagTypeNumber, scratch
+                addq tagTypeNumber, scratch
                 fq2d scratch, ft0
                 bdnequn ft0, ft0, .opPutByValSlow
             .ready: